fix(ci): disable legacy Gitlab exec in order to fix jobs failing with green status #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2025-07-15 09:47:03 Comparing candidate commit d822985 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #225 +/- ##
=======================================
Coverage 86.45% 86.45%
=======================================
Files 80 80
Lines 5251 5251
=======================================
Hits 4540 4540
Misses 711 711 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrewlock
added a commit
to DataDog/dd-trace-dotnet
that referenced
this pull request
Jul 15, 2025
…atus (#7223) ## Summary of changes Disables `FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY` that we used before to ensure build containers have QoS guaranteed. As of now, it doesn't seem to be necessary anymore, but leads to problems like https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4119. ## Reason for change Apparently it there were issues with Gitlab CI jobs silently randomly failing with a green status. ## Implementation details Delete usages of `FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY` and `KUBERNETES_SERVICE_ACCOUNT_OVERWRITE` ## Test coverage This is the test ## Other details I based this email on similar PRs raised by @ddyurchenko e.g. - DataDog/dd-trace-cpp#225 - DataDog/dd-trace-js#6097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Disables FF_USE_LEGACY_KUBERNETES_EXECUTION_STRATEGY that we used before to ensure build containers have QoS guaranteed. As of now, it doesn't seem to be necessary anymore, but leads to problems like https://gitlab.com/gitlab-org/gitlab-runner/-/issues/4119.
Motivation
Fix issue with GItlab CI jobs silently randomly failing with a green status.