Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/datadog/telemetry_metrics.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ const telemetry::Counter extracted = {"context_header_style.extracted",
"tracers", true};
const telemetry::Counter truncated = {"context_header.truncated", "tracers",
true};
const telemetry::Counter malformed = {"context_header_style.malformed", "tracers",
true};
} // namespace trace_context

} // namespace tracer
Expand Down
4 changes: 4 additions & 0 deletions src/datadog/telemetry_metrics.h
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,10 @@ extern const telemetry::Counter extracted;
/// reason for truncation (`truncation_reason:baggage_item_count_exceeded`,
/// `truncation_reason:baggage_byte_count_exceeded`)
extern const telemetry::Counter truncated;

/// The number of times baggage headers are dropped because they're malformed
/// (missing key/value/'='), tagged by header style (`header_style:baggage`)
extern const telemetry::Counter malformed;
} // namespace trace_context

} // namespace tracer
Expand Down
5 changes: 5 additions & 0 deletions src/datadog/tracer.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,11 @@ Expected<Baggage, Baggage::Error> Tracer::extract_baggage(
if (maybe_baggage) {
telemetry::counter::increment(metrics::tracer::trace_context::extracted,
{"header_style:baggage"});
} else if (auto err = maybe_baggage.if_error()) {
if (err->code == Baggage::Error::MALFORMED_BAGGAGE_HEADER) {
telemetry::counter::increment(metrics::tracer::trace_context::malformed,
{"header_style:baggage"});
}
}
return maybe_baggage;
}
Expand Down