-
Notifications
You must be signed in to change notification settings - Fork 15
chore(cmake): overall improvements #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ead46a0 to
23768e9
Compare
23768e9 to
6ea195e
Compare
6ea195e to
a5ed479
Compare
a5ed479 to
0b67c93
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 87.53% 87.62% +0.08%
==========================================
Files 83 83
Lines 5463 5502 +39
==========================================
+ Hits 4782 4821 +39
Misses 681 681 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎯 Code Coverage 🔗 Commit SHA: 351927f | Docs | Was this helpful? Give us feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be helpful to know from which version of Catch2 these cmake files were vendored, but not sure where you'd want to indicate that
zacharycmontoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've learned a lot about Cmake today 😄
Description
Motivation
Additional Notes
Jira ticket: [PROJ-IDENT]