Skip to content

Conversation

@dmehala
Copy link
Collaborator

@dmehala dmehala commented Sep 10, 2025

Description

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@dmehala dmehala force-pushed the dmehala/cmake-export branch from ead46a0 to 23768e9 Compare September 22, 2025 11:44
@dmehala dmehala force-pushed the dmehala/cmake-export branch from 23768e9 to 6ea195e Compare September 22, 2025 11:58
@dmehala dmehala force-pushed the dmehala/cmake-export branch from 6ea195e to a5ed479 Compare September 22, 2025 12:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.62%. Comparing base (ae0d9a3) to head (351927f).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
+ Coverage   87.53%   87.62%   +0.08%     
==========================================
  Files          83       83              
  Lines        5463     5502      +39     
==========================================
+ Hits         4782     4821      +39     
  Misses        681      681              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-official
Copy link

datadog-official bot commented Sep 22, 2025

🎯 Code Coverage
Patch Coverage: 100.00%
Total Coverage: 87.62% (+0.09%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 351927f | Docs | Was this helpful? Give us feedback!

@dmehala dmehala marked this pull request as ready for review September 22, 2025 14:16
@dmehala dmehala requested a review from a team as a code owner September 22, 2025 14:16
@dmehala dmehala requested review from dubloom and zacharycmontoya and removed request for a team September 22, 2025 14:16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to know from which version of Catch2 these cmake files were vendored, but not sure where you'd want to indicate that

Copy link
Contributor

@zacharycmontoya zacharycmontoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've learned a lot about Cmake today 😄

@pr-commenter
Copy link

pr-commenter bot commented Oct 14, 2025

Benchmarks

Benchmark execution time: 2025-10-14 12:27:43

Comparing candidate commit 351927f in PR branch dmehala/cmake-export with baseline commit ae0d9a3 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@dmehala dmehala merged commit b625050 into main Oct 14, 2025
24 checks passed
@dmehala dmehala deleted the dmehala/cmake-export branch October 14, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants