fix abseil for bazel build#8
Merged
Merged
Conversation
cataphract
pushed a commit
to cataphract/dd-trace-cpp
that referenced
this pull request
Mar 28, 2024
* Revise resource names: - Add configuration directive `datadog_resource_name` for setting the resource name of the request span. - Add configuration directive `datadog_location_resource_name` for setting the resource name of the location span. - Change the default resource name to be `$request_method $uri` instead of `$request_method $datadog_location`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a mistake in #7 -- Bazel builds Abseil "the normal way," with
absl::string_viewandabsl::optionalforwarding to the correspondingstdtypes. However, Envoy patches Abseil's configuration to force those two types (and others) to use Abseil's backports.When I added the corresponding patch to our Bazel build, there were many compiler errors due to the absence of
operator+=(std::string&, absl::string_view),std::hash<absl::string_view>,absl::nullopt, etc.This pull request resolves those compilation errors.