Skip to content

Conversation

@dmehala
Copy link
Collaborator

@dmehala dmehala commented Jan 26, 2024

Description

This PR add support for DD_TAGS dynamic configuration.

@dmehala dmehala requested review from cgilmour and dgoffredo January 26, 2024 14:59
@pr-commenter
Copy link

pr-commenter bot commented Jan 26, 2024

Benchmarks

Benchmark execution time: 2024-01-31 15:51:48

Comparing candidate commit 2e6c319 in PR branch dmehala/add-rc-tags with baseline commit 6605685 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

Copy link
Contributor

@dgoffredo dgoffredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks for putting this together.

Please add a test of the new behavior. Other than that, this is ready to merge.

Copy link
Contributor

@dgoffredo dgoffredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

et voila, nice work

@dmehala dmehala merged commit 8c3969c into main Jan 31, 2024
@dmehala dmehala deleted the dmehala/add-rc-tags branch January 31, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants