SET(CURL_ZLIB OFF) #99
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More recent Alpine images were failing to build nginx-datadog due to libz.so being in a different location on the file system than expected by the build produced by CMake. We do not want to build (libcurl) with zlib anyway. Looking around, I found that CURL_ZLIB was needed in addition to (or instead of?) USE_ZLIB.
BenchmarksBenchmark execution time: 2024-02-28 00:04:06 Comparing candidate commit 7c8f86b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More recent Alpine images were failing to build nginx-datadog due to libz.so being in a different location on the file system than expected by the build produced by CMake.
We do not want to build (libcurl) with zlib anyway. Looking around, I found that CURL_ZLIB was needed in addition to (or instead of?) USE_ZLIB.