Skip to content

Enable CA1851 - Avoid multiple enumeration of collections#8341

Merged
andrewlock merged 1 commit intomasterfrom
andrew/analyzers/multiple-enumerations
Mar 26, 2026
Merged

Enable CA1851 - Avoid multiple enumeration of collections#8341
andrewlock merged 1 commit intomasterfrom
andrew/analyzers/multiple-enumerations

Conversation

@andrewlock
Copy link
Copy Markdown
Member

Summary of changes

Enables CA1851, fixes one violations, and ignores an existing

Reason for change

We want to enable this analayzer. Although, interestingly, there are cases where this won't touch, which we should potentially also have analyzers for. For example:

  • We instrument a method that takes an IEnumerable (could be call target, could be callsite aspects)
  • We enumerate the collection
  • The instrumented method runs, enumerating it again

If this isn't a materialized collection, this could be very expensive. Potentially, we should instead do:

  • Call ToList() on the parameter
  • Do our thing
  • Pass the list into the method

But that also has risks 😅 So ideally... we just don't touch IEnumerables 😅 🤷‍♂️

Implementation details

  • Enable the analyzer
  • For the StringModuleImpl, The Count() call was to ensure we pass addDelimiterRanges: false on the final iteration. Converting to a "manually implemented" foreach using a "peek ahead" approach avoids the multiple enumerations
  • For the Encoder, it's all recursive and really hard to follow what the inputs are actually going to be here, so I just declared bankruptcy and put the #pragma in. If ASM want to fix it "properly" later, that's good, but don't want to block enabling the analyzer because of it

Test coverage

Covered by existing

Other details

https://datadoghq.atlassian.net/browse/LANGPLAT-813

Stacked on

@andrewlock andrewlock requested review from a team as code owners March 19, 2026 14:21
@andrewlock andrewlock added the type:performance Performance, speed, latency, resource usage (CPU, memory) label Mar 19, 2026
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 19, 2026

Benchmarks

Benchmark execution time: 2026-03-26 09:19:53

Comparing candidate commit 2bac6c8 in PR branch andrew/analyzers/multiple-enumerations with baseline commit da0f277 in branch master.

Found 9 performance improvements and 9 performance regressions! Performance is the same for 257 metrics, 13 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:Benchmarks.Trace.AgentWriterBenchmark.WriteAndFlushEnrichedTraces net6.0

  • 🟩 execution_time [-83.379ms; -83.287ms] or [-40.416%; -40.371%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleMoreComplexBody net6.0

  • 🟥 execution_time [+11.021ms; +16.659ms] or [+5.544%; +8.380%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.AllCycleSimpleBody netcoreapp3.1

  • 🟩 execution_time [-16.222ms; -11.878ms] or [-7.545%; -5.524%]

scenario:Benchmarks.Trace.Asm.AppSecBodyBenchmark.ObjectExtractorSimpleBody netcoreapp3.1

  • 🟩 execution_time [-23.532ms; -17.647ms] or [-10.886%; -8.163%]

scenario:Benchmarks.Trace.Asm.AppSecEncoderBenchmark.EncodeLegacyArgs netcoreapp3.1

  • 🟥 execution_time [+20.686ms; +21.269ms] or [+11.432%; +11.754%]

scenario:Benchmarks.Trace.Asm.AppSecWafBenchmark.RunWafRealisticBenchmarkWithAttack net6.0

  • 🟩 execution_time [-41.578µs; -24.729µs] or [-12.279%; -7.303%]
  • 🟩 throughput [+248.781op/s; +403.791op/s] or [+8.421%; +13.668%]

scenario:Benchmarks.Trace.AspNetCoreBenchmark.SendRequest net6.0

  • 🟥 execution_time [+107.196ms; +108.471ms] or [+115.337%; +116.710%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net472

  • 🟩 execution_time [-155.760µs; -152.893µs] or [-7.536%; -7.397%]
  • 🟩 throughput [+38.674op/s; +39.405op/s] or [+7.994%; +8.145%]

scenario:Benchmarks.Trace.CharSliceBenchmark.OptimizedCharSlice net6.0

  • 🟩 execution_time [-110.424µs; -105.096µs] or [-7.468%; -7.107%]
  • 🟩 throughput [+51.890op/s; +54.416op/s] or [+7.673%; +8.046%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark net6.0

  • 🟥 allocated_mem [+18.407KB; +18.438KB] or [+7.193%; +7.205%]

scenario:Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark netcoreapp3.1

  • 🟥 allocated_mem [+20.364KB; +20.390KB] or [+7.966%; +7.976%]
  • 🟥 throughput [-445.642op/s; -249.529op/s] or [-20.542%; -11.502%]

scenario:Benchmarks.Trace.SerilogBenchmark.EnrichedLog net6.0

  • 🟥 throughput [-15755.058op/s; -11714.627op/s] or [-6.807%; -5.062%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishScope netcoreapp3.1

  • 🟥 execution_time [+11.912ms; +12.848ms] or [+5.931%; +6.397%]

scenario:Benchmarks.Trace.SpanBenchmark.StartFinishTwoScopes net6.0

  • 🟥 execution_time [+18.024ms; +23.756ms] or [+9.144%; +12.052%]

@dd-trace-dotnet-ci-bot
Copy link
Copy Markdown

dd-trace-dotnet-ci-bot Bot commented Mar 19, 2026

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing This PR (8341) and master.

✅ No regressions detected - check the details below

Full Metrics Comparison

FakeDbCommand

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration72.18 ± (72.21 - 72.55) ms72.19 ± (72.23 - 72.55) ms+0.0%✅⬆️
.NET Framework 4.8 - Bailout
duration76.06 ± (75.98 - 76.23) ms76.35 ± (76.18 - 76.52) ms+0.4%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1074.17 ± (1074.02 - 1080.94) ms1075.59 ± (1079.59 - 1087.32) ms+0.1%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms22.27 ± (22.23 - 22.32) ms22.53 ± (22.49 - 22.56) ms+1.1%✅⬆️
process.time_to_main_ms83.84 ± (83.65 - 84.04) ms84.22 ± (84.03 - 84.42) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.91 ± (10.90 - 10.91) MB10.95 ± (10.94 - 10.95) MB+0.4%✅⬆️
runtime.dotnet.threads.count12 ± (12 - 12)12 ± (12 - 12)+0.0%
.NET Core 3.1 - Bailout
process.internal_duration_ms22.20 ± (22.16 - 22.23) ms22.49 ± (22.45 - 22.53) ms+1.3%✅⬆️
process.time_to_main_ms84.99 ± (84.80 - 85.17) ms85.63 ± (85.42 - 85.84) ms+0.8%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.95 ± (10.95 - 10.95) MB10.98 ± (10.98 - 10.99) MB+0.3%✅⬆️
runtime.dotnet.threads.count13 ± (13 - 13)13 ± (13 - 13)+0.0%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms224.19 ± (223.03 - 225.36) ms227.45 ± (226.01 - 228.90) ms+1.5%✅⬆️
process.time_to_main_ms533.18 ± (532.04 - 534.32) ms535.49 ± (534.20 - 536.79) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed48.17 ± (48.14 - 48.20) MB48.21 ± (48.18 - 48.24) MB+0.1%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-1.0%
.NET 6 - Baseline
process.internal_duration_ms20.99 ± (20.95 - 21.03) ms21.13 ± (21.10 - 21.16) ms+0.7%✅⬆️
process.time_to_main_ms72.11 ± (71.93 - 72.30) ms72.76 ± (72.57 - 72.94) ms+0.9%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.62 ± (10.62 - 10.62) MB10.64 ± (10.64 - 10.64) MB+0.2%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 6 - Bailout
process.internal_duration_ms20.87 ± (20.83 - 20.92) ms21.07 ± (21.03 - 21.10) ms+0.9%✅⬆️
process.time_to_main_ms72.72 ± (72.56 - 72.88) ms74.29 ± (74.11 - 74.47) ms+2.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed10.68 ± (10.68 - 10.69) MB10.75 ± (10.75 - 10.76) MB+0.7%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms213.74 ± (212.59 - 214.90) ms215.13 ± (213.90 - 216.37) ms+0.6%✅⬆️
process.time_to_main_ms532.98 ± (531.77 - 534.18) ms536.11 ± (534.65 - 537.57) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed50.07 ± (50.04 - 50.09) MB50.17 ± (50.14 - 50.20) MB+0.2%✅⬆️
runtime.dotnet.threads.count29 ± (29 - 29)29 ± (29 - 29)-0.1%
.NET 8 - Baseline
process.internal_duration_ms19.30 ± (19.26 - 19.34) ms19.18 ± (19.15 - 19.21) ms-0.6%
process.time_to_main_ms71.83 ± (71.63 - 72.02) ms71.58 ± (71.42 - 71.73) ms-0.3%
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.68 ± (7.67 - 7.68) MB7.72 ± (7.71 - 7.73) MB+0.5%✅⬆️
runtime.dotnet.threads.count10 ± (10 - 10)10 ± (10 - 10)+0.0%
.NET 8 - Bailout
process.internal_duration_ms19.16 ± (19.12 - 19.20) ms19.40 ± (19.36 - 19.44) ms+1.2%✅⬆️
process.time_to_main_ms72.23 ± (72.13 - 72.34) ms73.29 ± (73.13 - 73.44) ms+1.5%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed7.74 ± (7.73 - 7.74) MB7.76 ± (7.75 - 7.76) MB+0.2%✅⬆️
runtime.dotnet.threads.count11 ± (11 - 11)11 ± (11 - 11)+0.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms160.92 ± (159.91 - 161.94) ms160.76 ± (160.06 - 161.47) ms-0.1%
process.time_to_main_ms487.92 ± (486.95 - 488.90) ms493.85 ± (492.80 - 494.90) ms+1.2%✅⬆️
runtime.dotnet.exceptions.count0 ± (0 - 0)0 ± (0 - 0)+0.0%
runtime.dotnet.mem.committed36.85 ± (36.82 - 36.88) MB36.99 ± (36.97 - 37.02) MB+0.4%✅⬆️
runtime.dotnet.threads.count28 ± (28 - 28)28 ± (28 - 28)-0.2%

HttpMessageHandler

Metric Master (Mean ± 95% CI) Current (Mean ± 95% CI) Change Status
.NET Framework 4.8 - Baseline
duration193.86 ± (193.81 - 194.68) ms194.73 ± (194.35 - 195.11) ms+0.5%✅⬆️
.NET Framework 4.8 - Bailout
duration197.09 ± (197.00 - 197.47) ms197.92 ± (197.88 - 198.81) ms+0.4%✅⬆️
.NET Framework 4.8 - CallTarget+Inlining+NGEN
duration1154.11 ± (1155.88 - 1163.35) ms1157.78 ± (1162.26 - 1171.18) ms+0.3%✅⬆️
.NET Core 3.1 - Baseline
process.internal_duration_ms187.87 ± (187.56 - 188.18) ms188.11 ± (187.75 - 188.46) ms+0.1%✅⬆️
process.time_to_main_ms80.99 ± (80.74 - 81.23) ms80.99 ± (80.76 - 81.22) ms+0.0%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.09 ± (16.06 - 16.12) MB16.12 ± (16.09 - 16.15) MB+0.2%✅⬆️
runtime.dotnet.threads.count20 ± (19 - 20)20 ± (19 - 20)-0.1%
.NET Core 3.1 - Bailout
process.internal_duration_ms187.67 ± (187.29 - 188.06) ms188.22 ± (187.76 - 188.69) ms+0.3%✅⬆️
process.time_to_main_ms82.43 ± (82.24 - 82.63) ms82.56 ± (82.35 - 82.77) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed16.16 ± (16.13 - 16.19) MB16.20 ± (16.17 - 16.23) MB+0.2%✅⬆️
runtime.dotnet.threads.count21 ± (21 - 21)21 ± (21 - 21)-0.1%
.NET Core 3.1 - CallTarget+Inlining+NGEN
process.internal_duration_ms394.51 ± (393.01 - 396.01) ms395.76 ± (394.64 - 396.89) ms+0.3%✅⬆️
process.time_to_main_ms522.77 ± (521.68 - 523.87) ms524.69 ± (523.76 - 525.61) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count3 ± (3 - 3)3 ± (3 - 3)+0.0%
runtime.dotnet.mem.committed58.67 ± (58.49 - 58.85) MB59.03 ± (58.92 - 59.14) MB+0.6%✅⬆️
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)-0.2%
.NET 6 - Baseline
process.internal_duration_ms193.11 ± (192.81 - 193.42) ms194.32 ± (193.86 - 194.79) ms+0.6%✅⬆️
process.time_to_main_ms70.53 ± (70.36 - 70.70) ms70.80 ± (70.59 - 71.01) ms+0.4%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.37 ± (16.34 - 16.40) MB16.41 ± (16.38 - 16.44) MB+0.3%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)+0.2%✅⬆️
.NET 6 - Bailout
process.internal_duration_ms192.40 ± (192.03 - 192.78) ms193.86 ± (193.37 - 194.35) ms+0.8%✅⬆️
process.time_to_main_ms71.36 ± (71.22 - 71.51) ms71.72 ± (71.55 - 71.88) ms+0.5%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed16.25 ± (16.13 - 16.38) MB16.39 ± (16.32 - 16.45) MB+0.8%✅⬆️
runtime.dotnet.threads.count19 ± (19 - 20)20 ± (20 - 20)+2.5%✅⬆️
.NET 6 - CallTarget+Inlining+NGEN
process.internal_duration_ms419.18 ± (417.71 - 420.64) ms419.37 ± (417.79 - 420.96) ms+0.0%✅⬆️
process.time_to_main_ms524.80 ± (523.65 - 525.96) ms526.37 ± (524.97 - 527.78) ms+0.3%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed60.91 ± (60.86 - 60.96) MB60.90 ± (60.86 - 60.95) MB-0.0%
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 31)+0.2%✅⬆️
.NET 8 - Baseline
process.internal_duration_ms191.15 ± (190.81 - 191.49) ms190.56 ± (190.19 - 190.92) ms-0.3%
process.time_to_main_ms70.04 ± (69.82 - 70.26) ms69.61 ± (69.43 - 69.80) ms-0.6%
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.71 ± (11.68 - 11.74) MB11.72 ± (11.70 - 11.75) MB+0.1%✅⬆️
runtime.dotnet.threads.count18 ± (18 - 18)18 ± (18 - 18)-0.5%
.NET 8 - Bailout
process.internal_duration_ms189.51 ± (189.18 - 189.85) ms189.42 ± (189.12 - 189.73) ms-0.0%
process.time_to_main_ms70.53 ± (70.40 - 70.66) ms70.69 ± (70.58 - 70.79) ms+0.2%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed11.82 ± (11.79 - 11.86) MB11.67 ± (11.59 - 11.75) MB-1.3%
runtime.dotnet.threads.count19 ± (19 - 19)19 ± (19 - 19)-1.0%
.NET 8 - CallTarget+Inlining+NGEN
process.internal_duration_ms342.54 ± (341.61 - 343.47) ms344.24 ± (343.16 - 345.33) ms+0.5%✅⬆️
process.time_to_main_ms482.13 ± (481.22 - 483.04) ms485.14 ± (484.20 - 486.08) ms+0.6%✅⬆️
runtime.dotnet.exceptions.count4 ± (4 - 4)4 ± (4 - 4)+0.0%
runtime.dotnet.mem.committed48.88 ± (48.85 - 48.91) MB48.85 ± (48.81 - 48.88) MB-0.1%
runtime.dotnet.threads.count30 ± (30 - 30)30 ± (30 - 30)+0.1%✅⬆️
Comparison explanation

Execution-time benchmarks measure the whole time it takes to execute a program, and are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are highlighted in **red**. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

Duration charts
FakeDbCommand (.NET Framework 4.8)
gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8341) - mean (72ms)  : 70, 75
    master - mean (72ms)  : 70, 75

    section Bailout
    This PR (8341) - mean (76ms)  : 75, 78
    master - mean (76ms)  : 75, 77

    section CallTarget+Inlining+NGEN
    This PR (8341) - mean (1,083ms)  : 1028, 1139
    master - mean (1,077ms)  : 1028, 1127

Loading
FakeDbCommand (.NET Core 3.1)
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8341) - mean (114ms)  : 110, 118
    master - mean (113ms)  : 108, 117

    section Bailout
    This PR (8341) - mean (115ms)  : 112, 118
    master - mean (114ms)  : 111, 117

    section CallTarget+Inlining+NGEN
    This PR (8341) - mean (799ms)  : 780, 818
    master - mean (796ms)  : 778, 813

Loading
FakeDbCommand (.NET 6)
gantt
    title Execution time (ms) FakeDbCommand (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8341) - mean (100ms)  : 97, 103
    master - mean (99ms)  : 95, 103

    section Bailout
    This PR (8341) - mean (102ms)  : 99, 105
    master - mean (100ms)  : 97, 102

    section CallTarget+Inlining+NGEN
    This PR (8341) - mean (790ms)  : 767, 814
    master - mean (786ms)  : 764, 808

Loading
FakeDbCommand (.NET 8)
gantt
    title Execution time (ms) FakeDbCommand (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8341) - mean (98ms)  : 95, 102
    master - mean (99ms)  : 94, 103

    section Bailout
    This PR (8341) - mean (100ms)  : 98, 102
    master - mean (99ms)  : 97, 101

    section CallTarget+Inlining+NGEN
    This PR (8341) - mean (695ms)  : 677, 714
    master - mean (690ms)  : 670, 710

Loading
HttpMessageHandler (.NET Framework 4.8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8341) - mean (195ms)  : 191, 199
    master - mean (194ms)  : 190, 198

    section Bailout
    This PR (8341) - mean (198ms)  : 194, 203
    master - mean (197ms)  : 195, 199

    section CallTarget+Inlining+NGEN
    This PR (8341) - mean (1,167ms)  : 1098, 1235
    master - mean (1,160ms)  : 1104, 1215

Loading
HttpMessageHandler (.NET Core 3.1)
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8341) - mean (277ms)  : 273, 282
    master - mean (277ms)  : 272, 281

    section Bailout
    This PR (8341) - mean (279ms)  : 274, 284
    master - mean (278ms)  : 273, 283

    section CallTarget+Inlining+NGEN
    This PR (8341) - mean (951ms)  : 926, 976
    master - mean (949ms)  : 924, 975

Loading
HttpMessageHandler (.NET 6)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8341) - mean (273ms)  : 267, 279
    master - mean (272ms)  : 267, 277

    section Bailout
    This PR (8341) - mean (274ms)  : 265, 282
    master - mean (272ms)  : 267, 277

    section CallTarget+Inlining+NGEN
    This PR (8341) - mean (974ms)  : 952, 996
    master - mean (973ms)  : 949, 996

Loading
HttpMessageHandler (.NET 8)
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8)
    dateFormat  x
    axisFormat %Q
    todayMarker off
    section Baseline
    This PR (8341) - mean (270ms)  : 265, 275
    master - mean (271ms)  : 266, 276

    section Bailout
    This PR (8341) - mean (270ms)  : 266, 274
    master - mean (269ms)  : 265, 274

    section CallTarget+Inlining+NGEN
    This PR (8341) - mean (860ms)  : 835, 884
    master - mean (856ms)  : 824, 887

Loading

Copy link
Copy Markdown
Collaborator

@NachoEchevarria NachoEchevarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@andrewlock andrewlock force-pushed the andrew/analyzers/multiple-enumerations branch from 25b4d09 to b77ffa5 Compare March 25, 2026 11:57
@andrewlock andrewlock requested review from a team as code owners March 25, 2026 11:57
@andrewlock andrewlock requested review from zacharycmontoya and removed request for a team March 25, 2026 11:57
@andrewlock andrewlock force-pushed the andrew/analyzers/use-concrete-types branch from c5e641a to 0734582 Compare March 25, 2026 11:57
@andrewlock andrewlock force-pushed the andrew/analyzers/multiple-enumerations branch from b77ffa5 to b6540ba Compare March 25, 2026 16:54
@andrewlock andrewlock force-pushed the andrew/analyzers/use-concrete-types branch from 0734582 to a65c4fb Compare March 25, 2026 16:54
Base automatically changed from andrew/analyzers/use-concrete-types to master March 26, 2026 08:36
@andrewlock andrewlock force-pushed the andrew/analyzers/multiple-enumerations branch from b6540ba to 2bac6c8 Compare March 26, 2026 08:38
@andrewlock andrewlock merged commit 3dd19e4 into master Mar 26, 2026
139 checks passed
@andrewlock andrewlock deleted the andrew/analyzers/multiple-enumerations branch March 26, 2026 15:33
@github-actions github-actions Bot added this to the vNext-v3 milestone Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:performance Performance, speed, latency, resource usage (CPU, memory)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants