Skip to content

Increase IAST propagation to StringBuffer subSequence #8038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mariovido merged 2 commits into from
Dec 12, 2024
Merged

Increase IAST propagation to StringBuffer subSequence #8038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de38cb1
Add subsequence for the stringbuffer
Mariovido Nov 29, 2024
25745a2
Merge branch 'master' into mario.vidal/taint_tracking_string_buffer_s…
Mariovido Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...ava-lang/src/main/java/datadog/trace/instrumentation/java/lang/StringBuilderCallSite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,7 @@ public static String afterSubstring(
}

@CallSite.After("java.lang.CharSequence java.lang.StringBuilder.subSequence(int, int)")
@CallSite.After("java.lang.CharSequence java.lang.StringBuffer.subSequence(int, int)")
public static CharSequence afterSubSequence(
@CallSite.This final CharSequence self,
@CallSite.Argument final int beginIndex,
Expand Down
1 change: 1 addition & 0 deletions .../src/test/groovy/datadog/trace/instrumentation/java/lang/StringBuilderCallSiteTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ class StringBuilderCallSiteTest extends AgentTestRunner {
where:
type | suite | param | beginIndex | endIndex | expected
"builder" | new TestStringBuilderSuite() | sb('012345') | 1 | 5 | '1234'
"buffer" | new TestStringBufferSuite() | sbf('012345') | 1 | 5 | '1234'
}

private static class BrokenToString {
Expand Down
Loading