Skip to content

Add configurable Dependency service resolution period #8079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jandro996 merged 1 commit into from
Dec 12, 2024
Merged

Add configurable Dependency service resolution period #8079

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dd-trace-api/src/main/java/datadog/trace/api/config/GeneralConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,8 @@ public final class GeneralConfig {
public static final String AGENTLESS_LOG_SUBMISSION_ENABLED = "agentless.log.submission.enabled";
public static final String AGENTLESS_LOG_SUBMISSION_QUEUE_SIZE =
"agentless.log.submission.queue.size";
public static final String TELEMETRY_DEPENDENCY_RESOLUTION_PERIOD_MILLIS =
"telemetry.dependency.resolution.period.millis";
public static final String AGENTLESS_LOG_SUBMISSION_LEVEL = "agentless.log.submission.level";
public static final String AGENTLESS_LOG_SUBMISSION_URL = "agentless.log.submission.url";

Expand Down
11 changes: 11 additions & 0 deletions internal-api/src/main/java/datadog/trace/api/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,8 @@ public static String getHostName() {
private final int cloudPayloadTaggingMaxDepth;
private final int cloudPayloadTaggingMaxTags;

private final long dependecyResolutionPeriodMillis;

// Read order: System Properties -> Env Variables, [-> properties file], [-> default value]
private Config() {
this(ConfigProvider.createDefault());
Expand Down Expand Up @@ -1802,6 +1804,11 @@ PROFILING_DATADOG_PROFILER_ENABLED, isDatadogProfilerSafeInCurrentEnvironment())
this.cloudPayloadTaggingMaxTags =
configProvider.getInteger(TracerConfig.TRACE_CLOUD_PAYLOAD_TAGGING_MAX_TAGS, 758);

this.dependecyResolutionPeriodMillis =
configProvider.getLong(
GeneralConfig.TELEMETRY_DEPENDENCY_RESOLUTION_PERIOD_MILLIS,
1000); // 1 second by default

timelineEventsEnabled =
configProvider.getBoolean(
ProfilingConfig.PROFILING_TIMELINE_EVENTS_ENABLED,
Expand Down Expand Up @@ -3700,6 +3707,10 @@ public boolean isEnabled(
Collections.singletonList(settingName), "", settingSuffix, defaultEnabled);
}

public long getDependecyResolutionPeriodMillis() {
return dependecyResolutionPeriodMillis;
}

public boolean isDBMTracePreparedStatements() {
return DBMTracePreparedStatements;
}
Expand Down
7 changes: 6 additions & 1 deletion telemetry/src/main/java/datadog/telemetry/dependency/DependencyService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package datadog.telemetry.dependency;

import datadog.trace.api.Config;
import datadog.trace.util.AgentTaskScheduler;
import java.lang.instrument.Instrumentation;
import java.net.URI;
Expand Down Expand Up @@ -31,7 +32,11 @@ public class DependencyService implements Runnable {
public void schedulePeriodicResolution() {
scheduledTask =
AgentTaskScheduler.INSTANCE.scheduleAtFixedRate(
AgentTaskScheduler.RunnableTask.INSTANCE, this, 0, 1000L, TimeUnit.MILLISECONDS);
AgentTaskScheduler.RunnableTask.INSTANCE,
this,
0,
Config.get().getDependecyResolutionPeriodMillis(),
TimeUnit.MILLISECONDS);
}

public void resolveOneDependency() {
Expand Down
Loading