-
Notifications
You must be signed in to change notification settings - Fork 324
Disable backend requests for impacted tests data #8391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/disable-impacted-tests-backend
Feb 14, 2025
Merged
Disable backend requests for impacted tests data #8391
nikita-tkachenko-datadog
merged 1 commit into
master
from
nikita-tkachenko/disable-impacted-tests-backend
Feb 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 58 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~7a0b1534d4, baseline=1.47.0-SNAPSHOT~053a36f28a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.049 s) : 0, 1048979
Total [baseline] (8.707 s) : 0, 8706509
Agent [candidate] (1.05 s) : 0, 1049565
Total [candidate] (8.658 s) : 0, 8658244
section iast
Agent [baseline] (1.172 s) : 0, 1171962
Total [baseline] (9.267 s) : 0, 9266984
Agent [candidate] (1.17 s) : 0, 1170046
Total [candidate] (9.302 s) : 0, 9302413
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.178 s) : 0, 1178119
Total [baseline] (9.233 s) : 0, 9232632
Agent [candidate] (1.171 s) : 0, 1171491
Total [candidate] (9.257 s) : 0, 9256876
section iast_TELEMETRY_OFF
Agent [baseline] (1.166 s) : 0, 1165872
Total [baseline] (9.282 s) : 0, 9281923
Agent [candidate] (1.179 s) : 0, 1179342
Total [candidate] (9.263 s) : 0, 9263141
gantt
title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~7a0b1534d4, baseline=1.47.0-SNAPSHOT~053a36f28a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (723.428 ms) : 0, 723428
BytebuddyAgent [candidate] (722.062 ms) : 0, 722062
GlobalTracer [baseline] (240.828 ms) : 0, 240828
GlobalTracer [candidate] (241.925 ms) : 0, 241925
AppSec [baseline] (55.77 ms) : 0, 55770
AppSec [candidate] (55.868 ms) : 0, 55868
Remote Config [baseline] (700.124 µs) : 0, 700
Remote Config [candidate] (709.896 µs) : 0, 710
Telemetry [baseline] (12.835 ms) : 0, 12835
Telemetry [candidate] (13.696 ms) : 0, 13696
section iast
BytebuddyAgent [baseline] (836.688 ms) : 0, 836688
BytebuddyAgent [candidate] (834.498 ms) : 0, 834498
GlobalTracer [baseline] (230.802 ms) : 0, 230802
GlobalTracer [candidate] (230.368 ms) : 0, 230368
IAST [baseline] (22.788 ms) : 0, 22788
IAST [candidate] (22.886 ms) : 0, 22886
AppSec [baseline] (57.147 ms) : 0, 57147
AppSec [candidate] (57.669 ms) : 0, 57669
Remote Config [baseline] (612.762 µs) : 0, 613
Remote Config [candidate] (616.169 µs) : 0, 616
Telemetry [baseline] (8.639 ms) : 0, 8639
Telemetry [candidate] (8.752 ms) : 0, 8752
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (841.586 ms) : 0, 841586
BytebuddyAgent [candidate] (835.602 ms) : 0, 835602
GlobalTracer [baseline] (231.261 ms) : 0, 231261
GlobalTracer [candidate] (230.895 ms) : 0, 230895
IAST [baseline] (22.954 ms) : 0, 22954
IAST [candidate] (22.932 ms) : 0, 22932
AppSec [baseline] (57.644 ms) : 0, 57644
AppSec [candidate] (57.421 ms) : 0, 57421
Remote Config [baseline] (633.086 µs) : 0, 633
Remote Config [candidate] (626.907 µs) : 0, 627
Telemetry [baseline] (8.727 ms) : 0, 8727
Telemetry [candidate] (8.753 ms) : 0, 8753
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.948 ms) : 0, 831948
BytebuddyAgent [candidate] (843.646 ms) : 0, 843646
GlobalTracer [baseline] (230.703 ms) : 0, 230703
GlobalTracer [candidate] (231.629 ms) : 0, 231629
IAST [baseline] (25.895 ms) : 0, 25895
IAST [candidate] (23.84 ms) : 0, 23840
AppSec [baseline] (52.923 ms) : 0, 52923
AppSec [candidate] (55.617 ms) : 0, 55617
Remote Config [baseline] (611.755 µs) : 0, 612
Remote Config [candidate] (612.727 µs) : 0, 613
Telemetry [baseline] (8.52 ms) : 0, 8520
Telemetry [candidate] (8.591 ms) : 0, 8591
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~7a0b1534d4, baseline=1.47.0-SNAPSHOT~053a36f28a
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045503
Total [baseline] (10.624 s) : 0, 10623565
Agent [candidate] (1.049 s) : 0, 1048516
Total [candidate] (10.527 s) : 0, 10527089
section appsec
Agent [baseline] (1.181 s) : 0, 1181406
Total [baseline] (10.728 s) : 0, 10728174
Agent [candidate] (1.188 s) : 0, 1187875
Total [candidate] (10.831 s) : 0, 10831482
section iast
Agent [baseline] (1.171 s) : 0, 1171141
Total [baseline] (10.975 s) : 0, 10974558
Agent [candidate] (1.181 s) : 0, 1180944
Total [candidate] (10.979 s) : 0, 10978884
section profiling
Agent [baseline] (1.262 s) : 0, 1261921
Total [baseline] (10.984 s) : 0, 10983642
Agent [candidate] (1.262 s) : 0, 1262243
Total [candidate] (10.903 s) : 0, 10903386
gantt
title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~7a0b1534d4, baseline=1.47.0-SNAPSHOT~053a36f28a
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (719.361 ms) : 0, 719361
BytebuddyAgent [candidate] (722.797 ms) : 0, 722797
GlobalTracer [baseline] (241.492 ms) : 0, 241492
GlobalTracer [candidate] (241.513 ms) : 0, 241513
AppSec [baseline] (55.752 ms) : 0, 55752
AppSec [candidate] (55.749 ms) : 0, 55749
Remote Config [baseline] (701.184 µs) : 0, 701
Remote Config [candidate] (700.978 µs) : 0, 701
Telemetry [baseline] (12.908 ms) : 0, 12908
Telemetry [candidate] (12.303 ms) : 0, 12303
section appsec
BytebuddyAgent [baseline] (733.778 ms) : 0, 733778
BytebuddyAgent [candidate] (737.599 ms) : 0, 737599
GlobalTracer [baseline] (236.541 ms) : 0, 236541
GlobalTracer [candidate] (237.506 ms) : 0, 237506
IAST [baseline] (21.253 ms) : 0, 21253
IAST [candidate] (21.426 ms) : 0, 21426
AppSec [baseline] (176.261 ms) : 0, 176261
AppSec [candidate] (177.776 ms) : 0, 177776
Remote Config [baseline] (663.016 µs) : 0, 663
Remote Config [candidate] (669.623 µs) : 0, 670
Telemetry [baseline] (8.287 ms) : 0, 8287
Telemetry [candidate] (8.321 ms) : 0, 8321
section iast
BytebuddyAgent [baseline] (835.661 ms) : 0, 835661
BytebuddyAgent [candidate] (843.932 ms) : 0, 843932
GlobalTracer [baseline] (230.823 ms) : 0, 230823
GlobalTracer [candidate] (232.01 ms) : 0, 232010
IAST [baseline] (22.946 ms) : 0, 22946
IAST [candidate] (22.958 ms) : 0, 22958
AppSec [baseline] (57.129 ms) : 0, 57129
AppSec [candidate] (57.285 ms) : 0, 57285
Remote Config [baseline] (623.197 µs) : 0, 623
Remote Config [candidate] (615.148 µs) : 0, 615
Telemetry [baseline] (8.702 ms) : 0, 8702
Telemetry [candidate] (8.717 ms) : 0, 8717
section profiling
BytebuddyAgent [baseline] (707.061 ms) : 0, 707061
BytebuddyAgent [candidate] (708.277 ms) : 0, 708277
GlobalTracer [baseline] (350.697 ms) : 0, 350697
GlobalTracer [candidate] (351.155 ms) : 0, 351155
AppSec [baseline] (55.386 ms) : 0, 55386
AppSec [candidate] (54.771 ms) : 0, 54771
Remote Config [baseline] (677.567 µs) : 0, 678
Remote Config [candidate] (668.578 µs) : 0, 669
Telemetry [baseline] (9.02 ms) : 0, 9020
Telemetry [candidate] (8.949 ms) : 0, 8949
ProfilingAgent [baseline] (96.908 ms) : 0, 96908
ProfilingAgent [candidate] (96.065 ms) : 0, 96065
Profiling [baseline] (96.932 ms) : 0, 96932
Profiling [candidate] (96.089 ms) : 0, 96089
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~7a0b1534d4, baseline=1.47.0-SNAPSHOT~053a36f28a
dateFormat X
axisFormat %s
section baseline
no_agent (1.37 ms) : 1351, 1388
. : milestone, 1370,
appsec (1.749 ms) : 1725, 1773
. : milestone, 1749,
appsec_no_iast (1.756 ms) : 1733, 1780
. : milestone, 1756,
iast (1.514 ms) : 1490, 1538
. : milestone, 1514,
profiling (1.503 ms) : 1479, 1527
. : milestone, 1503,
tracing (1.505 ms) : 1480, 1529
. : milestone, 1505,
section candidate
no_agent (1.37 ms) : 1350, 1389
. : milestone, 1370,
appsec (1.766 ms) : 1742, 1789
. : milestone, 1766,
appsec_no_iast (1.76 ms) : 1736, 1783
. : milestone, 1760,
iast (1.499 ms) : 1475, 1523
. : milestone, 1499,
profiling (1.529 ms) : 1503, 1554
. : milestone, 1529,
tracing (1.511 ms) : 1486, 1536
. : milestone, 1511,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~7a0b1534d4, baseline=1.47.0-SNAPSHOT~053a36f28a
dateFormat X
axisFormat %s
section baseline
no_agent (377.075 µs) : 357, 397
. : milestone, 377,
iast (512.595 µs) : 491, 534
. : milestone, 513,
iast_FULL (748.529 µs) : 727, 770
. : milestone, 749,
iast_GLOBAL (562.671 µs) : 541, 584
. : milestone, 563,
iast_HARDCODED_SECRET_DISABLED (520.553 µs) : 498, 543
. : milestone, 521,
iast_INACTIVE (474.065 µs) : 452, 496
. : milestone, 474,
iast_TELEMETRY_OFF (500.906 µs) : 478, 524
. : milestone, 501,
tracing (452.983 µs) : 432, 474
. : milestone, 453,
section candidate
no_agent (379.674 µs) : 360, 400
. : milestone, 380,
iast (512.253 µs) : 490, 535
. : milestone, 512,
iast_FULL (754.63 µs) : 732, 777
. : milestone, 755,
iast_GLOBAL (556.804 µs) : 535, 578
. : milestone, 557,
iast_HARDCODED_SECRET_DISABLED (516.465 µs) : 493, 540
. : milestone, 516,
iast_INACTIVE (468.458 µs) : 447, 490
. : milestone, 468,
iast_TELEMETRY_OFF (502.129 µs) : 479, 525
. : milestone, 502,
tracing (457.847 µs) : 437, 479
. : milestone, 458,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~7a0b1534d4, baseline=1.47.0-SNAPSHOT~053a36f28a
dateFormat X
axisFormat %s
section baseline
no_agent (14.849 s) : 14849000, 14849000
. : milestone, 14849000,
appsec (15.224 s) : 15224000, 15224000
. : milestone, 15224000,
iast (18.595 s) : 18595000, 18595000
. : milestone, 18595000,
iast_GLOBAL (17.909 s) : 17909000, 17909000
. : milestone, 17909000,
profiling (15.584 s) : 15584000, 15584000
. : milestone, 15584000,
tracing (15.054 s) : 15054000, 15054000
. : milestone, 15054000,
section candidate
no_agent (14.69 s) : 14690000, 14690000
. : milestone, 14690000,
appsec (15.227 s) : 15227000, 15227000
. : milestone, 15227000,
iast (18.703 s) : 18703000, 18703000
. : milestone, 18703000,
iast_GLOBAL (17.78 s) : 17780000, 17780000
. : milestone, 17780000,
profiling (15.068 s) : 15068000, 15068000
. : milestone, 15068000,
tracing (14.693 s) : 14693000, 14693000
. : milestone, 14693000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.47.0-SNAPSHOT~7a0b1534d4, baseline=1.47.0-SNAPSHOT~053a36f28a
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1461, 1484
. : milestone, 1472,
appsec (2.369 ms) : 2325, 2412
. : milestone, 2369,
iast (2.116 ms) : 2061, 2172
. : milestone, 2116,
iast_GLOBAL (2.158 ms) : 2102, 2213
. : milestone, 2158,
profiling (1.955 ms) : 1912, 1999
. : milestone, 1955,
tracing (1.955 ms) : 1913, 1997
. : milestone, 1955,
section candidate
no_agent (1.474 ms) : 1462, 1485
. : milestone, 1474,
appsec (2.372 ms) : 2329, 2415
. : milestone, 2372,
iast (2.113 ms) : 2058, 2168
. : milestone, 2113,
iast_GLOBAL (2.165 ms) : 2110, 2221
. : milestone, 2165,
profiling (2.266 ms) : 2118, 2414
. : milestone, 2266,
tracing (1.96 ms) : 1918, 2003
. : milestone, 1960,
|
daniel-mohedano
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: ci visibility
Continuous Integration Visibility
tag: no release notes
Changes to exclude from release notes
type: refactoring
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Disables requests to
ci/tests/diffsbackend endpoint, unless they are explicitly enabled with a config property.Motivation
The endpoint is not implemented in the backend yet.
Additional Notes
This is a part of the Impacted Tests Detection feature (#8188) that is currently disabled for everyone by org 2.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: SDTEST-1389