Skip to content

Use proper class def to find interfaces #8476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
evanchooly merged 1 commit into from
Feb 28, 2025
Merged

Use proper class def to find interfaces #8476

evanchooly merged 1 commit into from
Feb 28, 2025

Conversation

@evanchooly
Copy link
Contributor

@evanchooly evanchooly commented Feb 28, 2025

What Does This Do

Corrects the interface lookup.

Motivation

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@evanchooly evanchooly added type: bug Bug report and fix comp: debugger Dynamic Instrumentation inst: java Core Java language instrumentation labels Feb 28, 2025
@evanchooly evanchooly requested a review from jpbempel February 28, 2025 18:28
@evanchooly evanchooly marked this pull request as ready for review February 28, 2025 18:34
@evanchooly evanchooly requested a review from a team as a code owner February 28, 2025 18:34
@evanchooly evanchooly added the tag: no release notes Changes to exclude from release notes label Feb 28, 2025
@pr-commenter
Copy link

pr-commenter bot commented Feb 28, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master evanchooly/grpcCodeOrigin
git_commit_date 1740765357 1740767165
git_commit_sha dceca28 70ece1b
release_version 1.47.0-SNAPSHOT~dceca289e9 1.47.0-SNAPSHOT~70ece1b05b
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1740769909 1740769909
ci_job_id 828350517 828350517
ci_pipeline_id 57384412 57384412
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-vwfacpvz-project-304-concurrent-0-fjw0m84w 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-vwfacpvz-project-304-concurrent-0-fjw0m84w 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 67 metrics, 4 unstable metrics.

Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.47.0-SNAPSHOT~70ece1b05b, baseline=1.47.0-SNAPSHOT~dceca289e9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.131 s) : 0, 1131420
Total [baseline] (11.487 s) : 0, 11487027
Agent [candidate] (1.135 s) : 0, 1134607
Total [candidate] (11.455 s) : 0, 11454746
section appsec
Agent [baseline] (1.266 s) : 0, 1266126
Total [baseline] (11.691 s) : 0, 11690918
Agent [candidate] (1.276 s) : 0, 1276187
Total [candidate] (11.748 s) : 0, 11748467
section iast
Agent [baseline] (1.255 s) : 0, 1254567
Total [baseline] (11.84 s) : 0, 11839679
Agent [candidate] (1.255 s) : 0, 1254502
Total [candidate] (11.876 s) : 0, 11876253
section profiling
Agent [baseline] (1.376 s) : 0, 1375609
Total [baseline] (11.896 s) : 0, 11895681
Agent [candidate] (1.377 s) : 0, 1377450
Total [candidate] (11.892 s) : 0, 11892029
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.131 s -
Agent appsec 1.266 s 134.705 ms (11.9%)
Agent iast 1.255 s 123.146 ms (10.9%)
Agent profiling 1.376 s 244.189 ms (21.6%)
Total tracing 11.487 s -
Total appsec 11.691 s 203.892 ms (1.8%)
Total iast 11.84 s 352.652 ms (3.1%)
Total profiling 11.896 s 408.655 ms (3.6%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.135 s -
Agent appsec 1.276 s 141.58 ms (12.5%)
Agent iast 1.255 s 119.895 ms (10.6%)
Agent profiling 1.377 s 242.844 ms (21.4%)
Total tracing 11.455 s -
Total appsec 11.748 s 293.721 ms (2.6%)
Total iast 11.876 s 421.507 ms (3.7%)
Total profiling 11.892 s 437.283 ms (3.8%) 
gantt
    title petclinic - break down per module: candidate=1.47.0-SNAPSHOT~70ece1b05b, baseline=1.47.0-SNAPSHOT~dceca289e9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (714.748 ms) : 0, 714748
BytebuddyAgent [candidate] (716.141 ms) : 0, 716141
GlobalTracer [baseline] (238.297 ms) : 0, 238297
GlobalTracer [candidate] (239.458 ms) : 0, 239458
AppSec [baseline] (55.38 ms) : 0, 55380
AppSec [candidate] (55.572 ms) : 0, 55572
Debugger [baseline] (95.189 ms) : 0, 95189
Debugger [candidate] (95.375 ms) : 0, 95375
Remote Config [baseline] (594.489 µs) : 0, 594
Remote Config [candidate] (602.265 µs) : 0, 602
Telemetry [baseline] (12.309 ms) : 0, 12309
Telemetry [candidate] (12.435 ms) : 0, 12435
section appsec
BytebuddyAgent [baseline] (731.817 ms) : 0, 731817
BytebuddyAgent [candidate] (738.352 ms) : 0, 738352
GlobalTracer [baseline] (234.811 ms) : 0, 234811
GlobalTracer [candidate] (236.508 ms) : 0, 236508
AppSec [baseline] (176.936 ms) : 0, 176936
AppSec [candidate] (177.987 ms) : 0, 177987
Debugger [baseline] (83.905 ms) : 0, 83905
Debugger [candidate] (84.486 ms) : 0, 84486
Remote Config [baseline] (629.932 µs) : 0, 630
Remote Config [candidate] (633.061 µs) : 0, 633
Telemetry [baseline] (12.35 ms) : 0, 12350
Telemetry [candidate] (12.406 ms) : 0, 12406
IAST [baseline] (21.475 ms) : 0, 21475
IAST [candidate] (21.54 ms) : 0, 21540
section iast
BytebuddyAgent [baseline] (834.1 ms) : 0, 834100
BytebuddyAgent [candidate] (834.368 ms) : 0, 834368
GlobalTracer [baseline] (229.3 ms) : 0, 229300
GlobalTracer [candidate] (229.307 ms) : 0, 229307
AppSec [baseline] (57.445 ms) : 0, 57445
AppSec [candidate] (57.135 ms) : 0, 57135
Debugger [baseline] (83.314 ms) : 0, 83314
Debugger [candidate] (83.329 ms) : 0, 83329
Remote Config [baseline] (516.673 µs) : 0, 517
Remote Config [candidate] (518.624 µs) : 0, 519
Telemetry [baseline] (12.215 ms) : 0, 12215
Telemetry [candidate] (12.149 ms) : 0, 12149
IAST [baseline] (22.733 ms) : 0, 22733
IAST [candidate] (22.707 ms) : 0, 22707
section profiling
ProfilingAgent [baseline] (123.376 ms) : 0, 123376
ProfilingAgent [candidate] (123.567 ms) : 0, 123567
BytebuddyAgent [baseline] (706.621 ms) : 0, 706621
BytebuddyAgent [candidate] (707.802 ms) : 0, 707802
GlobalTracer [baseline] (348.415 ms) : 0, 348415
GlobalTracer [candidate] (349.637 ms) : 0, 349637
AppSec [baseline] (55.38 ms) : 0, 55380
AppSec [candidate] (54.492 ms) : 0, 54492
Debugger [baseline] (88.391 ms) : 0, 88391
Debugger [candidate] (88.439 ms) : 0, 88439
Remote Config [baseline] (622.156 µs) : 0, 622
Remote Config [candidate] (614.744 µs) : 0, 615
Telemetry [baseline] (12.572 ms) : 0, 12572
Telemetry [candidate] (12.622 ms) : 0, 12622
Profiling [baseline] (123.398 ms) : 0, 123398
Profiling [candidate] (123.588 ms) : 0, 123588
Loading
Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.47.0-SNAPSHOT~70ece1b05b, baseline=1.47.0-SNAPSHOT~dceca289e9

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.133 s) : 0, 1133479
Total [baseline] (9.263 s) : 0, 9262619
Agent [candidate] (1.137 s) : 0, 1136835
Total [candidate] (9.341 s) : 0, 9341324
section iast
Agent [baseline] (1.256 s) : 0, 1256133
Total [baseline] (9.845 s) : 0, 9845063
Agent [candidate] (1.256 s) : 0, 1255674
Total [candidate] (9.88 s) : 0, 9879630
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.254 s) : 0, 1253830
Total [baseline] (9.838 s) : 0, 9838063
Agent [candidate] (1.265 s) : 0, 1264640
Total [candidate] (9.856 s) : 0, 9856073
section iast_TELEMETRY_OFF
Agent [baseline] (1.25 s) : 0, 1250323
Total [baseline] (9.881 s) : 0, 9881232
Agent [candidate] (1.25 s) : 0, 1249642
Total [candidate] (9.912 s) : 0, 9911723
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.133 s -
Agent iast 1.256 s 122.654 ms (10.8%)
Agent iast_HARDCODED_SECRET_DISABLED 1.254 s 120.351 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.25 s 116.844 ms (10.3%)
Total tracing 9.263 s -
Total iast 9.845 s 582.444 ms (6.3%)
Total iast_HARDCODED_SECRET_DISABLED 9.838 s 575.444 ms (6.2%)
Total iast_TELEMETRY_OFF 9.881 s 618.613 ms (6.7%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.137 s -
Agent iast 1.256 s 118.839 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.265 s 127.805 ms (11.2%)
Agent iast_TELEMETRY_OFF 1.25 s 112.808 ms (9.9%)
Total tracing 9.341 s -
Total iast 9.88 s 538.306 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 9.856 s 514.749 ms (5.5%)
Total iast_TELEMETRY_OFF 9.912 s 570.399 ms (6.1%) 
gantt
    title insecure-bank - break down per module: candidate=1.47.0-SNAPSHOT~70ece1b05b, baseline=1.47.0-SNAPSHOT~dceca289e9

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.212 ms) : 0, 716212
BytebuddyAgent [candidate] (717.153 ms) : 0, 717153
GlobalTracer [baseline] (238.589 ms) : 0, 238589
GlobalTracer [candidate] (239.804 ms) : 0, 239804
AppSec [baseline] (54.946 ms) : 0, 54946
AppSec [candidate] (55.912 ms) : 0, 55912
Debugger [baseline] (95.81 ms) : 0, 95810
Debugger [candidate] (95.84 ms) : 0, 95840
Remote Config [baseline] (601.72 µs) : 0, 602
Remote Config [candidate] (594.948 µs) : 0, 595
Telemetry [baseline] (12.373 ms) : 0, 12373
Telemetry [candidate] (12.555 ms) : 0, 12555
section iast
BytebuddyAgent [baseline] (835.227 ms) : 0, 835227
BytebuddyAgent [candidate] (833.754 ms) : 0, 833754
GlobalTracer [baseline] (229.59 ms) : 0, 229590
GlobalTracer [candidate] (229.103 ms) : 0, 229103
IAST [baseline] (22.693 ms) : 0, 22693
IAST [candidate] (22.855 ms) : 0, 22855
AppSec [baseline] (57.198 ms) : 0, 57198
AppSec [candidate] (57.336 ms) : 0, 57336
Debugger [baseline] (83.853 ms) : 0, 83853
Debugger [candidate] (84.733 ms) : 0, 84733
Remote Config [baseline] (530.912 µs) : 0, 531
Remote Config [candidate] (528.384 µs) : 0, 528
Telemetry [baseline] (12.069 ms) : 0, 12069
Telemetry [candidate] (12.356 ms) : 0, 12356
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (832.916 ms) : 0, 832916
BytebuddyAgent [candidate] (841.337 ms) : 0, 841337
GlobalTracer [baseline] (229.534 ms) : 0, 229534
GlobalTracer [candidate] (230.793 ms) : 0, 230793
IAST [baseline] (22.699 ms) : 0, 22699
IAST [candidate] (22.99 ms) : 0, 22990
AppSec [baseline] (57.009 ms) : 0, 57009
AppSec [candidate] (57.4 ms) : 0, 57400
Debugger [baseline] (84.116 ms) : 0, 84116
Debugger [candidate] (84.08 ms) : 0, 84080
Remote Config [baseline] (516.516 µs) : 0, 517
Remote Config [candidate] (550.697 µs) : 0, 551
Telemetry [baseline] (12.096 ms) : 0, 12096
Telemetry [candidate] (12.287 ms) : 0, 12287
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (831.674 ms) : 0, 831674
BytebuddyAgent [candidate] (830.585 ms) : 0, 830585
GlobalTracer [baseline] (228.41 ms) : 0, 228410
GlobalTracer [candidate] (229.405 ms) : 0, 229405
IAST [baseline] (23.794 ms) : 0, 23794
IAST [candidate] (22.934 ms) : 0, 22934
AppSec [baseline] (55.472 ms) : 0, 55472
AppSec [candidate] (56.082 ms) : 0, 56082
Debugger [baseline] (83.531 ms) : 0, 83531
Debugger [candidate] (83.148 ms) : 0, 83148
Remote Config [baseline] (512.802 µs) : 0, 513
Remote Config [candidate] (531.539 µs) : 0, 532
Telemetry [baseline] (11.996 ms) : 0, 11996
Telemetry [candidate] (12.064 ms) : 0, 12064
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2025-02-28T18:37:34 2025-02-28T18:45:26
git_branch master evanchooly/grpcCodeOrigin
git_commit_date 1740765357 1740767165
git_commit_sha dceca28 70ece1b
release_version 1.47.0-SNAPSHOT~dceca289e9 1.47.0-SNAPSHOT~70ece1b05b
start_time 2025-02-28T18:37:20 2025-02-28T18:45:12
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1740768731 1740768731
ci_job_id 828350518 828350518
ci_pipeline_id 57384412 57384412
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zrt-bbxu-project-304-concurrent-1-b1y851mx 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zrt-bbxu-project-304-concurrent-1-b1y851mx 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~70ece1b05b, baseline=1.47.0-SNAPSHOT~dceca289e9
    dateFormat X
    axisFormat %s
section baseline
no_agent (372.258 µs) : 352, 392
.   : milestone, 372,
iast (508.316 µs) : 486, 530
.   : milestone, 508,
iast_FULL (731.215 µs) : 709, 753
.   : milestone, 731,
iast_GLOBAL (553.249 µs) : 531, 575
.   : milestone, 553,
iast_HARDCODED_SECRET_DISABLED (505.585 µs) : 484, 528
.   : milestone, 506,
iast_INACTIVE (459.004 µs) : 438, 480
.   : milestone, 459,
iast_TELEMETRY_OFF (499.143 µs) : 475, 523
.   : milestone, 499,
tracing (449.309 µs) : 428, 470
.   : milestone, 449,
section candidate
no_agent (377.49 µs) : 358, 397
.   : milestone, 377,
iast (506.8 µs) : 485, 529
.   : milestone, 507,
iast_FULL (722.766 µs) : 701, 745
.   : milestone, 723,
iast_GLOBAL (564.184 µs) : 540, 588
.   : milestone, 564,
iast_HARDCODED_SECRET_DISABLED (506.983 µs) : 485, 529
.   : milestone, 507,
iast_INACTIVE (454.731 µs) : 434, 476
.   : milestone, 455,
iast_TELEMETRY_OFF (492.182 µs) : 470, 514
.   : milestone, 492,
tracing (446.578 µs) : 426, 467
.   : milestone, 447,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 372.258 µs [352.355 µs, 392.16 µs] -
iast 508.316 µs [486.275 µs, 530.357 µs] 136.058 µs (36.5%)
iast_FULL 731.215 µs [709.21 µs, 753.22 µs] 358.957 µs (96.4%)
iast_GLOBAL 553.249 µs [531.223 µs, 575.275 µs] 180.991 µs (48.6%)
iast_HARDCODED_SECRET_DISABLED 505.585 µs [483.627 µs, 527.543 µs] 133.327 µs (35.8%)
iast_INACTIVE 459.004 µs [437.536 µs, 480.472 µs] 86.746 µs (23.3%)
iast_TELEMETRY_OFF 499.143 µs [475.482 µs, 522.803 µs] 126.885 µs (34.1%)
tracing 449.309 µs [428.333 µs, 470.285 µs] 77.051 µs (20.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 377.49 µs [358.027 µs, 396.954 µs] -
iast 506.8 µs [484.993 µs, 528.608 µs] 129.31 µs (34.3%)
iast_FULL 722.766 µs [700.701 µs, 744.831 µs] 345.275 µs (91.5%)
iast_GLOBAL 564.184 µs [540.4 µs, 587.968 µs] 186.694 µs (49.5%)
iast_HARDCODED_SECRET_DISABLED 506.983 µs [485.013 µs, 528.953 µs] 129.493 µs (34.3%)
iast_INACTIVE 454.731 µs [433.544 µs, 475.918 µs] 77.24 µs (20.5%)
iast_TELEMETRY_OFF 492.182 µs [470.405 µs, 513.958 µs] 114.691 µs (30.4%)
tracing 446.578 µs [425.737 µs, 467.42 µs] 69.088 µs (18.3%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.47.0-SNAPSHOT~70ece1b05b, baseline=1.47.0-SNAPSHOT~dceca289e9
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.365 ms) : 1346, 1385
.   : milestone, 1365,
appsec (1.723 ms) : 1699, 1747
.   : milestone, 1723,
appsec_no_iast (1.717 ms) : 1693, 1741
.   : milestone, 1717,
code_origins (1.678 ms) : 1646, 1711
.   : milestone, 1678,
iast (1.52 ms) : 1495, 1544
.   : milestone, 1520,
profiling (1.498 ms) : 1475, 1522
.   : milestone, 1498,
tracing (1.484 ms) : 1460, 1508
.   : milestone, 1484,
section candidate
no_agent (1.343 ms) : 1324, 1363
.   : milestone, 1343,
appsec (1.733 ms) : 1709, 1757
.   : milestone, 1733,
appsec_no_iast (1.72 ms) : 1697, 1743
.   : milestone, 1720,
code_origins (1.695 ms) : 1662, 1728
.   : milestone, 1695,
iast (1.503 ms) : 1478, 1528
.   : milestone, 1503,
profiling (1.547 ms) : 1522, 1572
.   : milestone, 1547,
tracing (1.483 ms) : 1459, 1506
.   : milestone, 1483,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.365 ms [1.346 ms, 1.385 ms] -
appsec 1.723 ms [1.699 ms, 1.747 ms] 357.831 µs (26.2%)
appsec_no_iast 1.717 ms [1.693 ms, 1.741 ms] 351.684 µs (25.8%)
code_origins 1.678 ms [1.646 ms, 1.711 ms] 313.162 µs (22.9%)
iast 1.52 ms [1.495 ms, 1.544 ms] 154.322 µs (11.3%)
profiling 1.498 ms [1.475 ms, 1.522 ms] 133.099 µs (9.7%)
tracing 1.484 ms [1.46 ms, 1.508 ms] 119.174 µs (8.7%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.324 ms, 1.363 ms] -
appsec 1.733 ms [1.709 ms, 1.757 ms] 389.821 µs (29.0%)
appsec_no_iast 1.72 ms [1.697 ms, 1.743 ms] 376.507 µs (28.0%)
code_origins 1.695 ms [1.662 ms, 1.728 ms] 351.388 µs (26.2%)
iast 1.503 ms [1.478 ms, 1.528 ms] 159.403 µs (11.9%)
profiling 1.547 ms [1.522 ms, 1.572 ms] 203.933 µs (15.2%)
tracing 1.483 ms [1.459 ms, 1.506 ms] 139.329 µs (10.4%)

Dacapo

@evanchooly evanchooly merged commit c8886fb into master Feb 28, 2025
214 of 219 checks passed
@evanchooly evanchooly deleted the evanchooly/grpcCodeOrigin branch February 28, 2025 19:14
@github-actions github-actions bot added this to the 1.47.0 milestone Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jpbempel jpbempel jpbempel approved these changes

@shatzi shatzi shatzi approved these changes

Assignees

No one assigned

Labels

comp: debugger Dynamic Instrumentation inst: java Core Java language instrumentation tag: no release notes Changes to exclude from release notes type: bug Bug report and fix

Projects

None yet

Milestone

1.47.0

Development

Successfully merging this pull request may close these issues.

4 participants

@evanchooly @jpbempel @shatzi