-
Notifications
You must be signed in to change notification settings - Fork 324
Ensure all response body advices are OnMethodEnter #9046
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
manuel-alvarez-alvarez
merged 1 commit into
master
from
malvarez/change-response-body-to-after
Jul 4, 2025
Merged
Ensure all response body advices are OnMethodEnter #9046
manuel-alvarez-alvarez
merged 1 commit into
master
from
malvarez/change-response-body-to-after
Jul 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jandro996
approved these changes
Jun 27, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 43 metrics, 10 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~e3b7409f10, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1004432
Total [baseline] (10.647 s) : 0, 10647062
Agent [candidate] (1.001 s) : 0, 1000692
Total [candidate] (10.774 s) : 0, 10773638
section appsec
Agent [baseline] (1.176 s) : 0, 1175913
Total [baseline] (10.723 s) : 0, 10722933
Agent [candidate] (1.178 s) : 0, 1178324
Total [candidate] (10.77 s) : 0, 10769533
section iast
Agent [baseline] (1.142 s) : 0, 1142110
Total [baseline] (10.823 s) : 0, 10823321
Agent [candidate] (1.136 s) : 0, 1135619
Total [candidate] (10.837 s) : 0, 10836642
section profiling
Agent [baseline] (1.271 s) : 0, 1270598
Total [baseline] (11.093 s) : 0, 11092957
Agent [candidate] (1.246 s) : 0, 1245621
Total [candidate] (11.01 s) : 0, 11009602
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~e3b7409f10, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.821 ms) : 0, 693821
BytebuddyAgent [candidate] (690.588 ms) : 0, 690588
GlobalTracer [baseline] (243.932 ms) : 0, 243932
GlobalTracer [candidate] (243.158 ms) : 0, 243158
AppSec [baseline] (30.695 ms) : 0, 30695
AppSec [candidate] (30.447 ms) : 0, 30447
Debugger [baseline] (6.104 ms) : 0, 6104
Debugger [candidate] (6.071 ms) : 0, 6071
Remote Config [baseline] (683.23 µs) : 0, 683
Remote Config [candidate] (670.738 µs) : 0, 671
Telemetry [baseline] (8.25 ms) : 0, 8250
Telemetry [candidate] (8.971 ms) : 0, 8971
section appsec
BytebuddyAgent [baseline] (711.338 ms) : 0, 711338
BytebuddyAgent [candidate] (712.974 ms) : 0, 712974
GlobalTracer [baseline] (235.797 ms) : 0, 235797
GlobalTracer [candidate] (236.457 ms) : 0, 236457
AppSec [baseline] (171.277 ms) : 0, 171277
AppSec [candidate] (171.247 ms) : 0, 171247
Debugger [baseline] (5.835 ms) : 0, 5835
Debugger [candidate] (5.812 ms) : 0, 5812
Remote Config [baseline] (610.856 µs) : 0, 611
Remote Config [candidate] (612.963 µs) : 0, 613
Telemetry [baseline] (8.14 ms) : 0, 8140
Telemetry [candidate] (8.161 ms) : 0, 8161
IAST [baseline] (22.128 ms) : 0, 22128
IAST [candidate] (22.195 ms) : 0, 22195
section iast
BytebuddyAgent [baseline] (815.685 ms) : 0, 815685
BytebuddyAgent [candidate] (810.918 ms) : 0, 810918
GlobalTracer [baseline] (234.882 ms) : 0, 234882
GlobalTracer [candidate] (233.704 ms) : 0, 233704
AppSec [baseline] (29.714 ms) : 0, 29714
AppSec [candidate] (29.425 ms) : 0, 29425
Debugger [baseline] (5.867 ms) : 0, 5867
Debugger [candidate] (6.684 ms) : 0, 6684
Remote Config [baseline] (601.984 µs) : 0, 602
Remote Config [candidate] (581.086 µs) : 0, 581
Telemetry [baseline] (8.062 ms) : 0, 8062
Telemetry [candidate] (7.953 ms) : 0, 7953
IAST [baseline] (26.354 ms) : 0, 26354
IAST [candidate] (25.447 ms) : 0, 25447
section profiling
BytebuddyAgent [baseline] (692.793 ms) : 0, 692793
BytebuddyAgent [candidate] (678.961 ms) : 0, 678961
GlobalTracer [baseline] (367.706 ms) : 0, 367706
GlobalTracer [candidate] (361.507 ms) : 0, 361507
AppSec [baseline] (32.348 ms) : 0, 32348
AppSec [candidate] (32.184 ms) : 0, 32184
Debugger [baseline] (11.347 ms) : 0, 11347
Debugger [candidate] (12.18 ms) : 0, 12180
Remote Config [baseline] (685.449 µs) : 0, 685
Remote Config [candidate] (674.861 µs) : 0, 675
Telemetry [baseline] (9.65 ms) : 0, 9650
Telemetry [candidate] (8.03 ms) : 0, 8030
ProfilingAgent [baseline] (106.494 ms) : 0, 106494
ProfilingAgent [candidate] (103.424 ms) : 0, 103424
Profiling [baseline] (106.518 ms) : 0, 106518
Profiling [candidate] (103.449 ms) : 0, 103449
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~e3b7409f10, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.004 s) : 0, 1003700
Total [baseline] (8.576 s) : 0, 8575944
Agent [candidate] (996.962 ms) : 0, 996962
Total [candidate] (8.558 s) : 0, 8557639
section iast
Agent [baseline] (1.139 s) : 0, 1139386
Total [baseline] (9.324 s) : 0, 9323873
Agent [candidate] (1.133 s) : 0, 1133320
Total [candidate] (9.268 s) : 0, 9268205
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~e3b7409f10, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (693.547 ms) : 0, 693547
BytebuddyAgent [candidate] (688.286 ms) : 0, 688286
GlobalTracer [baseline] (243.583 ms) : 0, 243583
GlobalTracer [candidate] (242.557 ms) : 0, 242557
AppSec [baseline] (30.59 ms) : 0, 30590
AppSec [candidate] (30.477 ms) : 0, 30477
Debugger [baseline] (6.09 ms) : 0, 6090
Debugger [candidate] (6.053 ms) : 0, 6053
Remote Config [baseline] (688.997 µs) : 0, 689
Remote Config [candidate] (680.865 µs) : 0, 681
Telemetry [baseline] (8.257 ms) : 0, 8257
Telemetry [candidate] (8.214 ms) : 0, 8214
section iast
BytebuddyAgent [baseline] (813.793 ms) : 0, 813793
BytebuddyAgent [candidate] (809.178 ms) : 0, 809178
GlobalTracer [baseline] (234.042 ms) : 0, 234042
GlobalTracer [candidate] (233.634 ms) : 0, 233634
AppSec [baseline] (27.169 ms) : 0, 27169
AppSec [candidate] (26.75 ms) : 0, 26750
Debugger [baseline] (5.888 ms) : 0, 5888
Debugger [candidate] (5.829 ms) : 0, 5829
Remote Config [baseline] (588.262 µs) : 0, 588
Remote Config [candidate] (579.521 µs) : 0, 580
Telemetry [baseline] (8.118 ms) : 0, 8118
Telemetry [candidate] (7.929 ms) : 0, 7929
IAST [baseline] (28.994 ms) : 0, 28994
IAST [candidate] (28.623 ms) : 0, 28623
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 3 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~e3b7409f10, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section baseline
no_agent (36.51 ms) : 36214, 36806
. : milestone, 36510,
appsec (46.992 ms) : 46576, 47408
. : milestone, 46992,
code_origins (45.571 ms) : 45180, 45963
. : milestone, 45571,
iast (44.137 ms) : 43749, 44525
. : milestone, 44137,
profiling (46.803 ms) : 46375, 47231
. : milestone, 46803,
tracing (44.355 ms) : 43974, 44736
. : milestone, 44355,
section candidate
no_agent (37.434 ms) : 37129, 37739
. : milestone, 37434,
appsec (49.576 ms) : 49129, 50023
. : milestone, 49576,
code_origins (44.402 ms) : 44021, 44784
. : milestone, 44402,
iast (43.953 ms) : 43559, 44348
. : milestone, 43953,
profiling (48.022 ms) : 47590, 48454
. : milestone, 48022,
tracing (44.1 ms) : 43722, 44478
. : milestone, 44100,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~e3b7409f10, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section baseline
no_agent (4.344 ms) : 4291, 4397
. : milestone, 4344,
iast (8.862 ms) : 8709, 9015
. : milestone, 8862,
iast_FULL (13.718 ms) : 13442, 13995
. : milestone, 13718,
iast_GLOBAL (10.139 ms) : 9961, 10317
. : milestone, 10139,
profiling (8.495 ms) : 8355, 8634
. : milestone, 8495,
tracing (7.703 ms) : 7594, 7812
. : milestone, 7703,
section candidate
no_agent (4.554 ms) : 4503, 4605
. : milestone, 4554,
iast (9.051 ms) : 8893, 9209
. : milestone, 9051,
iast_FULL (13.569 ms) : 13303, 13835
. : milestone, 13569,
iast_GLOBAL (10.324 ms) : 10142, 10507
. : milestone, 10324,
profiling (9.142 ms) : 8989, 9294
. : milestone, 9142,
tracing (7.452 ms) : 7348, 7555
. : milestone, 7452,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~e3b7409f10, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section baseline
no_agent (1.471 ms) : 1460, 1483
. : milestone, 1471,
appsec (2.397 ms) : 2348, 2447
. : milestone, 2397,
iast (2.185 ms) : 2123, 2248
. : milestone, 2185,
iast_GLOBAL (2.219 ms) : 2157, 2282
. : milestone, 2219,
profiling (2.045 ms) : 1994, 2096
. : milestone, 2045,
tracing (2.002 ms) : 1954, 2050
. : milestone, 2002,
section candidate
no_agent (1.467 ms) : 1456, 1479
. : milestone, 1467,
appsec (2.4 ms) : 2351, 2449
. : milestone, 2400,
iast (2.18 ms) : 2118, 2242
. : milestone, 2180,
iast_GLOBAL (2.219 ms) : 2157, 2281
. : milestone, 2219,
profiling (2.029 ms) : 1980, 2079
. : milestone, 2029,
tracing (2.015 ms) : 1967, 2064
. : milestone, 2015,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~e3b7409f10, baseline=1.51.0-SNAPSHOT~1666056a38
dateFormat X
axisFormat %s
section baseline
no_agent (14.889 s) : 14889000, 14889000
. : milestone, 14889000,
appsec (14.89 s) : 14890000, 14890000
. : milestone, 14890000,
iast (18.289 s) : 18289000, 18289000
. : milestone, 18289000,
iast_GLOBAL (17.853 s) : 17853000, 17853000
. : milestone, 17853000,
profiling (15.293 s) : 15293000, 15293000
. : milestone, 15293000,
tracing (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
section candidate
no_agent (15.111 s) : 15111000, 15111000
. : milestone, 15111000,
appsec (15.036 s) : 15036000, 15036000
. : milestone, 15036000,
iast (18.396 s) : 18396000, 18396000
. : milestone, 18396000,
iast_GLOBAL (17.822 s) : 17822000, 17822000
. : milestone, 17822000,
profiling (15.192 s) : 15192000, 15192000
. : milestone, 15192000,
tracing (14.838 s) : 14838000, 14838000
. : milestone, 14838000,
|
06c70e1 to
b175b49
Compare
b175b49 to
e3b7409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp: asm waf
Application Security Management (WAF)
tag: no release notes
Changes to exclude from release notes
type: enhancement
Enhancements and improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This Do
Ensures that all advices dealing with the response body object are declared as
OnMethodEnter.Motivation
In case there is a block of the response, it is important to block it before the actual response is committed.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]