Skip to content

Conversation

@bric3
Copy link
Contributor

@bric3 bric3 commented Jul 2, 2025

What Does This Do

Update "circleci" phrasing to "gitlab"

Motivation

We have migrated off of CircleCI, onto GitLab 🎉

Additional Notes

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@bric3 bric3 requested review from a team as code owners July 2, 2025 15:46
@bric3 bric3 requested review from TonyCTHsu, mcculls and sarahchen6 and removed request for a team July 2, 2025 15:46
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

  • Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

@bric3 bric3 requested a review from randomanderson July 2, 2025 16:07
@bric3 bric3 added tag: no release notes Changes to exclude from release notes comp: tooling Build & Tooling labels Jul 2, 2025
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up!


> [!NOTE]
> The system tests version used for continous integration is defined using `default_system_tests_commit` in [CircleCI configuration](../.circleci/config.continue.yml.j2).
In the CI System tests will be run with the pipeline defined [`DataDog/system-tests/blob/main/.github/workflows/system-tests.yml`](https://github.com/DataDog/system-tests/blob/main/.github/workflows/system-tests.yml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TonyCTHsu is working on this part this quarter :)

@PerfectSlayer PerfectSlayer force-pushed the bdu/circle-ci-migration-leftovers branch from 5586117 to 56c4ff3 Compare July 3, 2025 05:24
@pr-commenter
Copy link

pr-commenter bot commented Jul 3, 2025

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/circle-ci-migration-leftovers
git_commit_date 1751873095 1751887288
git_commit_sha bbdc0b7 bb77a1e
release_version 1.51.0-SNAPSHOT~bbdc0b7f15 1.51.0-SNAPSHOT~bb77a1e343
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1751889160 1751889160
ci_job_id 1015679828 1015679828
ci_pipeline_id 69759071 69759071
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-2-tmo4vojv 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-2-tmo4vojv 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module Agent Agent
parent None None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 46 metrics, 7 unstable metrics.

Startup time reports for petclinic
gantt
    title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~bb77a1e343, baseline=1.51.0-SNAPSHOT~bbdc0b7f15

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1000889
Total [baseline] (10.568 s) : 0, 10567743
Agent [candidate] (1.008 s) : 0, 1008250
Total [candidate] (10.688 s) : 0, 10687636
section appsec
Agent [baseline] (1.18 s) : 0, 1179827
Total [baseline] (10.833 s) : 0, 10833083
Agent [candidate] (1.173 s) : 0, 1172999
Total [candidate] (10.704 s) : 0, 10704327
section iast
Agent [baseline] (1.15 s) : 0, 1150273
Total [baseline] (10.858 s) : 0, 10857668
Agent [candidate] (1.142 s) : 0, 1141679
Total [candidate] (10.883 s) : 0, 10882962
section profiling
Agent [baseline] (1.251 s) : 0, 1251073
Total [baseline] (11.0 s) : 0, 11000021
Agent [candidate] (1.243 s) : 0, 1243139
Total [candidate] (10.913 s) : 0, 10912540
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.001 s -
Agent appsec 1.18 s 178.938 ms (17.9%)
Agent iast 1.15 s 149.384 ms (14.9%)
Agent profiling 1.251 s 250.184 ms (25.0%)
Total tracing 10.568 s -
Total appsec 10.833 s 265.34 ms (2.5%)
Total iast 10.858 s 289.925 ms (2.7%)
Total profiling 11.0 s 432.278 ms (4.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.008 s -
Agent appsec 1.173 s 164.749 ms (16.3%)
Agent iast 1.142 s 133.429 ms (13.2%)
Agent profiling 1.243 s 234.889 ms (23.3%)
Total tracing 10.688 s -
Total appsec 10.704 s 16.692 ms (0.2%)
Total iast 10.883 s 195.326 ms (1.8%)
Total profiling 10.913 s 224.904 ms (2.1%)
gantt
    title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~bb77a1e343, baseline=1.51.0-SNAPSHOT~bbdc0b7f15

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (691.093 ms) : 0, 691093
BytebuddyAgent [candidate] (696.966 ms) : 0, 696966
GlobalTracer [baseline] (243.52 ms) : 0, 243520
GlobalTracer [candidate] (244.384 ms) : 0, 244384
AppSec [baseline] (30.431 ms) : 0, 30431
AppSec [candidate] (30.784 ms) : 0, 30784
Debugger [baseline] (6.066 ms) : 0, 6066
Debugger [candidate] (6.12 ms) : 0, 6120
Remote Config [baseline] (677.072 µs) : 0, 677
Remote Config [candidate] (680.478 µs) : 0, 680
Telemetry [baseline] (8.242 ms) : 0, 8242
Telemetry [candidate] (8.32 ms) : 0, 8320
section appsec
BytebuddyAgent [baseline] (714.203 ms) : 0, 714203
BytebuddyAgent [candidate] (709.222 ms) : 0, 709222
GlobalTracer [baseline] (236.237 ms) : 0, 236237
GlobalTracer [candidate] (234.474 ms) : 0, 234474
IAST [baseline] (23.268 ms) : 0, 23268
IAST [candidate] (23.017 ms) : 0, 23017
AppSec [baseline] (170.77 ms) : 0, 170770
AppSec [candidate] (171.089 ms) : 0, 171089
Debugger [baseline] (5.749 ms) : 0, 5749
Debugger [candidate] (5.752 ms) : 0, 5752
Remote Config [baseline] (606.641 µs) : 0, 607
Remote Config [candidate] (600.962 µs) : 0, 601
Telemetry [baseline] (8.095 ms) : 0, 8095
Telemetry [candidate] (8.082 ms) : 0, 8082
section iast
BytebuddyAgent [baseline] (820.681 ms) : 0, 820681
BytebuddyAgent [candidate] (814.557 ms) : 0, 814557
GlobalTracer [baseline] (235.785 ms) : 0, 235785
GlobalTracer [candidate] (234.46 ms) : 0, 234460
IAST [baseline] (29.08 ms) : 0, 29080
IAST [candidate] (29.3 ms) : 0, 29300
AppSec [baseline] (29.134 ms) : 0, 29134
AppSec [candidate] (27.894 ms) : 0, 27894
Debugger [baseline] (5.884 ms) : 0, 5884
Debugger [candidate] (5.868 ms) : 0, 5868
Remote Config [baseline] (601.885 µs) : 0, 602
Remote Config [candidate] (589.533 µs) : 0, 590
Telemetry [baseline] (8.054 ms) : 0, 8054
Telemetry [candidate] (8.133 ms) : 0, 8133
section profiling
BytebuddyAgent [baseline] (682.058 ms) : 0, 682058
BytebuddyAgent [candidate] (677.655 ms) : 0, 677655
GlobalTracer [baseline] (362.82 ms) : 0, 362820
GlobalTracer [candidate] (360.759 ms) : 0, 360759
AppSec [baseline] (33.856 ms) : 0, 33856
AppSec [candidate] (31.738 ms) : 0, 31738
Debugger [baseline] (9.979 ms) : 0, 9979
Debugger [candidate] (10.717 ms) : 0, 10717
Remote Config [baseline] (668.189 µs) : 0, 668
Remote Config [candidate] (657.161 µs) : 0, 657
Telemetry [baseline] (8.044 ms) : 0, 8044
Telemetry [candidate] (8.726 ms) : 0, 8726
ProfilingAgent [baseline] (104.866 ms) : 0, 104866
ProfilingAgent [candidate] (102.823 ms) : 0, 102823
Profiling [baseline] (104.891 ms) : 0, 104891
Profiling [candidate] (102.847 ms) : 0, 102847
Loading
Startup time reports for insecure-bank
gantt
    title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~bb77a1e343, baseline=1.51.0-SNAPSHOT~bbdc0b7f15

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (994.795 ms) : 0, 994795
Total [baseline] (8.558 s) : 0, 8558242
Agent [candidate] (1.003 s) : 0, 1002615
Total [candidate] (8.543 s) : 0, 8542716
section iast
Agent [baseline] (1.132 s) : 0, 1131959
Total [baseline] (9.204 s) : 0, 9204249
Agent [candidate] (1.135 s) : 0, 1134869
Total [candidate] (9.328 s) : 0, 9327785
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 994.795 ms -
Agent iast 1.132 s 137.165 ms (13.8%)
Total tracing 8.558 s -
Total iast 9.204 s 646.007 ms (7.5%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.003 s -
Agent iast 1.135 s 132.254 ms (13.2%)
Total tracing 8.543 s -
Total iast 9.328 s 785.069 ms (9.2%)
gantt
    title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~bb77a1e343, baseline=1.51.0-SNAPSHOT~bbdc0b7f15

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.423 ms) : 0, 687423
BytebuddyAgent [candidate] (692.449 ms) : 0, 692449
GlobalTracer [baseline] (241.344 ms) : 0, 241344
GlobalTracer [candidate] (243.372 ms) : 0, 243372
AppSec [baseline] (30.341 ms) : 0, 30341
AppSec [candidate] (30.716 ms) : 0, 30716
Debugger [baseline] (6.026 ms) : 0, 6026
Debugger [candidate] (6.152 ms) : 0, 6152
Remote Config [baseline] (685.268 µs) : 0, 685
Remote Config [candidate] (693.776 µs) : 0, 694
Telemetry [baseline] (8.221 ms) : 0, 8221
Telemetry [candidate] (8.339 ms) : 0, 8339
section iast
BytebuddyAgent [baseline] (806.911 ms) : 0, 806911
BytebuddyAgent [candidate] (807.895 ms) : 0, 807895
GlobalTracer [baseline] (232.641 ms) : 0, 232641
GlobalTracer [candidate] (234.164 ms) : 0, 234164
IAST [baseline] (27.85 ms) : 0, 27850
IAST [candidate] (30.439 ms) : 0, 30439
AppSec [baseline] (29.412 ms) : 0, 29412
AppSec [candidate] (27.184 ms) : 0, 27184
Debugger [baseline] (5.838 ms) : 0, 5838
Debugger [candidate] (5.875 ms) : 0, 5875
Remote Config [baseline] (586.669 µs) : 0, 587
Remote Config [candidate] (584.112 µs) : 0, 584
Telemetry [baseline] (8.002 ms) : 0, 8002
Telemetry [candidate] (8.02 ms) : 0, 8020
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/circle-ci-migration-leftovers
git_commit_date 1751873095 1751887288
git_commit_sha bbdc0b7 bb77a1e
release_version 1.51.0-SNAPSHOT~bbdc0b7f15 1.51.0-SNAPSHOT~bb77a1e343
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1751888843 1751888843
ci_job_id 1015679829 1015679829
ci_pipeline_id 69759071 69759071
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-3-4i0l94v7 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-3-4i0l94v7 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 1 performance regressions! Performance is the same for 10 metrics, 12 unstable metrics.

scenario Δ mean http_req_duration Δ mean throughput candidate mean http_req_duration candidate mean throughput baseline mean http_req_duration baseline mean throughput
scenario:load:insecure-bank:tracing:high_load worse
[+185.263µs; +413.858µs] or [+2.490%; +5.563%]
unstable
[-99.512op/s; +51.887op/s] or [-15.993%; +8.339%]
7.739ms 598.406op/s 7.440ms 622.219op/s
scenario:load:petclinic:no_agent:high_load better
[-3.006ms; -2.365ms] or [-7.851%; -6.177%]
unstable
[+0.419op/s; +17.856op/s] or [+0.343%; +14.618%]
35.601ms 131.287op/s 38.286ms 122.150op/s
Request duration reports for petclinic
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~bb77a1e343, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (38.286 ms) : 37971, 38602
.   : milestone, 38286,
appsec (47.251 ms) : 46839, 47663
.   : milestone, 47251,
code_origins (46.282 ms) : 45884, 46679
.   : milestone, 46282,
iast (43.865 ms) : 43477, 44253
.   : milestone, 43865,
profiling (48.171 ms) : 47731, 48610
.   : milestone, 48171,
tracing (43.44 ms) : 43088, 43792
.   : milestone, 43440,
section candidate
no_agent (35.601 ms) : 35322, 35880
.   : milestone, 35601,
appsec (47.948 ms) : 47515, 48380
.   : milestone, 47948,
code_origins (45.097 ms) : 44695, 45498
.   : milestone, 45097,
iast (44.274 ms) : 43894, 44654
.   : milestone, 44274,
profiling (49.475 ms) : 49017, 49932
.   : milestone, 49475,
tracing (44.264 ms) : 43889, 44639
.   : milestone, 44264,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 38.286 ms [37.971 ms, 38.602 ms] -
appsec 47.251 ms [46.839 ms, 47.663 ms] 8.965 ms (23.4%)
code_origins 46.282 ms [45.884 ms, 46.679 ms] 7.995 ms (20.9%)
iast 43.865 ms [43.477 ms, 44.253 ms] 5.579 ms (14.6%)
profiling 48.171 ms [47.731 ms, 48.61 ms] 9.884 ms (25.8%)
tracing 43.44 ms [43.088 ms, 43.792 ms] 5.153 ms (13.5%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 35.601 ms [35.322 ms, 35.88 ms] -
appsec 47.948 ms [47.515 ms, 48.38 ms] 12.347 ms (34.7%)
code_origins 45.097 ms [44.695 ms, 45.498 ms] 9.496 ms (26.7%)
iast 44.274 ms [43.894 ms, 44.654 ms] 8.673 ms (24.4%)
profiling 49.475 ms [49.017 ms, 49.932 ms] 13.874 ms (39.0%)
tracing 44.264 ms [43.889 ms, 44.639 ms] 8.663 ms (24.3%)
Request duration reports for insecure-bank
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~bb77a1e343, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.316 ms) : 4267, 4364
.   : milestone, 4316,
iast (9.399 ms) : 9243, 9554
.   : milestone, 9399,
iast_FULL (14.557 ms) : 14267, 14847
.   : milestone, 14557,
iast_GLOBAL (10.554 ms) : 10357, 10750
.   : milestone, 10554,
profiling (9.176 ms) : 9006, 9346
.   : milestone, 9176,
tracing (7.44 ms) : 7337, 7542
.   : milestone, 7440,
section candidate
no_agent (4.251 ms) : 4204, 4297
.   : milestone, 4251,
iast (9.35 ms) : 9193, 9508
.   : milestone, 9350,
iast_FULL (14.317 ms) : 14027, 14607
.   : milestone, 14317,
iast_GLOBAL (10.557 ms) : 10367, 10746
.   : milestone, 10557,
profiling (8.999 ms) : 8859, 9138
.   : milestone, 8999,
tracing (7.739 ms) : 7629, 7849
.   : milestone, 7739,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.316 ms [4.267 ms, 4.364 ms] -
iast 9.399 ms [9.243 ms, 9.554 ms] 5.083 ms (117.8%)
iast_FULL 14.557 ms [14.267 ms, 14.847 ms] 10.241 ms (237.3%)
iast_GLOBAL 10.554 ms [10.357 ms, 10.75 ms] 6.238 ms (144.5%)
profiling 9.176 ms [9.006 ms, 9.346 ms] 4.86 ms (112.6%)
tracing 7.44 ms [7.337 ms, 7.542 ms] 3.124 ms (72.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 4.251 ms [4.204 ms, 4.297 ms] -
iast 9.35 ms [9.193 ms, 9.508 ms] 5.1 ms (120.0%)
iast_FULL 14.317 ms [14.027 ms, 14.607 ms] 10.066 ms (236.8%)
iast_GLOBAL 10.557 ms [10.367 ms, 10.746 ms] 6.306 ms (148.3%)
profiling 8.999 ms [8.859 ms, 9.138 ms] 4.748 ms (111.7%)
tracing 7.739 ms [7.629 ms, 7.849 ms] 3.488 ms (82.1%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master bdu/circle-ci-migration-leftovers
git_commit_date 1751873095 1751887288
git_commit_sha bbdc0b7 bb77a1e
release_version 1.51.0-SNAPSHOT~bbdc0b7f15 1.51.0-SNAPSHOT~bb77a1e343
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1751889377 1751889377
ci_job_id 1015679830 1015679830
ci_pipeline_id 69759071 69759071
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version Linux runner-zfyrx7zua-project-304-concurrent-4-p41p5855 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux Linux runner-zfyrx7zua-project-304-concurrent-4-p41p5855 6.8.0-1030-aws #32~22.04.1-Ubuntu SMP Thu Jun 5 08:38:24 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava
gantt
    title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~bb77a1e343, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.781 s) : 14781000, 14781000
.   : milestone, 14781000,
appsec (14.801 s) : 14801000, 14801000
.   : milestone, 14801000,
iast (18.544 s) : 18544000, 18544000
.   : milestone, 18544000,
iast_GLOBAL (17.923 s) : 17923000, 17923000
.   : milestone, 17923000,
profiling (15.262 s) : 15262000, 15262000
.   : milestone, 15262000,
tracing (14.714 s) : 14714000, 14714000
.   : milestone, 14714000,
section candidate
no_agent (15.37 s) : 15370000, 15370000
.   : milestone, 15370000,
appsec (14.78 s) : 14780000, 14780000
.   : milestone, 14780000,
iast (18.602 s) : 18602000, 18602000
.   : milestone, 18602000,
iast_GLOBAL (18.001 s) : 18001000, 18001000
.   : milestone, 18001000,
profiling (15.346 s) : 15346000, 15346000
.   : milestone, 15346000,
tracing (14.919 s) : 14919000, 14919000
.   : milestone, 14919000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 14.781 s [14.781 s, 14.781 s] -
appsec 14.801 s [14.801 s, 14.801 s] 20.0 ms (0.1%)
iast 18.544 s [18.544 s, 18.544 s] 3.763 s (25.5%)
iast_GLOBAL 17.923 s [17.923 s, 17.923 s] 3.142 s (21.3%)
profiling 15.262 s [15.262 s, 15.262 s] 481.0 ms (3.3%)
tracing 14.714 s [14.714 s, 14.714 s] -67.0 ms (-0.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.37 s [15.37 s, 15.37 s] -
appsec 14.78 s [14.78 s, 14.78 s] -590.0 ms (-3.8%)
iast 18.602 s [18.602 s, 18.602 s] 3.232 s (21.0%)
iast_GLOBAL 18.001 s [18.001 s, 18.001 s] 2.631 s (17.1%)
profiling 15.346 s [15.346 s, 15.346 s] -24.0 ms (-0.2%)
tracing 14.919 s [14.919 s, 14.919 s] -451.0 ms (-2.9%)
Execution time for tomcat
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~bb77a1e343, baseline=1.51.0-SNAPSHOT~bbdc0b7f15
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.484 ms) : 1473, 1496
.   : milestone, 1484,
appsec (2.415 ms) : 2366, 2464
.   : milestone, 2415,
iast (2.207 ms) : 2145, 2269
.   : milestone, 2207,
iast_GLOBAL (2.249 ms) : 2187, 2311
.   : milestone, 2249,
profiling (2.049 ms) : 1998, 2099
.   : milestone, 2049,
tracing (2.018 ms) : 1970, 2065
.   : milestone, 2018,
section candidate
no_agent (1.478 ms) : 1467, 1490
.   : milestone, 1478,
appsec (2.426 ms) : 2377, 2475
.   : milestone, 2426,
iast (2.201 ms) : 2139, 2263
.   : milestone, 2201,
iast_GLOBAL (2.253 ms) : 2191, 2315
.   : milestone, 2253,
profiling (2.05 ms) : 1999, 2101
.   : milestone, 2050,
tracing (2.018 ms) : 1970, 2066
.   : milestone, 2018,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.484 ms [1.473 ms, 1.496 ms] -
appsec 2.415 ms [2.366 ms, 2.464 ms] 930.318 µs (62.7%)
iast 2.207 ms [2.145 ms, 2.269 ms] 722.803 µs (48.7%)
iast_GLOBAL 2.249 ms [2.187 ms, 2.311 ms] 764.662 µs (51.5%)
profiling 2.049 ms [1.998 ms, 2.099 ms] 564.434 µs (38.0%)
tracing 2.018 ms [1.97 ms, 2.065 ms] 533.306 µs (35.9%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.478 ms [1.467 ms, 1.49 ms] -
appsec 2.426 ms [2.377 ms, 2.475 ms] 947.613 µs (64.1%)
iast 2.201 ms [2.139 ms, 2.263 ms] 722.63 µs (48.9%)
iast_GLOBAL 2.253 ms [2.191 ms, 2.315 ms] 774.622 µs (52.4%)
profiling 2.05 ms [1.999 ms, 2.101 ms] 571.537 µs (38.7%)
tracing 2.018 ms [1.97 ms, 2.066 ms] 539.288 µs (36.5%)

@sarahchen6
Copy link
Contributor

sarahchen6 commented Jul 3, 2025

I think it would fit this PR to also update line 4 in .circleci/collect_results.sh, .circleci/collect_reports.sh, and .circleci/collect_profiles.sh:

This folder will be saved by circleci and available after test runs. 

-> This folder will be saved by gitlab and be available after test runs under `Job artifacts`.

Also for docs/how_to_test.md and from Working with Gitlab:

In case your pull request checks failed due to some unexpected flaky tests, you can retry the continous integration pilepeline on CircleCI using the `Rerun workflow from failed` button:
![Rerun workflow from failed](how_to_test/rerun-workflow-from-failed.png)

-> In case your pull request checks fail due to unexpected flaky tests, you can retry the pipeline on GitLab using the `Retry` button from the pipeline view:
-> ![Retry](screenshot_from_Working_with_Gitlab)

...

Logs can be viewed in CircleCI within the Test-Agent container step for all instrumentation test suites, ie: `z_test_8_inst` job.

-> Logs can be viewed in GitLab within the Test-Agent container step for all instrumentation test suites, e.g. the `test_inst` jobs.

And then finally in gradle/configure_tests.gradle:

// Force timeout after 9 minutes (CircleCI defaults will fail after 10 minutes without output)

-> // Force timeout after 9 minutes (GitLab defaults will fail after ? minutes without output)

Sorry if this review is just pre-mature and for reading my "creative" formatting (that is hiding my lack of Github UI knowledge), but thanks for this clean-up!! :)

@bric3 bric3 enabled auto-merge (squash) July 3, 2025 16:15
@bric3
Copy link
Contributor Author

bric3 commented Jul 4, 2025

FYI @PerfectSlayer the rebase mechanism you used actually didn't re-sign my original commits, maybe there's something to communicate there

image

This prevent the merge
image

Was it the github tool itself ?

image

@bric3 bric3 enabled auto-merge (squash) July 4, 2025 15:45
@bric3 bric3 force-pushed the bdu/circle-ci-migration-leftovers branch from 35ac15d to 669f87d Compare July 4, 2025 15:47
bric3 and others added 6 commits July 7, 2025 13:21
… gitlab

CircleCI system-tests were in GitHub actions. You could change the version checked out
in the action, but it didn't run that change until it was merged into master. GHA runs
master-only for security reasons.

Gitlab system-tests are pinned now instead of latest, but the pin is in one-pipeline.
@bric3 bric3 force-pushed the bdu/circle-ci-migration-leftovers branch from 669f87d to bb77a1e Compare July 7, 2025 11:21
@PerfectSlayer
Copy link
Contributor

I think I used the GitHub "update with rebase" button because I never had a working copy of the branch. That's weird 🤔

@bric3 bric3 merged commit 796bf33 into master Jul 7, 2025
508 checks passed
@bric3 bric3 deleted the bdu/circle-ci-migration-leftovers branch July 7, 2025 12:18
@github-actions github-actions bot added this to the 1.51.0 milestone Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: tooling Build & Tooling tag: no release notes Changes to exclude from release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants