Conversation
palazzem
reviewed
Jan 25, 2018
| module.exports = { | ||
| Tracer: DatadogTracer | ||
| } | ||
| platform.use(node) |
| request: function (options, callback) { | ||
| options = assign({ | ||
| headers: {}, | ||
| timeout: 5000 |
Contributor
There was a problem hiding this comment.
we can tweak this value, but in general the timeout should be lower
Member
Author
There was a problem hiding this comment.
Totally agree. I started with a very high value to be safe. Would you rather change it to something like 1 or 2 seconds?
palazzem
approved these changes
Jan 26, 2018
paullegranddc
added a commit
that referenced
this pull request
May 3, 2021
alrosot
pushed a commit
to alrosot/dd-trace-js
that referenced
this pull request
May 20, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a platform module to abstract away Node specific code. This is so that other platforms can eventually be supported, such as browsers and vert.x. This first implementation includes a request method to make HTTP requests to the agent. It is very minimal in nature on purpose since it has a limited scope.
Also included are improvements to the test setup and the inclusion of additional test utilities.