fix 403 error from AWS when sending a signed request#205
Merged
Conversation
vinvol
approved these changes
Jul 30, 2018
8 tasks
pull Bot
pushed a commit
to astradot/dd-trace-js
that referenced
this pull request
Nov 15, 2023
- removes the code that disabled tracing headers when amazon signature headers were present - essentially reverts DataDog#205 - was originally done to prevent breaking AWS signatures - apparently the presence of our headers does not break amazon signatures after all - fixes DataDog#3719
erikvanbrakel
pushed a commit
to mazedesignhq/dd-trace-js
that referenced
this pull request
Jul 5, 2024
- removes the code that disabled tracing headers when amazon signature headers were present - essentially reverts DataDog#205 - was originally done to prevent breaking AWS signatures - apparently the presence of our headers does not break amazon signatures after all - fixes DataDog#3719
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes 403 errors from AWS when sending signed requests.
AWS uses the headers when signing, and since we are altering the headers when injecting the span context, the signature would become invalid. This is unnecessary for requests to AWS since it cannot propagate context, so this PR removes the injection for these requests.