Conversation
Since addresses' values are not coerced in the bindings the values are passed as is except for status code which the waf requires to be a string.
BenchmarksBenchmark execution time: 2023-11-22 08:45:09 Comparing candidate commit 7e67975 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 520 metrics, 11 unstable metrics. scenario:plugin-graphql-with-depth-off-18
|
The address is held in the context so there is no need to pass it twice. Because of this there is no need to save the sample decision in the context.
Contributor
Overall package sizeSelf size: 5.58 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3685 +/- ##
==========================================
- Coverage 85.25% 85.14% -0.11%
==========================================
Files 230 228 -2
Lines 9482 9345 -137
Branches 33 33
==========================================
- Hits 8084 7957 -127
+ Misses 1398 1388 -10 ☔ View full report in Codecov by Sentry. |
uurien
requested changes
Oct 6, 2023
Collaborator
uurien
left a comment
uurien
left a comment
There was a problem hiding this comment.
Can we create an extra test in index.express.plugin.spec.js doing a real call?
simon-id
reviewed
Nov 6, 2023
simon-id
reviewed
Nov 8, 2023
simon-id
reviewed
Nov 8, 2023
simon-id
reviewed
Nov 8, 2023
| derivatives.forEach((address) => { | ||
| for (const [key, value] of Object.entries(address)) { | ||
| if (key.includes('_dd.appsec.s.req')) { | ||
| const gzippedValue = zlib.gzipSync(JSON.stringify(value)) |
Member
There was a problem hiding this comment.
Is there a way for us to not do this synchronously ? zlib will use a different thread and here the whole process will wait for that operation :/
simon-id
reviewed
Nov 8, 2023
simon-id
reviewed
Nov 13, 2023
simon-id
reviewed
Nov 13, 2023
hoolioh
force-pushed
the
julio/api-security
branch
from
771a71f to
218cee0
Compare
simon-id
requested changes
Nov 17, 2023
Member
simon-id
left a comment
simon-id
left a comment
There was a problem hiding this comment.
Maybe also add a statistical test that make sure the sampling is working as intended ?
uurien
reviewed
Nov 17, 2023
hoolioh
force-pushed
the
julio/api-security
branch
4 times, most recently
from
0a33761 to
b0a755f
Compare
hoolioh
force-pushed
the
julio/api-security
branch
from
b0a755f to
f198e84
Compare
* Remove requiredAddresses from WAF context. * Improve configuration tests.
simon-id
approved these changes
Nov 22, 2023
uurien
approved these changes
Nov 22, 2023
khanayan123
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Config variables. * Add support for schema reporting. * Add support for schema extraction on request addresses. * Pass response's status code as string. --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: simon-id <simon.id@datadoghq.com>
khanayan123
pushed a commit
that referenced
this pull request
Dec 13, 2023
* Config variables. * Add support for schema reporting. * Add support for schema extraction on request addresses. * Pass response's status code as string. --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: simon-id <simon.id@datadoghq.com>
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Config variables. * Add support for schema reporting. * Add support for schema extraction on request addresses. * Pass response's status code as string. --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: simon-id <simon.id@datadoghq.com>
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
* Config variables. * Add support for schema reporting. * Add support for schema extraction on request addresses. * Pass response's status code as string. --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: simon-id <simon.id@datadoghq.com>
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Config variables. * Add support for schema reporting. * Add support for schema extraction on request addresses. * Pass response's status code as string. --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: simon-id <simon.id@datadoghq.com>
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Config variables. * Add support for schema reporting. * Add support for schema extraction on request addresses. * Pass response's status code as string. --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: simon-id <simon.id@datadoghq.com>
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Config variables. * Add support for schema reporting. * Add support for schema extraction on request addresses. * Pass response's status code as string. --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: simon-id <simon.id@datadoghq.com>
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
* Config variables. * Add support for schema reporting. * Add support for schema extraction on request addresses. * Pass response's status code as string. --------- Co-authored-by: Ugaitz Urien <ugaitz.urien@datadoghq.com> Co-authored-by: simon-id <simon.id@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR add support for schema extraction when calling the waf. It does so by passing a new key inside
waf.context.processoraddress.