Skip to content

[ci-visibility] Do not report total code coverage unless user has explicitly added code coverage#3828

Merged
juan-fernandez merged 5 commits intomasterfrom
juan-fernandez/do-not-report-code-coverage-if-itr
Dec 1, 2023
Merged

[ci-visibility] Do not report total code coverage unless user has explicitly added code coverage#3828
juan-fernandez merged 5 commits intomasterfrom
juan-fernandez/do-not-report-code-coverage-if-itr

Conversation

@juan-fernandez
Copy link
Copy Markdown
Collaborator

@juan-fernandez juan-fernandez commented Nov 28, 2023

What does this PR do?

  • Do not report total code coverage unless the user has manually added code coverage.
  • (unrelated) Log itr_enabled value returned from the backend.

Motivation

Unless the user has explicitly decided to run their test session with code coverage, we don't want to report this number if ITR is active:

  • It will not always be available (we disable code coverage at will).
  • When there's test skipping, the total number will be wrong.

If the user has indeed added code coverage manually, we don't want to lose that info.

Plugin Checklist

  • Unit tests.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 28, 2023

Overall package size

Self size: 5.61 MB
Deduped: 61.6 MB
No deduping: 62.36 MB

Dependency sizes

name version self size total size
@datadog/native-iast-taint-tracking 1.6.4 16.43 MB 16.44 MB
@datadog/native-appsec 5.0.0 15.16 MB 15.17 MB
@datadog/pprof 4.0.1 9.32 MB 10.16 MB
protobufjs 7.2.4 2.74 MB 6.52 MB
@datadog/native-iast-rewriter 2.2.1 2.27 MB 2.36 MB
@opentelemetry/core 1.14.0 872.87 kB 1.47 MB
@datadog/native-metrics 2.0.0 898.77 kB 1.3 MB
@opentelemetry/api 1.4.1 780.32 kB 780.32 kB
import-in-the-middle 1.4.2 41.4 kB 704.79 kB
pprof-format 2.0.7 588.12 kB 588.12 kB
msgpack-lite 0.1.26 201.16 kB 281.59 kB
opentracing 0.14.7 194.81 kB 194.81 kB
semver 7.5.4 93.4 kB 123.8 kB
@datadog/sketches-js 2.1.0 109.9 kB 109.9 kB
lodash.sortby 4.7.0 75.76 kB 75.76 kB
lru-cache 7.14.0 74.95 kB 74.95 kB
ipaddr.js 2.1.0 60.23 kB 60.23 kB
ignore 5.2.4 51.22 kB 51.22 kB
int64-buffer 0.1.10 49.18 kB 49.18 kB
istanbul-lib-coverage 3.2.0 29.34 kB 29.34 kB
lodash.uniq 4.5.0 25.01 kB 25.01 kB
limiter 1.1.5 23.17 kB 23.17 kB
dc-polyfill 0.1.2 22.77 kB 22.77 kB
retry 0.13.1 18.85 kB 18.85 kB
lodash.kebabcase 4.1.1 17.75 kB 17.75 kB
node-abort-controller 3.1.1 16.89 kB 16.89 kB
lodash.pick 4.4.0 16.33 kB 16.33 kB
jest-docblock 29.7.0 8.99 kB 12.76 kB
crypto-randomuuid 1.0.0 11.18 kB 11.18 kB
path-to-regexp 0.1.7 6.78 kB 6.78 kB
koalas 1.0.2 6.47 kB 6.47 kB
methods 1.1.2 5.29 kB 5.29 kB
module-details-from-path 1.0.3 4.47 kB 4.47 kB

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 28, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2c29346) 85.22% compared to head (102f50f) 85.21%.

Files Patch % Lines
...y/intelligent-test-runner/get-itr-configuration.js 60.00% 2 Missing ⚠️
packages/dd-trace/src/plugins/util/test.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3828      +/-   ##
==========================================
- Coverage   85.22%   85.21%   -0.01%     
==========================================
  Files         230      230              
  Lines        9548     9546       -2     
  Branches       33       33              
==========================================
- Hits         8137     8135       -2     
  Misses       1411     1411              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 28, 2023

Benchmarks

Benchmark execution time: 2023-12-01 09:33:05

Comparing candidate commit 102f50f in PR branch juan-fernandez/do-not-report-code-coverage-if-itr with baseline commit 2c29346 in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 517 metrics, 13 unstable metrics.

scenario:log-with-debug-16

  • 🟥 cpu_user_time [+15.457ms; +23.539ms] or [+5.237%; +7.975%]

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-131.718MB; -120.306MB] or [-13.691%; -12.505%]

@juan-fernandez juan-fernandez changed the title [ci-visibility] Do not report total code coverage % if ITR is enabled [ci-visibility] Do not report total code coverage unless user has explicitly added code coverage Nov 29, 2023
@juan-fernandez juan-fernandez marked this pull request as ready for review November 30, 2023 10:52
@juan-fernandez juan-fernandez requested review from a team as code owners November 30, 2023 10:52
tlhunter
tlhunter previously approved these changes Nov 30, 2023
anmarchenko
anmarchenko previously approved these changes Dec 1, 2023
@juan-fernandez juan-fernandez dismissed stale reviews from anmarchenko and tlhunter via 102f50f December 1, 2023 09:24
@juan-fernandez juan-fernandez merged commit 33c9000 into master Dec 1, 2023
@juan-fernandez juan-fernandez deleted the juan-fernandez/do-not-report-code-coverage-if-itr branch December 1, 2023 10:29
khanayan123 pushed a commit that referenced this pull request Dec 12, 2023
khanayan123 pushed a commit that referenced this pull request Dec 13, 2023
This was referenced Dec 13, 2023
khanayan123 pushed a commit that referenced this pull request Dec 14, 2023
khanayan123 pushed a commit that referenced this pull request Dec 14, 2023
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
khanayan123 pushed a commit that referenced this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants