[ci-visibility] Do not report total code coverage unless user has explicitly added code coverage#3828
Merged
juan-fernandez merged 5 commits intomasterfrom Dec 1, 2023
Conversation
Contributor
Overall package sizeSelf size: 5.61 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3828 +/- ##
==========================================
- Coverage 85.22% 85.21% -0.01%
==========================================
Files 230 230
Lines 9548 9546 -2
Branches 33 33
==========================================
- Hits 8137 8135 -2
Misses 1411 1411 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2023-12-01 09:33:05 Comparing candidate commit 102f50f in PR branch Found 1 performance improvements and 1 performance regressions! Performance is the same for 517 metrics, 13 unstable metrics. scenario:log-with-debug-16
scenario:plugin-graphql-with-depth-off-18
|
tlhunter
previously approved these changes
Nov 30, 2023
anmarchenko
previously approved these changes
Dec 1, 2023
102f50f
anmarchenko
approved these changes
Dec 1, 2023
uurien
approved these changes
Dec 1, 2023
khanayan123
pushed a commit
that referenced
this pull request
Dec 12, 2023
…licitly added code coverage (#3828)
khanayan123
pushed a commit
that referenced
this pull request
Dec 13, 2023
…licitly added code coverage (#3828)
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
…licitly added code coverage (#3828)
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
…licitly added code coverage (#3828)
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
…licitly added code coverage (#3828)
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
…licitly added code coverage (#3828)
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
…licitly added code coverage (#3828)
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
…licitly added code coverage (#3828)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
itr_enabledvalue returned from the backend.Motivation
Unless the user has explicitly decided to run their test session with code coverage, we don't want to report this number if ITR is active:
If the user has indeed added code coverage manually, we don't want to lose that info.
Plugin Checklist