Only run DNS and Net timeline events integration tests on Node 16+#3879
Merged
Only run DNS and Net timeline events integration tests on Node 16+#3879
Conversation
Contributor
Overall package sizeSelf size: 5.71 MB Dependency sizes
🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3879 +/- ##
==========================================
+ Coverage 84.47% 86.76% +2.29%
==========================================
Files 234 228 -6
Lines 9802 9182 -620
Branches 33 33
==========================================
- Hits 8280 7967 -313
+ Misses 1522 1215 -307 ☔ View full report in Codecov by Sentry. |
BenchmarksBenchmark execution time: 2023-12-14 15:28:47 Comparing candidate commit 9f1250b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 521 metrics, 11 unstable metrics. |
khanayan123
approved these changes
Dec 14, 2023
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
khanayan123
pushed a commit
that referenced
this pull request
Dec 14, 2023
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
khanayan123
pushed a commit
that referenced
this pull request
Jan 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Restricts running DNS and Net timeline events integration tests only to Node 16 and above.
Motivation
DNS and Net perf events aren't available in Node 14; the tests can't work.
Additional Notes
Recommended to review in whitespace-ignore mode.
Security
Datadog employees:
@DataDog/security-design-and-guidance.