Skip to content

refactor: move remote_config code to the root of dd-trace#4475

Merged
BridgeAR merged 3 commits intomasterfrom
watson/refactor-remote-config
Feb 25, 2025
Merged

refactor: move remote_config code to the root of dd-trace#4475
BridgeAR merged 3 commits intomasterfrom
watson/refactor-remote-config

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Jul 5, 2024

What does this PR do?

Move the folder remote_config on level up from packages/dd-trace/src/appsec to packages/dd-trace/src.

Motivation

The Remote Configuration code was first introduced by the appsec team. Now that more and more teams are using it, it makes sense to move it to a shared location in the root of the dd-trace package.

@watson watson self-assigned this Jul 5, 2024
@watson watson requested review from a team as code owners July 5, 2024 13:55
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 5, 2024

Overall package size

Self size: 8.77 MB
Deduped: 94.97 MB
No deduping: 95.49 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@watson watson marked this pull request as draft July 5, 2024 14:09
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jul 5, 2024

Benchmarks

Benchmark execution time: 2025-02-25 13:19:45

Comparing candidate commit 7430243 in PR branch watson/refactor-remote-config with baseline commit 96bb84a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 916 metrics, 17 unstable metrics.

@watson watson force-pushed the watson/refactor-remote-config branch from 898b91e to 5b4a2f0 Compare July 19, 2024 13:16
Copy link
Copy Markdown
Collaborator Author

watson commented Jul 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@simon-id
Copy link
Copy Markdown
Member

I see there is activity on this PR, FYI I'm planning on reviewing it and adding the appsec changes next week

@watson
Copy link
Copy Markdown
Collaborator Author

watson commented Jul 20, 2024

I'm just playing around with Graphite, so this PR got rebased in the process

BridgeAR
BridgeAR previously approved these changes Feb 24, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 25, 2025

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.

Project coverage is 80.27%. Comparing base (96bb84a) to head (7430243).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
packages/dd-trace/src/remote_config/index.js 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4475      +/-   ##
==========================================
- Coverage   80.94%   80.27%   -0.67%     
==========================================
  Files         488      489       +1     
  Lines       21844    21860      +16     
==========================================
- Hits        17681    17548     -133     
- Misses       4163     4312     +149     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@watson watson force-pushed the watson/refactor-remote-config branch from 4c8f5eb to f23318d Compare February 25, 2025 09:29
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Feb 25, 2025

Datadog Report

Branch report: watson/refactor-remote-config
Commit report: d3adcc6
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 671 Passed, 0 Skipped, 11m 50.46s Total Time

BridgeAR
BridgeAR previously approved these changes Feb 25, 2025
@watson watson marked this pull request as ready for review February 25, 2025 13:08
@watson watson requested a review from a team as a code owner February 25, 2025 13:08
@BridgeAR
Copy link
Copy Markdown
Member

/merge --method squash

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Feb 25, 2025

View all feedbacks in Devflow UI.
2025-02-25 13:22:46 UTC ℹ️ Start processing command /merge --method squash


2025-02-25 13:22:54 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-02-25 14:28:42 UTC ⚠️ MergeQueue: This merge request was unqueued

ruben.bridgewater@datadoghq.com unqueued this merge request

@BridgeAR
Copy link
Copy Markdown
Member

/remove

@dd-devflow
Copy link
Copy Markdown

dd-devflow Bot commented Feb 25, 2025

View all feedbacks in Devflow UI.
2025-02-25 14:28:33 UTC ℹ️ Start processing command /remove


2025-02-25 14:28:36 UTC ℹ️ Devflow: /remove

@BridgeAR BridgeAR merged commit f07a03a into master Feb 25, 2025
@BridgeAR BridgeAR deleted the watson/refactor-remote-config branch February 25, 2025 15:13
@watson watson mentioned this pull request Feb 27, 2025
@CarlesDD CarlesDD mentioned this pull request Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants