Skip to content

Refactor tracer config option processing#4520

Closed
watson wants to merge 2 commits intomasterfrom
watson/DEBUG-2567/config-option-refactor
Closed

Refactor tracer config option processing#4520
watson wants to merge 2 commits intomasterfrom
watson/DEBUG-2567/config-option-refactor

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Jul 17, 2024

No description provided.

@watson watson self-assigned this Jul 17, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 17, 2024

Overall package size

Self size: 6.86 MB
Deduped: 58.81 MB
No deduping: 59.09 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.0.0 | 11.14 MB | 11.15 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 7.01 MB | | @datadog/native-iast-rewriter | 2.3.1 | 2.15 MB | 2.24 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jul 17, 2024

Benchmarks

Benchmark execution time: 2024-07-23 06:56:54

Comparing candidate commit 20a54f7 in PR branch watson/DEBUG-2567/config-option-refactor with baseline commit d2c0b2c in branch watson/DEBUG-2567/config-hidden-props.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@watson watson force-pushed the watson/DEBUG-2567/config-option-refactor branch from f91f566 to e28ba6d Compare July 17, 2024 12:01
@watson watson changed the base branch from watson/DEBUG-2532/log-config to watson/DEBUG-2567/config-hidden-props July 17, 2024 12:01
@watson watson force-pushed the watson/DEBUG-2567/config-hidden-props branch from c05490c to 35c4813 Compare July 18, 2024 17:29
@watson watson force-pushed the watson/DEBUG-2567/config-option-refactor branch from e28ba6d to 6f1119d Compare July 18, 2024 17:29
@watson watson force-pushed the watson/DEBUG-2567/config-hidden-props branch from 35c4813 to dfc947f Compare July 18, 2024 17:33
@watson watson force-pushed the watson/DEBUG-2567/config-option-refactor branch from 6f1119d to a37a3d6 Compare July 18, 2024 17:33
@datadog-datadog-prod-us1
Copy link
Copy Markdown

Library Vulnerabilities

✅ No library vulnerabilities found (scanned a37a3d6).

@watson watson force-pushed the watson/DEBUG-2567/config-hidden-props branch 2 times, most recently from fa300e8 to 0e69d6d Compare July 19, 2024 12:34
@watson watson force-pushed the watson/DEBUG-2567/config-option-refactor branch from a37a3d6 to 71118ce Compare July 19, 2024 12:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.95%. Comparing base (0e69d6d) to head (71118ce).

Additional details and impacted files
@@                            Coverage Diff                             @@
##           watson/DEBUG-2567/config-hidden-props    #4520       +/-   ##
==========================================================================
+ Coverage                                  17.65%   59.95%   +42.29%     
==========================================================================
  Files                                          6      253      +247     
  Lines                                        776    11399    +10623     
  Branches                                      33       33               
==========================================================================
+ Hits                                         137     6834     +6697     
- Misses                                       639     4565     +3926     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator Author

watson commented Jul 19, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @watson and the rest of your teammates on Graphite Graphite

watson added 2 commits July 23, 2024 08:47
Hide internal-only properties so they are not exposed to the rest of the
app. This makes reasoning about what's a config option and what's not
easier.
@watson watson force-pushed the watson/DEBUG-2567/config-hidden-props branch from 0e69d6d to d2c0b2c Compare July 23, 2024 06:48
@watson watson force-pushed the watson/DEBUG-2567/config-option-refactor branch from 71118ce to 20a54f7 Compare July 23, 2024 06:48
@watson watson force-pushed the watson/DEBUG-2567/config-hidden-props branch from d2c0b2c to 401da13 Compare July 23, 2024 12:03
Base automatically changed from watson/DEBUG-2567/config-hidden-props to master July 25, 2024 06:45
@BridgeAR
Copy link
Copy Markdown
Member

This is quite outdated and as part of our configuration OKRs we'll also work on config.js again to improve that.
I'll go ahead and close this for now. Please feel free to reopen, in case you believe that's a mistake!

@BridgeAR BridgeAR closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants