chore(w3c): avoid setting _dd.parent_id to 16 zeros#4576
Conversation
Overall package sizeSelf size: 6.98 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-08-06 23:44:33 Comparing candidate commit 272cbd5f283ba860b2b41b40867c0b40e3a9ddfd in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 263 metrics, 3 unstable metrics. |
8f82edf to
272cbd5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4576 +/- ##
==========================================
+ Coverage 63.02% 68.63% +5.60%
==========================================
Files 254 13 -241
Lines 11095 982 -10113
Branches 33 33
==========================================
- Hits 6993 674 -6319
+ Misses 4102 308 -3794 ☔ View full report in Codecov by Sentry. |
khanayan123
left a comment
There was a problem hiding this comment.
Just need to pass tests but otherwise LGTM
272cbd5 to
f72917d
Compare
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [dd-trace](https://togithub.com/DataDog/dd-trace-js) | [`5.21.0` -> `5.22.0`](https://renovatebot.com/diffs/npm/dd-trace/5.10.0/5.22.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DataDog/dd-trace-js (dd-trace)</summary> ### [`v5.22.0`](https://togithub.com/DataDog/dd-trace-js/releases/tag/v5.22.0) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.21.0...v5.22.0) ##### Fixes - \[[`ab80d70`](https://togithub.com/DataDog/dd-trace-js/commit/ab80d703c1)] - fix(lambda): gate timeout spans and add missing clear (jordan gonzález) [https://github.com/DataDog/dd-trace-js/pull/4446](https://togithub.com/DataDog/dd-trace-js/pull/4446) - \[[`1f2914f`](https://togithub.com/DataDog/dd-trace-js/commit/1f2914f9fc)] - chore(w3c): avoid setting \_dd.parent_id to 16 zeros (Munir Abdinur)[https://github.com/DataDog/dd-trace-js/pull/4576](https://togithub.com/DataDog/dd-trace-js/pull/4576)6 - \[[`683df27`](https://togithub.com/DataDog/dd-trace-js/commit/683df27a6d)] - fix(openai): tracing occurs in correct async context (Sam Brenner) [https://github.com/DataDog/dd-trace-js/pull/4583](https://togithub.com/DataDog/dd-trace-js/pull/4583) - \[[`b19b382`](https://togithub.com/DataDog/dd-trace-js/commit/b19b382f0a)] - Rename rasp metrics (Igor Unanua) [https://github.com/DataDog/dd-trace-js/pull/4635](https://togithub.com/DataDog/dd-trace-js/pull/4635) - \[[`f4ecee9`](https://togithub.com/DataDog/dd-trace-js/commit/f4ecee9633)] - Fix AppSec manual blocking parameters (Ugaitz Urien) [https://github.com/DataDog/dd-trace-js/pull/4606](https://togithub.com/DataDog/dd-trace-js/pull/4606) ##### Features - \[[`bc2d6a1`](https://togithub.com/DataDog/dd-trace-js/commit/bc2d6a1473)] - Bump `@datadog/native-appsec` to `8.1.1` (Carles Capell) [https://github.com/DataDog/dd-trace-js/pull/4630](https://togithub.com/DataDog/dd-trace-js/pull/4630) - \[[`1a2aaed`](https://togithub.com/DataDog/dd-trace-js/commit/1a2aaedaf0)] - \[test visibility] Add configuration flags to auto test retries (Juan Antonio Fernández de Alba)[https://github.com/DataDog/dd-trace-js/pull/4609](https://togithub.com/DataDog/dd-trace-js/pull/4609)9 ##### Improvements - \[[`e568fe3`](https://togithub.com/DataDog/dd-trace-js/commit/e568fe3e8f)] - PROF-10330: Emit SSI information in the profile system info (Attila Szegedi) - \[[`a04ba3f`](https://togithub.com/DataDog/dd-trace-js/commit/a04ba3f9e7)] - hapi: migrate from AsyncResource to TracingChannel, see [#​4597](https://togithub.com/DataDog/dd-trace-js/issues/4597) (Thomas Hunter II) [https://github.com/DataDog/dd-trace-js/pull/4622](https://togithub.com/DataDog/dd-trace-js/pull/4622) - \[[`69aedbc`](https://togithub.com/DataDog/dd-trace-js/commit/69aedbc892)] - Safer shimming (Bryan English) [https://github.com/DataDog/dd-trace-js/pull/4585](https://togithub.com/DataDog/dd-trace-js/pull/4585) ### [`v5.21.0`](https://togithub.com/DataDog/dd-trace-js/compare/v5.20.0...725f16142baf7724f537a6848dc49e1b10d889bb) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.20.0...v5.21.0) ### [`v5.20.0`](https://togithub.com/DataDog/dd-trace-js/compare/v5.19.0...v5.20.0) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.19.0...v5.20.0) ### [`v5.19.0`](https://togithub.com/DataDog/dd-trace-js/compare/v5.18.0...37d3876ded2e8a2fce14520bf85dc6920e777c31) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.18.0...v5.19.0) ### [`v5.18.0`](https://togithub.com/DataDog/dd-trace-js/compare/v5.17.0...01464c7c14154ef75e6ce90b283d2e85b55cbb5c) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.17.0...v5.18.0) ### [`v5.17.0`](https://togithub.com/DataDog/dd-trace-js/releases/tag/v5.17.0) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.16.0...v5.17.0) ##### Improvements - **core:** RecordException api now supports adding exceptions as span events ([#​4386](https://togithub.com/DataDog/dd-trace-js/issues/4386)) - **appsec:** Allows AppSec to replace status code, headers, and body when an attack is detected ([#​3837](https://togithub.com/DataDog/dd-trace-js/issues/3837)) ##### Features - **core:** Add support for span events ([#​4036](https://togithub.com/DataDog/dd-trace-js/issues/4036) ) - **core:** Add automatic instrumentation support for Undici ([#​4293](https://togithub.com/DataDog/dd-trace-js/issues/4293)) ### [`v5.16.0`](https://togithub.com/DataDog/dd-trace-js/releases/tag/v5.16.0) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.15.0...v5.16.0) ##### Improvements - **graphql:** fix graphql.resolve span durations ([#​4387](https://togithub.com/DataDog/dd-trace-js/issues/4387)) - **otel:** remaps http status tag to meet ddog convention for otel([#​4384](https://togithub.com/DataDog/dd-trace-js/issues/4384)) ##### Bug Fixes - **ci:** test OCI system-tests scenarios on every commit ([#​4371](https://togithub.com/DataDog/dd-trace-js/issues/4371)) - **otel:** pin otel api version in integration test ([#​4388](https://togithub.com/DataDog/dd-trace-js/issues/4388)) - **core:** send original config value to telemetry ([#​4378](https://togithub.com/DataDog/dd-trace-js/issues/4378)) - **core:** fix RC support for sampling rules patch ([#​4381](https://togithub.com/DataDog/dd-trace-js/issues/4381)) ### [`v5.15.0`](https://togithub.com/DataDog/dd-trace-js/releases/tag/v5.15.0) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.14.1...v5.15.0) #### Improvements - Remove outdated polyfills [#​4009](https://togithub.com/DataDog/dd-trace-js/pull/4009) - Update native-appsec module to 8.0.1 [#​4347](https://togithub.com/DataDog/dd-trace-js/pull/4347) - profiler supports activation through single-step instrumentation [#​4375](https://togithub.com/DataDog/dd-trace-js/pull/4375) #### Features - \[ci-visibility] Support mocha parallel mode [#​4314](https://togithub.com/DataDog/dd-trace-js/pull/4314) #### Bug fixes - \[ci-visibility] Fix EFD with jest and jsdom [#​4323](https://togithub.com/DataDog/dd-trace-js/pull/4323) - \[ci-visibility] Fix selenium when run outside of a supported test framework [#​4330](https://togithub.com/DataDog/dd-trace-js/pull/4330) ### [`v5.14.1`](https://togithub.com/DataDog/dd-trace-js/releases/tag/v5.14.1) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.14.0...v5.14.1) ##### Features - debug warnings when init after instrumented packages ([#​4307](https://togithub.com/DataDog/dd-trace-js/issues/4307)) ### [`v5.14.0`](https://togithub.com/DataDog/dd-trace-js/releases/tag/v5.14.0) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.13.0...v5.14.0) ##### Improvements - **core:** Add child_process plugin to typings ([#​4306](https://togithub.com/DataDog/dd-trace-js/issues/4306)), thanks to [@​ikonst](https://togithub.com/ikonst) for the original PR - **asm:** Add support for meta_struct property in the spans for v0.4 agent api ([#​4287](https://togithub.com/DataDog/dd-trace-js/issues/4287)) - **serverless:** Enable Serverless Mini Agent for Azure Functions on All Plans ([#​4304](https://togithub.com/DataDog/dd-trace-js/issues/4304)) - **core:** stop clobbering manually-installed tracer with Single Step Instrumentation ([#​4300](https://togithub.com/DataDog/dd-trace-js/issues/4300)) - **core:** define an explicit version range of support for the [@​opentelemetry/api](https://togithub.com/opentelemetry/api) ([#​4318](https://togithub.com/DataDog/dd-trace-js/issues/4318)) ##### Features - **profiling:** Add profiler support for node 22 ([#​4312](https://togithub.com/DataDog/dd-trace-js/issues/4312)) ### [`v5.13.0`](https://togithub.com/DataDog/dd-trace-js/compare/v5.12.0...0325725d8a4195ad980fcbe9535dc3f54f3c591c) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.12.0...v5.13.0) ### [`v5.12.0`](https://togithub.com/DataDog/dd-trace-js/releases/tag/v5.12.0) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.11.0...v5.12.0) ##### Features - [Add Support for OpenAI v4](https://togithub.com/DataDog/dd-trace-js/pull/4232) ##### Improvements - [Do not require appsec modules when disabling appsec if they have not been required before](https://togithub.com/DataDog/dd-trace-js/pull/4244) ##### Bug Fixes - [fix fetch error when request has already been sent](https://togithub.com/DataDog/dd-trace-js/pull/4258). Fixes [#​4259](https://togithub.com/DataDog/dd-trace-js/issues/4259) - [Prevent object key tainting](https://togithub.com/DataDog/dd-trace-js/pull/4251) ### [`v5.11.0`](https://togithub.com/DataDog/dd-trace-js/releases/tag/v5.11.0) [Compare Source](https://togithub.com/DataDog/dd-trace-js/compare/v5.10.0...v5.11.0) ##### Features - \[profiling] [PROF-9250: Enable timeline and CPU profiling by default](https://togithub.com/DataDog/dd-trace-js/pull/4149) - \[iast] [Hardcoded passwords detection and update hardcoded secret rules](https://togithub.com/DataDog/dd-trace-js/pull/4066) - \[ci-visibility] [\[ci-visibility\] Add selenium support](https://togithub.com/DataDog/dd-trace-js/pull/4241) - \[open telemetry] [implement OTEL env var support for dd-trace-js](https://togithub.com/DataDog/dd-trace-js/pull/4248) - \[profiling] [Support ipv6 in profiler](https://togithub.com/DataDog/dd-trace-js/pull/4124). Thanks [@​benasher44](https://togithub.com/benasher44) for the PR! ##### Improvements - \[dogstatsd] [Added histogram method to dogstatsd](https://togithub.com/DataDog/dd-trace-js/pull/4178). Thanks [@​bin-umar](https://togithub.com/bin-umar) for the PR! ##### Bug Fixes - \[mongoose] [Fixed attempting to wrap undefined mongoose.Promise](https://togithub.com/DataDog/dd-trace-js/pull/4165). Thanks [@​nathan-knight](https://togithub.com/nathan-knight) for the PR! - \[mysql2] [Avoid run sequelize plugin test with non compatible mysql2](https://togithub.com/DataDog/dd-trace-js/pull/4229) - \[ci-visibility] [\[ci-visibility\] Fix window access when using cy.origin (multi origin) in Cypress](https://togithub.com/DataDog/dd-trace-js/pull/4228) - \[dogstatsd] [Add dogstatsd to noop proxy](https://togithub.com/DataDog/dd-trace-js/pull/4225) - \[ci-visibility] [\[ci-visibility\] Fix ITR with multi project setup in jest](https://togithub.com/DataDog/dd-trace-js/pull/4249) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/X-oss-byte/Nextjs).
What does this PR do?
Currently when w3c tracestate headers are extracted by Datadog W3C Propagators:
The second condition is no longer required. Datadog internal services no
longer handle the case where
Span.meta["_dd.parent_id"] == 0000000000000000.0000000000000000is treated as invalid value and ignored. We should avoid setting and handling this value in client libraries.Motivation
Plugin Checklist
Additional Notes