Merged
Conversation
While _functioning_ correctly, the logging and telemetry was broken for packages that met one range, but didn't meet a subsequent range. This is now fixed.
Contributor
Overall package sizeSelf size: 6.95 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-08-12 19:17:05 Comparing candidate commit ea3384a in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics. |
watson
reviewed
Aug 13, 2024
| continue | ||
| } | ||
| if (!Object.hasOwnProperty(namesAndSuccesses, name)) { | ||
| if (typeof namesAndSuccesses[`${name}@${version}`] === 'undefined') { |
Collaborator
There was a problem hiding this comment.
Why not this?
Suggested change
| if (typeof namesAndSuccesses[`${name}@${version}`] === 'undefined') { | |
| if (namesAndSuccesses[`${name}@${version}`] === undefined) { |
Qard
approved these changes
Aug 13, 2024
bengl
added a commit
that referenced
this pull request
Aug 29, 2024
While _functioning_ correctly, the logging and telemetry was broken for packages that met one range, but didn't meet a subsequent range. This is now fixed.
Merged
bengl
added a commit
that referenced
this pull request
Aug 29, 2024
While _functioning_ correctly, the logging and telemetry was broken for packages that met one range, but didn't meet a subsequent range. This is now fixed.
Merged
bengl
added a commit
that referenced
this pull request
Aug 30, 2024
While _functioning_ correctly, the logging and telemetry was broken for packages that met one range, but didn't meet a subsequent range. This is now fixed.
bengl
added a commit
that referenced
this pull request
Aug 30, 2024
While _functioning_ correctly, the logging and telemetry was broken for packages that met one range, but didn't meet a subsequent range. This is now fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While functioning correctly, the logging and telemetry was broken for packages that met one range, but didn't meet a subsequent range. This is now fixed.
What does this PR do?
Motivation
Plugin Checklist
Additional Notes