Add error strings to telemetry, not just error instances #4612
Add error strings to telemetry, not just error instances #4612juan-fernandez merged 1 commit intomasterfrom
Conversation
Overall package sizeSelf size: 6.95 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
| level: 'ERROR', | ||
| message: msg.message, | ||
| stack: msg.stack | ||
| stack_trace: msg.stack |
There was a problem hiding this comment.
I believe this was a bug: as far as I can see, log-collector expects an object with a stack_trace attribute
There was a problem hiding this comment.
Yes, that was a mistake. Thanks for correcting it!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4612 +/- ##
===========================================
+ Coverage 66.88% 84.50% +17.61%
===========================================
Files 328 273 -55
Lines 14073 12098 -1975
Branches 33 33
===========================================
+ Hits 9413 10223 +810
+ Misses 4660 1875 -2785 ☔ View full report in Codecov by Sentry. |
| expect(logCollectorAdd).to.not.be.called | ||
| }) | ||
|
|
||
| describe('datadog:log:error', () => { |
There was a problem hiding this comment.
there were no tests for datadog:log:error as far as I can see
BenchmarksBenchmark execution time: 2024-08-19 13:10:05 Comparing candidate commit 871d134 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 7 unstable metrics. |
| level: 'ERROR', | ||
| message: msg.message, | ||
| stack: msg.stack | ||
| stack_trace: msg.stack |
There was a problem hiding this comment.
Yes, that was a mistake. Thanks for correcting it!
2 participants
What does this PR do?
log.errorcalls that pass a stringonLogthat was passingstackinstead ofstack_trace: I believe this was an oversight, but please check.Motivation
We have plenty of
log.error('$STRING_AND_NOT_ERROR')which we would like to register as error logs as well.Follow up from #4605
Plugin Checklist