Skip to content

use npm pack instead of git clone for system test binaries#4616

Merged
rochdev merged 6 commits intomasterfrom
rochdev/safer-system-test-binaries
Aug 22, 2024
Merged

use npm pack instead of git clone for system test binaries#4616
rochdev merged 6 commits intomasterfrom
rochdev/safer-system-test-binaries

Conversation

@rochdev
Copy link
Copy Markdown
Member

@rochdev rochdev commented Aug 20, 2024

What does this PR do?

Use npm pack instead of git clone for system test binaries.

Motivation

The repository contains a lot more files than what would generally be published to npm which can cause unexpected issues with system tests in CI.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 20, 2024

Overall package size

Self size: 6.98 MB
Deduped: 58.2 MB
No deduping: 58.48 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 20, 2024

Benchmarks

Benchmark execution time: 2024-08-20 18:13:18

Comparing candidate commit df69982 in PR branch rochdev/safer-system-test-binaries with baseline commit 8a2b17b in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@rochdev rochdev marked this pull request as ready for review August 20, 2024 18:10
@rochdev rochdev requested a review from a team as a code owner August 20, 2024 18:10
@rochdev rochdev merged commit cd80403 into master Aug 22, 2024
@rochdev rochdev deleted the rochdev/safer-system-test-binaries branch August 22, 2024 20:53
@bengl bengl mentioned this pull request Aug 29, 2024
@bengl bengl mentioned this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants