Skip to content

Fix Node.js version to v22.6 instead of "latest"#4629

Merged
watson merged 2 commits intomasterfrom
watson/08-27-fix_node.js_version_to_v22.7_instead_of_latest_
Aug 27, 2024
Merged

Fix Node.js version to v22.6 instead of "latest"#4629
watson merged 2 commits intomasterfrom
watson/08-27-fix_node.js_version_to_v22.7_instead_of_latest_

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Aug 27, 2024

This is a temporary fix until Node.js v22.8.0 is released due to a bug in Node.js v22.7.0.

For more details see Node.js bug-report: nodejs/node#54518

This is a temprary fix until v22.8.0 is released due to a bug in
v22.7.0: nodejs/node#54518
@watson watson requested review from a team as code owners August 27, 2024 12:02
Copy link
Copy Markdown
Collaborator Author

watson commented Aug 27, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @watson and the rest of your teammates on Graphite Graphite

@watson watson self-assigned this Aug 27, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 27, 2024

Overall package size

Self size: 6.98 MB
Deduped: 58.21 MB
No deduping: 58.49 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Comment thread .github/actions/node/latest/action.yml Outdated
Co-authored-by: simon-id <simon.id@datadoghq.com>
@watson watson changed the title Fix Node.js version to v22.7 instead of "latest" Fix Node.js version to v22.6 instead of "latest" Aug 27, 2024
@watson
Copy link
Copy Markdown
Collaborator Author

watson commented Aug 27, 2024

Ups, I made an important typo in the PR title. I've fixed it now. The commit also has that typo, but once we squash merge it should be gone in the resulting commit in master

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Aug 27, 2024

Benchmarks

Benchmark execution time: 2024-08-27 12:15:53

Comparing candidate commit de71fab in PR branch watson/08-27-fix_node.js_version_to_v22.7_instead_of_latest_ with baseline commit 6fabbd0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 258 metrics, 8 unstable metrics.

@watson watson enabled auto-merge (squash) August 27, 2024 12:16
@watson watson merged commit 2ded936 into master Aug 27, 2024
@watson watson deleted the watson/08-27-fix_node.js_version_to_v22.7_instead_of_latest_ branch August 27, 2024 13:00
watson added a commit that referenced this pull request Aug 27, 2024
@watson
Copy link
Copy Markdown
Collaborator Author

watson commented Aug 28, 2024

I've opened a PR to revert this change once Node.js 22.8.0 is released: #4631

bengl pushed a commit that referenced this pull request Aug 29, 2024
This is a temporary fix until v22.8.0 is released due to a bug in
v22.7.0: nodejs/node#54518
@bengl bengl mentioned this pull request Aug 29, 2024
bengl pushed a commit that referenced this pull request Aug 29, 2024
This is a temporary fix until v22.8.0 is released due to a bug in
v22.7.0: nodejs/node#54518
@bengl bengl mentioned this pull request Aug 29, 2024
bengl pushed a commit that referenced this pull request Aug 30, 2024
This is a temporary fix until v22.8.0 is released due to a bug in
v22.7.0: nodejs/node#54518
bengl pushed a commit that referenced this pull request Aug 30, 2024
This is a temporary fix until v22.8.0 is released due to a bug in
v22.7.0: nodejs/node#54518
watson added a commit that referenced this pull request Sep 12, 2024
juan-fernandez pushed a commit that referenced this pull request Sep 30, 2024
juan-fernandez pushed a commit that referenced this pull request Sep 30, 2024
juan-fernandez pushed a commit that referenced this pull request Oct 1, 2024
juan-fernandez pushed a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants