wrap all callbacks in instrumentations with wrapFunction#4634
Merged
Conversation
Contributor
Overall package sizeSelf size: 6.98 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.0.1 | 15.59 MB | 15.6 MB | | @datadog/native-iast-taint-tracking | 3.1.0 | 12.27 MB | 12.28 MB | | @datadog/pprof | 5.3.0 | 9.85 MB | 10.22 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.4.1 | 2.14 MB | 2.23 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 2.0.0 | 898.77 kB | 1.3 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.8.1 | 71.67 kB | 785.15 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | lru-cache | 7.14.0 | 74.95 kB | 74.95 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.7 | 6.78 kB | 6.78 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2024-08-28 14:23:11 Comparing candidate commit 043923f in PR branch Found 0 performance improvements and 8 performance regressions! Performance is the same for 253 metrics, 5 unstable metrics. scenario:appsec-iast-no-vulnerability-control-18
scenario:plugin-dns-with-tracer-18
scenario:plugin-http-client-with-tracer-18
|
65c2f12 to
6807a88
Compare
Qard
previously approved these changes
Aug 27, 2024
These were the remaining areas with non-trivial code that might not be caught by try/catches when our code throws an exception. Adding `wrapFunction` adds that try/catch appropriately, but only when SSI is enabled. Otherwise these are all passthroughs. In the future, we may enable those try/catches at all times.
6807a88 to
fa0b8f3
Compare
simon-id
reviewed
Aug 28, 2024
simon-id
approved these changes
Aug 28, 2024
Collaborator
Author
|
The two failing are all-green and next.js, so I'll just go ahead and merge. |
bengl
added a commit
that referenced
this pull request
Aug 29, 2024
These were the remaining areas with non-trivial code that might not be caught by try/catches when our code throws an exception. Adding `wrapFunction` adds that try/catch appropriately, but only when SSI is enabled. Otherwise these are all passthroughs. In the future, we may enable those try/catches at all times.
Merged
bengl
added a commit
that referenced
this pull request
Aug 29, 2024
These were the remaining areas with non-trivial code that might not be caught by try/catches when our code throws an exception. Adding `wrapFunction` adds that try/catch appropriately, but only when SSI is enabled. Otherwise these are all passthroughs. In the future, we may enable those try/catches at all times.
Merged
bengl
added a commit
that referenced
this pull request
Aug 30, 2024
These were the remaining areas with non-trivial code that might not be caught by try/catches when our code throws an exception. Adding `wrapFunction` adds that try/catch appropriately, but only when SSI is enabled. Otherwise these are all passthroughs. In the future, we may enable those try/catches at all times.
bengl
added a commit
that referenced
this pull request
Aug 30, 2024
These were the remaining areas with non-trivial code that might not be caught by try/catches when our code throws an exception. Adding `wrapFunction` adds that try/catch appropriately, but only when SSI is enabled. Otherwise these are all passthroughs. In the future, we may enable those try/catches at all times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were the remaining areas with non-trivial code that might not be caught by try/catches when our code throws an exception. Adding
wrapFunctionadds that try/catch appropriately, but only when SSI is enabled. Otherwise these are all passthroughs. In the future, we may enable those try/catches at all times.I considered the following to be out of scope:
async_hooks.I may have missed some. It's an extremely difficult task to verify that all opportunities for throwing an exception are covered.