feat(tracing): AWS API Gateway Inferred Span Support#4837
Conversation
Overall package sizeSelf size: 7.97 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/native-appsec | 8.2.1 | 19.18 MB | 19.19 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
| const HTTP_URL = tags.HTTP_URL | ||
| const HTTP_METHOD = tags.HTTP_METHOD | ||
|
|
||
| const PROXY_HEADER_NAME = 'x-dd-proxy-name' |
There was a problem hiding this comment.
Was there an RFC for these header named? Seems like a shame they aren't combined into 1 header.
There was a problem hiding this comment.
This part is a bit subject to the AWS expectations for headers:
- https://docs.aws.amazon.com/apigateway/latest/developerguide/request-response-data-mappings.html
- https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-mapping-template-reference.html
I don't know if there's a way to list multiple keys at once so that part would require a bit more research.
There was a problem hiding this comment.
From our tests, it seems like it's not possible to combine these values from AWS into 1 header, so our hands are pretty much tied and we're stuck with using separate headers.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4837 +/- ##
===========================================
- Coverage 93.86% 72.34% -21.52%
===========================================
Files 107 327 +220
Lines 3373 14879 +11506
===========================================
+ Hits 3166 10764 +7598
- Misses 207 4115 +3908 ☔ View full report in Codecov by Sentry. |
* Add support for inferred spans to be created for proxies. Initially supports AWS API Gateway and creates a span when the required headers are attached on the received request. --------- Co-authored-by: wantsui <wan.tsui@datadoghq.com>
* Add support for inferred spans to be created for proxies. Initially supports AWS API Gateway and creates a span when the required headers are attached on the received request. --------- Co-authored-by: wantsui <wan.tsui@datadoghq.com>
* Add support for inferred spans to be created for proxies. Initially supports AWS API Gateway and creates a span when the required headers are attached on the received request. --------- Co-authored-by: wantsui <wan.tsui@datadoghq.com>
* Add support for inferred spans to be created for proxies. Initially supports AWS API Gateway and creates a span when the required headers are attached on the received request. --------- Co-authored-by: wantsui <wan.tsui@datadoghq.com>
What does this PR do?
Created inferred spans for AWS Api Gateway for web integrations if the received request has a specific header (see RFC). The headers will also contain info on the route, start time of the request in MS, method, etc.
AIDM-419
Motivation
Plugin Checklist
Additional Notes