Skip to content

Upgrade cross-spawn to v7.0.5 - patched ReDoS#4899

Merged
CarlesDD merged 1 commit intomasterfrom
ccapell/upgrade-cross-spawn
Nov 18, 2024
Merged

Upgrade cross-spawn to v7.0.5 - patched ReDoS#4899
CarlesDD merged 1 commit intomasterfrom
ccapell/upgrade-cross-spawn

Conversation

@CarlesDD
Copy link
Copy Markdown
Contributor

@CarlesDD CarlesDD commented Nov 18, 2024

What does this PR do?

Upgrade cross-spawn package to v7.0.5

Motivation

Patch a ReDoS vulnerability.
GH Advisory

Additional notes

cross-spawn is not a direct dependency, but a sub-dep of several packages.

$ yarn why cross-spawn -R                                      
yarn why v1.22.21
[1/4] 🤔  Why do we have the module "cross-spawn"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "cross-spawn@7.0.5"
info Reasons this module exists
   - "eslint" depends on it
   - Hoisted from "eslint#cross-spawn"
   - Hoisted from "nyc#foreground-child#cross-spawn"
   - Hoisted from "nyc#istanbul-lib-processinfo#cross-spawn"
info Disk size without dependencies: "60KB"
info Disk size with unique dependencies: "124KB"
info Disk size with transitive dependencies: "184KB"
info Number of shared dependencies: 4
✨  Done in 0.15s.

@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 8 MB
Deduped: 94.5 MB
No deduping: 94.84 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.5.0 | 2.51 MB | 2.65 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | msgpack-lite | 0.1.26 | 201.16 kB | 281.59 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | int64-buffer | 0.1.10 | 49.18 kB | 49.18 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | path-to-regexp | 0.1.10 | 6.38 kB | 6.38 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 18, 2024

Benchmarks

Benchmark execution time: 2024-11-18 11:41:10

Comparing candidate commit 6a56893 in PR branch ccapell/upgrade-cross-spawn with baseline commit bdbeb02 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 260 metrics, 6 unstable metrics.

@CarlesDD CarlesDD marked this pull request as ready for review November 18, 2024 11:43
@CarlesDD CarlesDD requested a review from a team as a code owner November 18, 2024 11:43
@CarlesDD CarlesDD merged commit 61c5a32 into master Nov 18, 2024
@CarlesDD CarlesDD deleted the ccapell/upgrade-cross-spawn branch November 18, 2024 12:10
@rochdev rochdev mentioned this pull request Nov 19, 2024
@rochdev rochdev mentioned this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants