Report stack trace in iast#5055
Merged
IlyasShabi merged 16 commits intomasterfrom Jan 23, 2025
Merged
Conversation
Contributor
Overall package sizeSelf size: 8.53 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BenchmarksBenchmark execution time: 2025-01-23 13:42:24 Comparing candidate commit a17f4d9 in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 901 metrics, 26 unstable metrics. scenario:plugin-graphql-with-depth-and-collapse-on-18
|
IlyasShabi
commented
Dec 30, 2024
IlyasShabi
force-pushed
the
iast-stack-trace
branch
2 times, most recently
from
d37649a to
325ba0d
Compare
IlyasShabi
force-pushed
the
iast-stack-trace
branch
from
325ba0d to
de09037
Compare
IlyasShabi
force-pushed
the
iast-stack-trace
branch
3 times, most recently
from
365d55b to
99410fb
Compare
IlyasShabi
force-pushed
the
iast-stack-trace
branch
from
99410fb to
a9f199c
Compare
uurien
reviewed
Jan 20, 2025
iunanua
reviewed
Jan 21, 2025
iunanua
reviewed
Jan 21, 2025
Contributor
|
LGTM 🎉 |
uurien
reviewed
Jan 23, 2025
iunanua
approved these changes
Jan 23, 2025
uurien
approved these changes
Jan 23, 2025
szegedi
pushed a commit
that referenced
this pull request
Jan 28, 2025
* Report stack trace in iast * fix stack trace tests * fix names * call site frames * fix path-line tests * use frames instead of call list * fix hardcoded-analyzers tests * clear tests * get original locations only if we can add vulnerability * add iast stacktrace variable * vulnerability reporter unit test with stack trace * maintain stack trace limit per request * dont report stack trace if we reach max by request * add use strict to utils test file
Merged
szegedi
pushed a commit
that referenced
this pull request
Jan 29, 2025
* Report stack trace in iast * fix stack trace tests * fix names * call site frames * fix path-line tests * use frames instead of call list * fix hardcoded-analyzers tests * clear tests * get original locations only if we can add vulnerability * add iast stacktrace variable * vulnerability reporter unit test with stack trace * maintain stack trace limit per request * dont report stack trace if we reach max by request * add use strict to utils test file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
APPSEC-53918
Add stack trace report to IAST events
Plugin Checklist
Additional Notes