Add more YAML verification by bengl · Pull Request #5151 · DataDog/dd-trace-js

bengl · 2025-01-23T19:29:09Z

Validate YAML files using actionlint
Check that tests in packages/datadog-instrumentations/tests/ are actually run.
Check that tests in packages/datadog-plugin-*/tests/ are actually run.
Ensure all tests have the same triggers.

github-actions · 2025-01-23T19:29:59Z

Overall package size

Self size: 8.54 MB
Deduped: 94.94 MB
No deduping: 95.45 MB

Dependency sizes

| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.5.0 | 9.8 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

_{🤖 This report was automatically generated by heaviest-objects-in-the-universe}

pr-commenter · 2025-01-23T19:39:37Z

Benchmarks

Benchmark execution time: 2025-01-27 20:59:34

Comparing candidate commit baff787 in PR branch bengl/more-yaml-verification with baseline commit f534ae0 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 911 metrics, 21 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

🟩 max_rss_usage [-118.692MB; -67.608MB] or [-12.393%; -7.059%]

codecov · 2025-01-23T20:12:14Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.05%. Comparing base (29c26b0) to head (baff787).
Report is 5 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5151      +/-   ##
==========================================
- Coverage   90.38%   81.05%   -9.33%     
==========================================
  Files         151      477     +326     
  Lines        5198    21307   +16109     
==========================================
+ Hits         4698    17270   +12572     
- Misses        500     4037    +3537

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

datadog-datadog-prod-us1 · 2025-01-23T21:44:46Z

🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

simon-id · 2025-01-24T14:00:29Z

few comments otherwise LGTM

* Validate YAML files using actionlint * Check that tests in packages/datadog-instrumentations/tests/ are actually run. * Ensure all tests have the same triggers.

It was testing very specific output, when really it should have just looked for its own output.

watson · 2025-01-27T20:04:30Z

      - uses: ./.github/actions/install
      - run: node scripts/verify-ci-config.js
+
+  actionlint:


Wouldn't it be prudent to put this in its own yaml file, so that the risk of a syntax error in that yaml file was as low as possible? That way a syntax error in project.yml would be detectable

Sure I can do that.

datadog-datadog-prod-us1 · 2025-01-27T20:35:19Z

    steps:
      - uses: actions/checkout@v4
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

datadog-datadog-prod-us1 · 2025-01-27T20:35:19Z

      - uses: ./.github/actions/node/latest
      - run: yarn test:appsec:plugins:ci
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v5


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

datadog-datadog-prod-us1 · 2025-01-27T20:35:19Z

      - run: yarn test:llmobs:plugins:ci
        shell: bash
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v5


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

datadog-datadog-prod-us1 · 2025-01-27T20:35:20Z

        with:
          suffix: plugins-${{ github.job }}-${{ matrix.node-version }}
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v5


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

datadog-datadog-prod-us1 · 2025-01-27T20:48:48Z

      - uses: ./.github/actions/node/20
      - run: yarn test:appsec:plugins:ci
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v5


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

datadog-datadog-prod-us1 · 2025-01-27T20:48:48Z

      - run: yarn test:llmobs:plugins:ci
        shell: bash
-      - uses: codecov/codecov-action@v3
+      - uses: codecov/codecov-action@v5


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

datadog-datadog-prod-us1 · 2025-01-27T20:48:49Z

+  actionlint:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

datadog-datadog-prod-us1 · 2025-01-27T20:48:49Z

      - uses: ./.github/actions/node/setup
      - uses: ./.github/actions/install
-      - uses: actions/setup-node@v3
+      - uses: actions/setup-node@v4


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

datadog-datadog-prod-us1 · 2025-01-27T20:48:49Z

+          npm init -y
+      - name: actionlint
+        id: actionlint
+        uses: raven-actions/actionlint@v2


🟠 Code Vulnerability

Workflow depends on a GitHub actions pinned by tag (...read more)

* Validate YAML files using actionlint * Check that tests in packages/datadog-instrumentations/tests/ are actually run. * Check that tests in packages/datadog-plugin-*/tests/ are actually run. * Ensure all tests have the same triggers.

bengl requested review from a team as code owners January 23, 2025 19:29

bengl added the semver-patch label Jan 23, 2025

datadog-datadog-prod-us1 Bot reviewed Jan 23, 2025

View reviewed changes

Comment thread .github/workflows/instrumentations.yml Outdated

Comment thread .github/workflows/project.yml Outdated

bengl force-pushed the bengl/more-yaml-verification branch 2 times, most recently from 9712db5 to 75b9f4b Compare January 23, 2025 20:09

bengl requested a review from a team as a code owner January 23, 2025 20:20

datadog-datadog-prod-us1 Bot reviewed Jan 23, 2025

View reviewed changes

bengl force-pushed the bengl/more-yaml-verification branch from 83cc0ba to 52f0f5a Compare January 23, 2025 21:45

simon-id reviewed Jan 24, 2025

View reviewed changes

Comment thread packages/datadog-instrumentations/test/multer.spec.js Outdated

simon-id reviewed Jan 24, 2025

View reviewed changes

Comment thread scripts/verify-ci-config.js Outdated

simon-id reviewed Jan 24, 2025

View reviewed changes

Comment thread scripts/verify-ci-config.js Outdated

simon-id mentioned this pull request Jan 26, 2025

Automatic userID tracking and blocking #4670

Merged

bengl force-pushed the bengl/more-yaml-verification branch from 6d185b9 to 15d94b6 Compare January 27, 2025 16:46

bengl requested a review from a team as a code owner January 27, 2025 16:46

datadog-datadog-prod-us1 Bot reviewed Jan 27, 2025

View reviewed changes

Comment thread .github/workflows/plugins.yml Outdated

Comment thread .github/workflows/release-latest.yml Outdated

bengl added 7 commits January 27, 2025 14:44

Add more YAML verification

c546133

* Validate YAML files using actionlint * Check that tests in packages/datadog-instrumentations/tests/ are actually run. * Ensure all tests have the same triggers.

fix check_require_cache test

279f8bb

It was testing very specific output, when really it should have just looked for its own output.

use devDep express in multer test

f48836c

fix fs tests (ish)

3f52bb0

Check that all plugin test files are run

cf768e7

fix actionlint

61fe321

fresh package.json for actionlint

6a44306

bengl added 2 commits January 27, 2025 14:45

lint all the actions

c36da2e

disable shellcheck

14291db

bengl force-pushed the bengl/more-yaml-verification branch from cfe88a6 to 14291db Compare January 27, 2025 19:45

datadog-datadog-prod-us1 Bot reviewed Jan 27, 2025

View reviewed changes

Comment thread .github/workflows/appsec.yml

Comment thread .github/workflows/plugins.yml

Comment thread .github/workflows/project.yml

Comment thread .github/workflows/tracing.yml

Comment thread .github/workflows/profiling.yml

watson reviewed Jan 27, 2025

View reviewed changes

fix multer test

c5d0e62

datadog-datadog-prod-us1 Bot reviewed Jan 27, 2025

View reviewed changes

actionlint in its own workflow

baff787

datadog-datadog-prod-us1 Bot reviewed Jan 27, 2025

View reviewed changes

simon-id approved these changes Jan 28, 2025

View reviewed changes

bengl merged commit 4f22cf7 into master Jan 28, 2025

bengl deleted the bengl/more-yaml-verification branch January 28, 2025 13:45

szegedi mentioned this pull request Jan 30, 2025

v5.33.1 proposal #5175

Merged

Conversation

bengl commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overall package size

Uh oh!

pr-commenter Bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

scenario:plugin-graphql-with-depth-and-collapse-on-18

Uh oh!

codecov Bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

datadog-datadog-prod-us1 Bot Jan 23, 2025

Choose a reason for hiding this comment

🟠 Code Vulnerability

Uh oh!

Uh oh!

Uh oh!

Uh oh!

simon-id commented Jan 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

watson Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

bengl Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

bengl Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

datadog-datadog-prod-us1 Bot Jan 27, 2025

Choose a reason for hiding this comment

🟠 Code Vulnerability

Uh oh!

datadog-datadog-prod-us1 Bot Jan 27, 2025

Choose a reason for hiding this comment

🟠 Code Vulnerability

Uh oh!

datadog-datadog-prod-us1 Bot Jan 27, 2025

Choose a reason for hiding this comment

🟠 Code Vulnerability

Uh oh!

datadog-datadog-prod-us1 Bot Jan 27, 2025

Choose a reason for hiding this comment

🟠 Code Vulnerability

Uh oh!

datadog-datadog-prod-us1 Bot Jan 27, 2025

Choose a reason for hiding this comment

🟠 Code Vulnerability

Uh oh!

datadog-datadog-prod-us1 Bot Jan 27, 2025

Choose a reason for hiding this comment

🟠 Code Vulnerability

Uh oh!

datadog-datadog-prod-us1 Bot Jan 27, 2025

Choose a reason for hiding this comment

bengl commented Jan 23, 2025 •

edited

Loading

github-actions Bot commented Jan 23, 2025 •

edited

Loading

pr-commenter Bot commented Jan 23, 2025 •

edited

Loading

codecov Bot commented Jan 23, 2025 •

edited

Loading