Skip to content

Add stack id in location as a string#5250

Merged
IlyasShabi merged 6 commits intomasterfrom
stackid-location
Feb 25, 2025
Merged

Add stack id in location as a string#5250
IlyasShabi merged 6 commits intomasterfrom
stackid-location

Conversation

@IlyasShabi
Copy link
Copy Markdown
Contributor

What does this PR do?

Add stack id in location as a string

Motivation

Plugin Checklist

Additional Notes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 12, 2025

Overall package size

Self size: 8.77 MB
Deduped: 94.97 MB
No deduping: 95.49 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.5.1 | 9.79 MB | 10.17 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 835.4 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Feb 12, 2025

Datadog Report

Branch report: stackid-location
Commit report: 4d0ba45
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 662 Passed, 0 Skipped, 7m 55.4s Total Time

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (fd42515) to head (6acede2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5250   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files         489      489           
  Lines       21860    21860           
=======================================
  Hits        17699    17699           
  Misses       4161     4161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 14, 2025

Benchmarks

Benchmark execution time: 2025-02-25 09:19:50

Comparing candidate commit 6acede2 in PR branch stackid-location with baseline commit fd42515 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 919 metrics, 14 unstable metrics.

@IlyasShabi IlyasShabi marked this pull request as ready for review February 17, 2025 13:15
@IlyasShabi IlyasShabi requested a review from a team as a code owner February 17, 2025 13:15
@IlyasShabi IlyasShabi merged commit 996e8fb into master Feb 25, 2025
@IlyasShabi IlyasShabi deleted the stackid-location branch February 25, 2025 13:16
watson pushed a commit that referenced this pull request Feb 27, 2025
* Add stack id in location as a string

* get stackId  from location

* remove stack id from format vuln
@watson watson mentioned this pull request Feb 27, 2025
watson pushed a commit that referenced this pull request Feb 27, 2025
* Add stack id in location as a string

* get stackId  from location

* remove stack id from format vuln
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants