Skip to content

Update rewriter to the new renamed wasm-js-rewriter 3.1.0#5472

Merged
uurien merged 7 commits intomasterfrom
ugaitz/update-rewriter
Apr 1, 2025
Merged

Update rewriter to the new renamed wasm-js-rewriter 3.1.0#5472
uurien merged 7 commits intomasterfrom
ugaitz/update-rewriter

Conversation

@uurien
Copy link
Copy Markdown
Collaborator

@uurien uurien commented Mar 24, 2025

What does this PR do?

Updates the rewriter

Motivation

Fix a bug in iast with optional chaining

Plugin Checklist

Additional Notes

APPSEC-57079

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 24, 2025

Overall package size

Self size: 9.14 MB
Deduped: 101.45 MB
No deduping: 101.97 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 3.1.0 | 2.37 MB | 2.52 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.18%. Comparing base (b4b2969) to head (760c2bf).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5472   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files         512      512           
  Lines       23156    23156           
=======================================
  Hits        18337    18337           
  Misses       4819     4819           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Mar 24, 2025

Datadog Report

Branch report: ugaitz/update-rewriter
Commit report: 0f3934f
Test service: dd-trace-js-integration-tests

❌ 1 Failed (0 Known Flaky), 917 Passed, 0 Skipped, 14m 23.48s Total Time
❄️ 1 New Flaky

❌ Failed Tests (1)

  • selenium 4.11.0 does not crash when used outside a known test framework - integration-tests/selenium/selenium.spec.js - Details

    Expand for error
     Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/integration-tests/selenium/selenium.spec.js)
    

New Flaky Tests (1)

  • cypress@6.7.0 commonJS logs a warning if using a deprecated version of cypress - integration-tests/cypress/cypress.spec.js - Last Failure

    Expand for error
     Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/dd-trace-js/dd-trace-js/integration-tests/cypress/cypress.spec.js)
    

@uurien uurien force-pushed the ugaitz/update-rewriter branch 2 times, most recently from 51e8aa7 to aed75d9 Compare March 25, 2025 14:22
@uurien uurien marked this pull request as ready for review March 26, 2025 11:34
@uurien uurien requested review from a team as code owners March 26, 2025 11:34
@uurien uurien enabled auto-merge (squash) March 26, 2025 14:52
@uurien uurien disabled auto-merge March 26, 2025 14:53
@uurien uurien changed the title Update rewriter to the new renamed wasm-js-rewriter 3.0.0 Update rewriter to the new renamed wasm-js-rewriter 3.1.0 Mar 31, 2025
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 31, 2025

Benchmarks

Benchmark execution time: 2025-04-01 15:16:56

Comparing candidate commit 760c2bf in PR branch ugaitz/update-rewriter with baseline commit b4b2969 in branch master.

Found 0 performance improvements and 32 performance regressions! Performance is the same for 913 metrics, 18 unstable metrics.

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-18

  • 🟥 cpu_user_time [+341.358ms; +361.281ms] or [+25.955%; +27.470%]
  • 🟥 execution_time [+377.533ms; +405.785ms] or [+25.839%; +27.772%]
  • 🟥 max_rss_usage [+11.898MB; +13.602MB] or [+10.209%; +11.672%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20

  • 🟥 cpu_user_time [+326.260ms; +357.932ms] or [+24.096%; +26.435%]
  • 🟥 execution_time [+370.076ms; +404.090ms] or [+24.838%; +27.121%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-22

  • 🟥 cpu_user_time [+274.090ms; +294.279ms] or [+26.080%; +28.001%]
  • 🟥 execution_time [+298.696ms; +326.033ms] or [+24.381%; +26.612%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-18

  • 🟥 cpu_user_time [+337.314ms; +361.493ms] or [+26.424%; +28.318%]
  • 🟥 execution_time [+381.073ms; +406.946ms] or [+26.783%; +28.601%]
  • 🟥 max_rss_usage [+12.293MB; +14.447MB] or [+10.523%; +12.367%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

  • 🟥 cpu_user_time [+340.412ms; +364.709ms] or [+25.977%; +27.831%]
  • 🟥 execution_time [+383.547ms; +410.355ms] or [+26.416%; +28.262%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-22

  • 🟥 cpu_user_time [+263.167ms; +281.484ms] or [+25.722%; +27.513%]
  • 🟥 execution_time [+299.556ms; +323.967ms] or [+25.029%; +27.069%]

scenario:appsec-iast-startup-time-iast-enabled-18

  • 🟥 cpu_user_time [+289.859ms; +310.874ms] or [+16.498%; +17.694%]
  • 🟥 execution_time [+330.199ms; +350.609ms] or [+16.937%; +17.984%]

scenario:appsec-iast-startup-time-iast-enabled-20

  • 🟥 cpu_user_time [+332.040ms; +356.794ms] or [+18.317%; +19.683%]
  • 🟥 execution_time [+366.246ms; +395.650ms] or [+17.670%; +19.089%]

scenario:appsec-iast-startup-time-iast-enabled-22

  • 🟥 cpu_user_time [+250.324ms; +275.291ms] or [+18.349%; +20.179%]
  • 🟥 execution_time [+291.917ms; +313.049ms] or [+17.962%; +19.262%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-18

  • 🟥 cpu_user_time [+271.430ms; +325.087ms] or [+15.123%; +18.112%]
  • 🟥 execution_time [+297.667ms; +400.915ms] or [+11.137%; +14.999%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-20

  • 🟥 cpu_user_time [+299.787ms; +348.291ms] or [+16.844%; +19.570%]
  • 🟥 execution_time [+336.408ms; +415.730ms] or [+14.264%; +17.628%]

scenario:appsec-iast-with-vulnerability-iast-enabled-always-active-22

  • 🟥 cpu_user_time [+256.563ms; +300.152ms] or [+17.657%; +20.657%]
  • 🟥 execution_time [+288.663ms; +348.509ms] or [+14.199%; +17.143%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-18

  • 🟥 cpu_user_time [+279.749ms; +320.356ms] or [+16.773%; +19.208%]
  • 🟥 execution_time [+295.602ms; +390.927ms] or [+12.041%; +15.924%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-20

  • 🟥 cpu_user_time [+294.431ms; +334.632ms] or [+17.444%; +19.826%]
  • 🟥 execution_time [+348.096ms; +412.028ms] or [+15.902%; +18.822%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-22

  • 🟥 cpu_user_time [+247.856ms; +290.511ms] or [+18.878%; +22.127%]
  • 🟥 execution_time [+295.782ms; +358.663ms] or [+16.384%; +19.867%]

@uurien uurien marked this pull request as draft March 31, 2025 14:13
@uurien uurien force-pushed the ugaitz/update-rewriter branch 2 times, most recently from 54803a8 to e72d6b2 Compare March 31, 2025 19:15
@uurien uurien changed the title Update rewriter to the new renamed wasm-js-rewriter 3.1.0 Update rewriter to the new renamed wasm-js-rewriter 3.0.0 Apr 1, 2025
BridgeAR
BridgeAR previously approved these changes Apr 1, 2025
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed in Slack, it currently seems best to merge the new library with the bigger size and to resolve the file later.

@uurien uurien force-pushed the ugaitz/update-rewriter branch from e2fcae8 to d4b3651 Compare April 1, 2025 14:35
@uurien uurien changed the title Update rewriter to the new renamed wasm-js-rewriter 3.0.0 Update rewriter to the new renamed wasm-js-rewriter 3.1.0 Apr 1, 2025
@uurien uurien marked this pull request as ready for review April 1, 2025 18:00
@uurien uurien merged commit 8e21dd1 into master Apr 1, 2025
424 of 426 checks passed
@uurien uurien deleted the ugaitz/update-rewriter branch April 1, 2025 19:04
wconti27 pushed a commit that referenced this pull request Apr 8, 2025
* Update rewriter to the new renamed wasm-js-rewriter 3.0.0

* Rename requires

* Rename pending @datadog/native-iast-rewriter references

* Update to 3.1.0

* Use branch

* Set 3.0.0 version again

* 3.1.0 again
@wconti27 wconti27 mentioned this pull request Apr 8, 2025
wconti27 pushed a commit that referenced this pull request Apr 9, 2025
* Update rewriter to the new renamed wasm-js-rewriter 3.0.0

* Rename requires

* Rename pending @datadog/native-iast-rewriter references

* Update to 3.1.0

* Use branch

* Set 3.0.0 version again

* 3.1.0 again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants