Skip to content

Remove unused code in router instrumentation code#5478

Merged
BridgeAR merged 1 commit intomasterfrom
watson/remove-dead-code
Mar 28, 2025
Merged

Remove unused code in router instrumentation code#5478
BridgeAR merged 1 commit intomasterfrom
watson/remove-dead-code

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Mar 25, 2025

What does this PR do?

Remove _datadog_orig property from wrapped router handle object. The property was never used for anything.

Motivation

Cleaner code is good code and modifying an object creates a new hidden class which is bad for performance.

Plugin Checklist

Additional Notes

Copy link
Copy Markdown
Collaborator Author

watson commented Mar 25, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson force-pushed the watson/remove-dead-code branch from ea4fc2a to bcf9dec Compare March 25, 2025 08:10
@watson watson self-assigned this Mar 25, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 25, 2025

Overall package size

Self size: 9 MB
Deduped: 101.53 MB
No deduping: 102.04 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (fac8988) to head (bcf9dec).
Report is 21 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5478       +/-   ##
===========================================
+ Coverage   79.58%   93.60%   +14.01%     
===========================================
  Files         510      112      -398     
  Lines       22923     3564    -19359     
===========================================
- Hits        18244     3336    -14908     
+ Misses       4679      228     -4451     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 25, 2025

Benchmarks

Benchmark execution time: 2025-03-25 08:18:10

Comparing candidate commit bcf9dec in PR branch watson/remove-dead-code with baseline commit fac8988 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 916 metrics, 17 unstable metrics.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

Datadog Report

Branch report: watson/remove-dead-code
Commit report: 5e7701d
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 799 Passed, 0 Skipped, 15m 32.56s Total Time

@watson watson marked this pull request as ready for review March 25, 2025 08:23
@watson watson requested review from a team as code owners March 25, 2025 08:23
Copy link
Copy Markdown
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I just checked that the test case is still passing that this was about.

@BridgeAR BridgeAR merged commit a029cac into master Mar 28, 2025
432 checks passed
@BridgeAR BridgeAR deleted the watson/remove-dead-code branch March 28, 2025 18:58
@wconti27 wconti27 mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants