Skip to content

chore: add tracing macrobenchmark with runtime metrics enabled#5485

Merged
BridgeAR merged 1 commit intomasterfrom
zach.montoya/add-runtime-metrics-macrobenchmark
Mar 28, 2025
Merged

chore: add tracing macrobenchmark with runtime metrics enabled#5485
BridgeAR merged 1 commit intomasterfrom
zach.montoya/add-runtime-metrics-macrobenchmark

Conversation

@zacharycmontoya
Copy link
Copy Markdown
Contributor

What does this PR do?

Adds another recurring macrobenchmark job to run tracing with runtime metrics enabled.

Motivation

We're investigating enabling runtime metrics by default, so this recurring job will help validate that the feature does not incur significant overhead for tracing users.

Additional Notes

@zacharycmontoya zacharycmontoya requested a review from a team as a code owner March 25, 2025 22:06
@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.11 MB
Deduped: 101.64 MB
No deduping: 102.15 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.21%. Comparing base (1662072) to head (43fffd6).
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5485   +/-   ##
=======================================
  Coverage   79.21%   79.21%           
=======================================
  Files         512      512           
  Lines       23089    23089           
=======================================
  Hits        18291    18291           
  Misses       4798     4798           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

Datadog Report

Branch report: zach.montoya/add-runtime-metrics-macrobenchmark
Commit report: f24bd6a
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 920 Passed, 0 Skipped, 10m 4.06s Total Time

Copy link
Copy Markdown
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is LGTM, I just don't yet know how these benchmarks work and why the pipeline failed.

Do you mind explaining it to me? That is likely faster than me having to go through everything on my own :)

@zacharycmontoya
Copy link
Copy Markdown
Contributor Author

The issue with the CI was apparently a race condition between a job in the benchmarks stage and a job in the benchmarks-pr-comment stage. After manually re-running the affected benchmark job and then the check-big-regressions, this was resolved.

@BridgeAR BridgeAR merged commit 4d9b64f into master Mar 28, 2025
432 of 433 checks passed
@BridgeAR BridgeAR deleted the zach.montoya/add-runtime-metrics-macrobenchmark branch March 28, 2025 18:48
@wconti27 wconti27 mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants