Skip to content

fix user tracking tests#5497

Merged
IlyasShabi merged 1 commit intomasterfrom
ishabi/appsec-tests
Mar 28, 2025
Merged

fix user tracking tests#5497
IlyasShabi merged 1 commit intomasterfrom
ishabi/appsec-tests

Conversation

@IlyasShabi
Copy link
Copy Markdown
Contributor

@IlyasShabi IlyasShabi commented Mar 27, 2025

What does this PR do?

APPSEC-56955

  • Separating unit tests from integration tests
  • Unify the way we call proxyquire
  • Fix user_tracking test

Motivation

Plugin Checklist

Additional Notes

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.26%. Comparing base (762e2cf) to head (c8832bb).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5497      +/-   ##
==========================================
- Coverage   79.27%   79.26%   -0.01%     
==========================================
  Files         513      513              
  Lines       23184    23183       -1     
==========================================
- Hits        18379    18377       -2     
- Misses       4805     4806       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 27, 2025

Benchmarks

Benchmark execution time: 2025-03-27 17:24:52

Comparing candidate commit c8832bb in PR branch ishabi/appsec-tests with baseline commit 762e2cf in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 945 metrics, 18 unstable metrics.

@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.11 MB
Deduped: 101.64 MB
No deduping: 102.16 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Mar 27, 2025

Datadog Report

Branch report: ishabi/appsec-tests
Commit report: 3992ae4
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 923 Passed, 0 Skipped, 10m 13.76s Total Time

@IlyasShabi IlyasShabi marked this pull request as ready for review March 28, 2025 07:46
@IlyasShabi IlyasShabi requested a review from a team as a code owner March 28, 2025 07:46
@IlyasShabi IlyasShabi merged commit a432a17 into master Mar 28, 2025
434 of 435 checks passed
@IlyasShabi IlyasShabi deleted the ishabi/appsec-tests branch March 28, 2025 13:41
wconti27 pushed a commit that referenced this pull request Apr 8, 2025
@wconti27 wconti27 mentioned this pull request Apr 8, 2025
wconti27 pushed a commit that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants