Skip to content

increase appsec next test start timeout to 5 minutes#5506

Merged
rochdev merged 1 commit intomasterfrom
appsec-next-start-300-timeout
Apr 1, 2025
Merged

increase appsec next test start timeout to 5 minutes#5506
rochdev merged 1 commit intomasterfrom
appsec-next-start-300-timeout

Conversation

@rochdev
Copy link
Copy Markdown
Member

@rochdev rochdev commented Mar 31, 2025

What does this PR do?

Increase AppSec next test start timeout to 5 minutes.

Motivation

Test is flaky and sometimes times out. I'm not sure why, but given Next is involved, I just went with a timeout increase as Next is extremely slow. If that doesn't work, then there might be another issue at play (like done() not being called), but since I can find occurrences of the test taking ~30 seconds, I think it's very likely the timeout.

@rochdev rochdev marked this pull request as ready for review March 31, 2025 17:14
@rochdev rochdev requested a review from a team as a code owner March 31, 2025 17:14
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 31, 2025

Overall package size

Self size: 9.14 MB
Deduped: 101.67 MB
No deduping: 102.19 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.18%. Comparing base (b4b2969) to head (35e0932).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5506   +/-   ##
=======================================
  Coverage   79.18%   79.18%           
=======================================
  Files         512      512           
  Lines       23156    23156           
=======================================
  Hits        18337    18337           
  Misses       4819     4819           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Mar 31, 2025

Datadog Report

Branch report: appsec-next-start-300-timeout
Commit report: 6821b9d
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 924 Passed, 0 Skipped, 14m 56.21s Total Time

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 1, 2025

Benchmarks

Benchmark execution time: 2025-04-01 14:37:09

Comparing candidate commit 35e0932 in PR branch appsec-next-start-300-timeout with baseline commit b4b2969 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 946 metrics, 17 unstable metrics.

@rochdev rochdev force-pushed the appsec-next-start-300-timeout branch from 44175c2 to 35e0932 Compare April 1, 2025 14:28
@rochdev rochdev enabled auto-merge (squash) April 1, 2025 15:21
@rochdev rochdev merged commit 658800a into master Apr 1, 2025
427 checks passed
@rochdev rochdev deleted the appsec-next-start-300-timeout branch April 1, 2025 15:24
@wconti27 wconti27 mentioned this pull request Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants