Skip to content

[DI] Fix isDefined support in probe conditions#5521

Merged
BridgeAR merged 1 commit intomasterfrom
watson/DEBUG-2626/probe-condition-isdefined
Apr 2, 2025
Merged

[DI] Fix isDefined support in probe conditions#5521
BridgeAR merged 1 commit intomasterfrom
watson/DEBUG-2626/probe-condition-isdefined

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Apr 2, 2025

What does this PR do?

Fix implementation of isDefined as the backend will never send it a string, but instead an AST which should be compiled. So the value of isDefined should always be compiled similar to most other operators.

Motivation

Plugin Checklist

Additional Notes

@watson watson requested review from a team as code owners April 2, 2025 12:00
@watson watson self-assigned this Apr 2, 2025
Copy link
Copy Markdown
Collaborator Author

watson commented Apr 2, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson added semver-patch debugger Dynamic Instrumentation & Live Debugger labels Apr 2, 2025
@watson watson requested a review from shatzi April 2, 2025 12:01
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2025

Overall package size

Self size: 9.19 MB
Deduped: 101.5 MB
No deduping: 102.02 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 3.1.0 | 2.37 MB | 2.52 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.25%. Comparing base (b94052c) to head (06001bd).
Report is 123 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5521      +/-   ##
==========================================
+ Coverage   79.18%   79.25%   +0.06%     
==========================================
  Files         512      513       +1     
  Lines       23158    23230      +72     
==========================================
+ Hits        18338    18410      +72     
  Misses       4820     4820              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

Datadog Report

Branch report: watson/DEBUG-2626/probe-condition-isdefined
Commit report: f592ff8
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 928 Passed, 0 Skipped, 14m 39.61s Total Time

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 2, 2025

Benchmarks

Benchmark execution time: 2025-04-02 12:14:39

Comparing candidate commit 06001bd in PR branch watson/DEBUG-2626/probe-condition-isdefined with baseline commit b94052c in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 943 metrics, 20 unstable metrics.

@BridgeAR BridgeAR merged commit 61f8a84 into master Apr 2, 2025
429 checks passed
@BridgeAR BridgeAR deleted the watson/DEBUG-2626/probe-condition-isdefined branch April 2, 2025 14:22
@wconti27 wconti27 mentioned this pull request Apr 8, 2025
@watson watson added the bug Something isn't working label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working debugger Dynamic Instrumentation & Live Debugger semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants