Skip to content

[DI] Condtions: Allow using len to count keys in objects#5542

Merged
watson merged 2 commits intomasterfrom
watson/DEBUG-2626/probe-condition-len-fix
Apr 7, 2025
Merged

[DI] Condtions: Allow using len to count keys in objects#5542
watson merged 2 commits intomasterfrom
watson/DEBUG-2626/probe-condition-len-fix

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Apr 7, 2025

What does this PR do?

As the title says

Motivation

Otherwise there would be no way to get the number of keys in an object.

Plugin Checklist

Additional Notes

@watson watson requested review from a team as code owners April 7, 2025 11:48
@watson watson self-assigned this Apr 7, 2025
@watson watson added semver-patch debugger Dynamic Instrumentation & Live Debugger labels Apr 7, 2025
Copy link
Copy Markdown
Collaborator Author

watson commented Apr 7, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2025

Overall package size

Self size: 9.24 MB
Deduped: 101.55 MB
No deduping: 102.06 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/wasm-js-rewriter | 3.1.0 | 2.37 MB | 2.52 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.26%. Comparing base (1db78a6) to head (0c0901d).
Report is 111 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5542      +/-   ##
==========================================
- Coverage   79.33%   79.26%   -0.07%     
==========================================
  Files         513      512       -1     
  Lines       23248    23176      -72     
==========================================
- Hits        18443    18371      -72     
  Misses       4805     4805              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watson watson requested a review from shatzi April 7, 2025 11:52
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Apr 7, 2025

Datadog Report

Branch report: watson/DEBUG-2626/probe-condition-len-fix
Commit report: 05d33de
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 925 Passed, 0 Skipped, 11m 49.57s Total Time

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Apr 7, 2025

Benchmarks

Benchmark execution time: 2025-04-07 14:36:38

Comparing candidate commit 0c0901d in PR branch watson/DEBUG-2626/probe-condition-len-fix with baseline commit 1db78a6 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 943 metrics, 20 unstable metrics.

tylfin
tylfin previously approved these changes Apr 7, 2025
shatzi
shatzi previously approved these changes Apr 7, 2025
Comment thread packages/dd-trace/src/debugger/devtools_client/condition.js
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests to see we have Len for normal objects?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I found it from system tests failing, but obviously there should be some in-repo tests as well 👍

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed 👍

@watson watson dismissed stale reviews from shatzi and tylfin via 0c0901d April 7, 2025 14:27
@watson watson enabled auto-merge (squash) April 7, 2025 14:32
@watson watson merged commit af40a87 into master Apr 7, 2025
386 of 425 checks passed
@watson watson deleted the watson/DEBUG-2626/probe-condition-len-fix branch April 7, 2025 14:39
@wconti27 wconti27 mentioned this pull request Apr 8, 2025
@watson watson added the bug Something isn't working label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working debugger Dynamic Instrumentation & Live Debugger semver-patch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants