Skip to content

Do not extract baggage when config.tracePropagationBehaviorExtract is 'ignore'#5860

Merged
ida613 merged 2 commits intomasterfrom
ida613/tracePropagationBehaviorExtract-ignore-baggage
Jun 9, 2025
Merged

Do not extract baggage when config.tracePropagationBehaviorExtract is 'ignore'#5860
ida613 merged 2 commits intomasterfrom
ida613/tracePropagationBehaviorExtract-ignore-baggage

Conversation

@ida613
Copy link
Copy Markdown
Collaborator

@ida613 ida613 commented Jun 9, 2025

What does this PR do?

When config.tracePropagationBehaviorExtract=ignore, we ignore any incoming trace context headers, including baggage

Motivation

Plugin Checklist

Additional Notes

@ida613 ida613 changed the title Do not extract baggage when config.tracePropagationBehaviorExtract === 'ignore' Do not extract baggage when config.tracePropagationBehaviorExtract is 'ignore' Jun 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 9, 2025

Overall package size

Self size: 9.62 MB
Deduped: 104.56 MB
No deduping: 105.08 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (3c8fe63) to head (3d089e6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5860      +/-   ##
==========================================
+ Coverage   80.71%   80.75%   +0.03%     
==========================================
  Files         464      464              
  Lines       19875    19875              
==========================================
+ Hits        16043    16050       +7     
+ Misses       3832     3825       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ida613 ida613 marked this pull request as ready for review June 9, 2025 21:23
@ida613 ida613 requested a review from a team as a code owner June 9, 2025 21:23
@ida613 ida613 requested a review from zacharycmontoya June 9, 2025 21:23
@datadog-datadog-prod-us1
Copy link
Copy Markdown

Datadog Report

Branch report: ida613/tracePropagationBehaviorExtract-ignore-baggage
Commit report: 98a393f
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1258 Passed, 0 Skipped, 20m 38.16s Total Time

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 9, 2025

Benchmarks

Benchmark execution time: 2025-06-09 21:28:39

Comparing candidate commit 3d089e6 in PR branch ida613/tracePropagationBehaviorExtract-ignore-baggage with baseline commit 3c8fe63 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1273 metrics, 50 unstable metrics.

@ida613 ida613 merged commit 994323d into master Jun 9, 2025
511 of 512 checks passed
@ida613 ida613 deleted the ida613/tracePropagationBehaviorExtract-ignore-baggage branch June 9, 2025 21:32
ghost pushed a commit that referenced this pull request Jun 10, 2025
@ghost ghost mentioned this pull request Jun 10, 2025
ghost pushed a commit that referenced this pull request Jun 12, 2025
@ghost ghost mentioned this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants