Skip to content

test: speed up DI integration tests#5863

Merged
BridgeAR merged 1 commit intomasterfrom
watson/speed-up-di-tests
Jun 10, 2025
Merged

test: speed up DI integration tests#5863
BridgeAR merged 1 commit intomasterfrom
watson/speed-up-di-tests

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Jun 10, 2025

What does this PR do?

Increase the RC poll interval in the Dynamic Instrumentation integration tests, so that they run faster.

Debugger CI run performance improvement:

Before After
image image

Motivation

Plugin Checklist

Additional Notes

@watson watson self-assigned this Jun 10, 2025
Copy link
Copy Markdown
Collaborator Author

watson commented Jun 10, 2025

@watson watson mentioned this pull request Jun 10, 2025
7 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 10, 2025

Overall package size

Self size: 9.63 MB
Deduped: 104.57 MB
No deduping: 105.09 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (7e78aaa) to head (e7fd29a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5863   +/-   ##
=======================================
  Coverage   80.75%   80.75%           
=======================================
  Files         464      464           
  Lines       19910    19910           
=======================================
  Hits        16078    16078           
  Misses       3832     3832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 10, 2025

Benchmarks

Benchmark execution time: 2025-06-10 10:48:00

Comparing candidate commit de9c62b32ebbded151f2337e620a581faffd07f3 in PR branch watson/speed-up-di-tests with baseline commit 66b8e13 in branch watson/DEBUG-4006/support-changing-upload-interval.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1276 metrics, 47 unstable metrics.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented Jun 10, 2025

Datadog Report

Branch report: watson/speed-up-di-tests
Commit report: 37c1fc9
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1091 Passed, 0 Skipped, 19m 27.55s Total Time
❄️ 3 New Flaky

New Flaky Tests (3)

  • cypress@latest commonJS flaky test retries is disabled if DD_CIVISIBILITY_FLAKY_RETRY_ENABLED is false - integration-tests/cypress/cypress.spec.js - Last Failure

    Expand for error
     expected +0 to equal 1
    
  • cypress@latest commonJS flaky test retries retries DD_CIVISIBILITY_FLAKY_RETRY_COUNT times - integration-tests/cypress/cypress.spec.js - Last Failure

    Expand for error
     expected +0 to equal 1
    
  • cypress@latest commonJS flaky test retries retries flaky tests - integration-tests/cypress/cypress.spec.js - Last Failure

    Expand for error
     expected +0 to equal 1
    

@watson watson force-pushed the watson/speed-up-di-tests branch from 60815c3 to de9c62b Compare June 10, 2025 10:38
Base automatically changed from watson/DEBUG-4006/support-changing-upload-interval to master June 10, 2025 19:24
Increase the RC poll interval in the Dynamic Instrumentation integration
tests, so that they run faster.
@watson watson force-pushed the watson/speed-up-di-tests branch from de9c62b to e7fd29a Compare June 10, 2025 19:26
@watson watson marked this pull request as ready for review June 10, 2025 19:26
@watson watson requested review from a team as code owners June 10, 2025 19:26
@BridgeAR BridgeAR enabled auto-merge (squash) June 10, 2025 19:30
@BridgeAR BridgeAR merged commit 784197d into master Jun 10, 2025
384 of 506 checks passed
@BridgeAR BridgeAR deleted the watson/speed-up-di-tests branch June 10, 2025 19:35
}]

t.agent.on('remote-config-ack-update', (id, version, state, error) => {
// Due to the very short DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS, there's a race condition in which we might
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any scenario where we'd want to test UNACKNOWLEDGED? If not I think this could be moved to the publisher side. This is especially true since it will need to be repeated again (the code and the comment) in basically every existing and new test otherwise.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have tests for UNACKNOWLEDGED in the packages/dd-trace/test/remote_config/manager.spec.js file, if that's what you mean?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant for DI specifically since t.agent belong to it. So if you only ever care about acknowledged, having the early return in the fake agent would remove the need to repeat this everywhere.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, got'ya. I'll look into cleaning this up. Or alternatively, maybe I should have an UNACKNOWLEDGED test here as well. Not sure 🤔

ghost pushed a commit that referenced this pull request Jun 11, 2025
Increase the RC poll interval in the Dynamic Instrumentation integration
tests, so that they run faster.
This was referenced Jun 11, 2025
ghost pushed a commit that referenced this pull request Jun 12, 2025
Increase the RC poll interval in the Dynamic Instrumentation integration
tests, so that they run faster.
szegedi pushed a commit that referenced this pull request Jun 12, 2025
Increase the RC poll interval in the Dynamic Instrumentation integration
tests, so that they run faster.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants