Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Overall package sizeSelf size: 9.63 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5863 +/- ##
=======================================
Coverage 80.75% 80.75%
=======================================
Files 464 464
Lines 19910 19910
=======================================
Hits 16078 16078
Misses 3832 3832 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-06-10 10:48:00 Comparing candidate commit de9c62b32ebbded151f2337e620a581faffd07f3 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 1276 metrics, 47 unstable metrics. |
Datadog ReportBranch report: ✅ 0 Failed, 1091 Passed, 0 Skipped, 19m 27.55s Total Time New Flaky Tests (3)
|
60815c3 to
de9c62b
Compare
Increase the RC poll interval in the Dynamic Instrumentation integration tests, so that they run faster.
de9c62b to
e7fd29a
Compare
| }] | ||
|
|
||
| t.agent.on('remote-config-ack-update', (id, version, state, error) => { | ||
| // Due to the very short DD_REMOTE_CONFIG_POLL_INTERVAL_SECONDS, there's a race condition in which we might |
There was a problem hiding this comment.
Is there any scenario where we'd want to test UNACKNOWLEDGED? If not I think this could be moved to the publisher side. This is especially true since it will need to be repeated again (the code and the comment) in basically every existing and new test otherwise.
There was a problem hiding this comment.
We have tests for UNACKNOWLEDGED in the packages/dd-trace/test/remote_config/manager.spec.js file, if that's what you mean?
There was a problem hiding this comment.
I meant for DI specifically since t.agent belong to it. So if you only ever care about acknowledged, having the early return in the fake agent would remove the need to repeat this everywhere.
There was a problem hiding this comment.
Ah, got'ya. I'll look into cleaning this up. Or alternatively, maybe I should have an UNACKNOWLEDGED test here as well. Not sure 🤔
Increase the RC poll interval in the Dynamic Instrumentation integration tests, so that they run faster.
Increase the RC poll interval in the Dynamic Instrumentation integration tests, so that they run faster.
Increase the RC poll interval in the Dynamic Instrumentation integration tests, so that they run faster.

What does this PR do?
Increase the RC poll interval in the Dynamic Instrumentation integration tests, so that they run faster.
Debugger CI run performance improvement:
Motivation
Plugin Checklist
Additional Notes