Skip to content

Update pprof-nodejs to 5.8.2#5866

Merged
szegedi merged 2 commits intomasterfrom
szegedi/fix-profiler-worker-crashes
Jun 12, 2025
Merged

Update pprof-nodejs to 5.8.2#5866
szegedi merged 2 commits intomasterfrom
szegedi/fix-profiler-worker-crashes

Conversation

@szegedi
Copy link
Copy Markdown
Contributor

@szegedi szegedi commented Jun 10, 2025

What does this PR do?

Updates pprof-nodejs to 5.8.2

Motivation

5.8.2 fixes a bug in profiler where cleanup was missed in worker threads when they were stopped using Worker.terminate(), leading to crashes. See DataDog/pprof-nodejs#215.

Additional Notes

Jira: SCP-759

Comment thread package.json Outdated
@szegedi szegedi force-pushed the szegedi/fix-profiler-worker-crashes branch from 8cd51a5 to edfc712 Compare June 12, 2025 08:17
@szegedi szegedi changed the title Update pprof-nodejs to 5.8.1 Update pprof-nodejs to 5.8.2 Jun 12, 2025
@szegedi szegedi force-pushed the szegedi/fix-profiler-worker-crashes branch from edfc712 to 0111a1f Compare June 12, 2025 08:18
@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 9.65 MB
Deduped: 101.6 MB
No deduping: 102.12 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.8.2 | 9.56 MB | 9.93 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@szegedi szegedi marked this pull request as ready for review June 12, 2025 08:20
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (5e417ca) to head (e096f36).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5866   +/-   ##
=======================================
  Coverage   80.74%   80.74%           
=======================================
  Files         462      462           
  Lines       19896    19896           
=======================================
  Hits        16065    16065           
  Misses       3831     3831           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 12, 2025

Benchmarks

Benchmark execution time: 2025-06-12 08:28:27

Comparing candidate commit e096f36 in PR branch szegedi/fix-profiler-worker-crashes with baseline commit 5e417ca in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1274 metrics, 49 unstable metrics.

@datadog-datadog-prod-us1
Copy link
Copy Markdown

Datadog Report

Branch report: szegedi/fix-profiler-worker-crashes
Commit report: 7b0b633
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1256 Passed, 0 Skipped, 21m 52.17s Total Time

@szegedi szegedi enabled auto-merge (squash) June 12, 2025 08:32
@szegedi szegedi merged commit cafe33b into master Jun 12, 2025
533 of 535 checks passed
@szegedi szegedi deleted the szegedi/fix-profiler-worker-crashes branch June 12, 2025 08:35
@ghost ghost mentioned this pull request Jun 12, 2025
ghost pushed a commit that referenced this pull request Jun 12, 2025
szegedi added a commit that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants