Skip to content

chore: temporarily restrict yarn audit to prod deps only in CI#5874

Merged
watson merged 1 commit intomasterfrom
watson/temp-disable-yarn-audit
Jun 11, 2025
Merged

chore: temporarily restrict yarn audit to prod deps only in CI#5874
watson merged 1 commit intomasterfrom
watson/temp-disable-yarn-audit

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Jun 11, 2025

There's a potential ReDoS vulnerability in brace-expansion which is a dev-sub-dependency of ours (the dd-trace package is not vulnerable). As of now, we don't have an upgrade path, which unfortunately means this blocks all CI.

Temporarily disable running yarn audit on dev-dependencies to allow work to be done in the repo.

Alternative approach tried and failed: #5873

@watson watson self-assigned this Jun 11, 2025
Copy link
Copy Markdown
Collaborator Author

watson commented Jun 11, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 11, 2025

Overall package size

Self size: 9.64 MB
Deduped: 104.59 MB
No deduping: 105.11 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.6.0 | 30.47 MB | 30.47 MB | | @datadog/native-appsec | 8.5.2 | 19.33 MB | 19.34 MB | | @datadog/pprof | 5.8.0 | 12.55 MB | 12.92 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.3 | 2.95 MB | 5.6 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.14.0 | 120.58 kB | 841.68 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | dc-polyfill | 0.1.9 | 25.11 kB | 25.11 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@watson watson marked this pull request as ready for review June 11, 2025 07:59
@watson watson requested a review from a team as a code owner June 11, 2025 07:59
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.75%. Comparing base (94e55a2) to head (05f4884).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5874   +/-   ##
=======================================
  Coverage   80.75%   80.75%           
=======================================
  Files         464      464           
  Lines       19910    19910           
=======================================
  Hits        16078    16078           
  Misses       3832     3832           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

IlyasShabi
IlyasShabi previously approved these changes Jun 11, 2025
@watson watson force-pushed the watson/temp-disable-yarn-audit branch from 5845e67 to 401e162 Compare June 11, 2025 08:04
@watson watson changed the title chore: temporarily disable yarn audit in CI chore: temporarily restrict yarn audit to prod deps only in CI Jun 11, 2025
There's a potential ReDoS vulnerability in `brace-expansion` which is a
dev-sub-dependency of ours (the `dd-trace` is not vulnerable). As of
now, we don't have an upgrade path, which unfortunately means this
blocks all CI.

Temporarily disable `yarn audit` to allow work to be done in the repo.
@watson watson force-pushed the watson/temp-disable-yarn-audit branch from 401e162 to 05f4884 Compare June 11, 2025 08:05
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 11, 2025

Benchmarks

Benchmark execution time: 2025-06-11 08:15:59

Comparing candidate commit 05f4884 in PR branch watson/temp-disable-yarn-audit with baseline commit 94e55a2 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1269 metrics, 54 unstable metrics.

@watson watson enabled auto-merge (squash) June 11, 2025 08:08
@datadog-datadog-prod-us1
Copy link
Copy Markdown

Datadog Report

Branch report: watson/temp-disable-yarn-audit
Commit report: 79d5a13
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 1088 Passed, 0 Skipped, 19m 26.92s Total Time

@watson watson merged commit fab3ee9 into master Jun 11, 2025
417 of 506 checks passed
@watson watson deleted the watson/temp-disable-yarn-audit branch June 11, 2025 08:17
ghost pushed a commit that referenced this pull request Jun 12, 2025
There's a potential ReDoS vulnerability in `brace-expansion` which is a
dev-sub-dependency of ours (the `dd-trace` is not vulnerable). As of
now, we don't have an upgrade path, which unfortunately means this
blocks all CI.

Temporarily disable running `yarn audit` on dev-dependencies to allow work
to be done in the repo.
This was referenced Jun 12, 2025
ghost pushed a commit that referenced this pull request Jun 12, 2025
There's a potential ReDoS vulnerability in `brace-expansion` which is a
dev-sub-dependency of ours (the `dd-trace` is not vulnerable). As of
now, we don't have an upgrade path, which unfortunately means this
blocks all CI.

Temporarily disable running `yarn audit` on dev-dependencies to allow work
to be done in the repo.
szegedi pushed a commit that referenced this pull request Jun 12, 2025
There's a potential ReDoS vulnerability in `brace-expansion` which is a
dev-sub-dependency of ours (the `dd-trace` is not vulnerable). As of
now, we don't have an upgrade path, which unfortunately means this
blocks all CI.

Temporarily disable running `yarn audit` on dev-dependencies to allow work
to be done in the repo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants