fix(types): update incorrect tracer option names#6526
Merged
watson merged 2 commits intoDataDog:masterfrom Nov 26, 2025
Merged
Conversation
watson
previously approved these changes
Sep 26, 2025
Collaborator
watson
left a comment
watson
left a comment
There was a problem hiding this comment.
Hi @sophiebits
Thank you for contributing and fixing the types 💯
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6526 +/- ##
==========================================
- Coverage 84.08% 84.08% -0.01%
==========================================
Files 484 484
Lines 20277 20277
==========================================
- Hits 17050 17049 -1
- Misses 3227 3228 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
watson
approved these changes
Sep 26, 2025
Contributor
Author
|
Thanks for the test fix! |
Collaborator
|
@sophiebits My pleasure. Since I added a commit, I'm just waiting for a 2nd review from someone else before it can be merged |
BridgeAR
approved these changes
Sep 27, 2025
Member
|
@sophiebits the PR is highly appreciated! Thank you from me as well :) Could you verify your signature? We can otherwise not merge the PR as is and would have to rebase on our own and force push. |
watson
force-pushed
the
sophiebits/types
branch
from
c9f448a to
a6d2a1c
Compare
These are outdated or typoed. There are other options which are not named in the types which I haven't added in this PR. Signed-off-by: Thomas Watson <thomas.watson@datadoghq.com>
Signed-off-by: Thomas Watson <thomas.watson@datadoghq.com>
watson
force-pushed
the
sophiebits/types
branch
from
946e77f to
2e57439
Compare
Collaborator
|
Thanks again. I co-signed your commits, so now we could merge it. It will be included in the next release |
Contributor
Author
|
Thank you! |
Contributor
Author
|
I missed your comment @BridgeAR, sorry about that. |
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Nov 27, 2025
* fix(types): update incorrect tracer option names These are outdated or typoed. There are other options which are not named in the types which I haven't added in this PR. Signed-off-by: Thomas Watson <thomas.watson@datadoghq.com> * Fix type:test Signed-off-by: Thomas Watson <thomas.watson@datadoghq.com> --------- Signed-off-by: Thomas Watson <thomas.watson@datadoghq.com> Co-authored-by: Thomas Watson <thomas.watson@datadoghq.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Dec 17, 2025
* fix(types): update incorrect tracer option names These are outdated or typoed. There are other options which are not named in the types which I haven't added in this PR. Signed-off-by: Thomas Watson <thomas.watson@datadoghq.com> * Fix type:test Signed-off-by: Thomas Watson <thomas.watson@datadoghq.com> --------- Signed-off-by: Thomas Watson <thomas.watson@datadoghq.com> Co-authored-by: Thomas Watson <thomas.watson@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are outdated or typoed. There are other options which are not named in the types which I haven't added in this PR.