Skip to content

[test optimization][STV-59] Fix jest.mock for multi worker setups#6729

Merged
BridgeAR merged 3 commits intomasterfrom
juan-fernandez/remove-listener-before-setting-it-again
Oct 24, 2025
Merged

[test optimization][STV-59] Fix jest.mock for multi worker setups#6729
BridgeAR merged 3 commits intomasterfrom
juan-fernandez/remove-listener-before-setting-it-again

Conversation

@juan-fernandez
Copy link
Copy Markdown
Collaborator

@juan-fernandez juan-fernandez commented Oct 23, 2025

What does this PR do?

Clean up the previous message listener before adding the updated one. I'm not sure why this triggered this specific error, but it seems sensible to me anyway.

Motivation

Fix issue reported in https://github.com/deecewan/dd-trace-mwe/

    Cannot find module 'some-package' from 'jest.setup.js'

    > 1 | jest.mock('some-package', () => {
        |      ^
      2 |   return jest.fn(() => 'Hello, mocked world!')
      3 | });

This happened whenever using jest.mock on an internal package and multi-worker jest setup.

Plugin Checklist

  • Integration tests.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 23, 2025

Overall package size

Self size: 12.92 MB
Deduped: 115.62 MB
No deduping: 117.83 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.11.1 | 9.96 MB | 10.34 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.73 MB | | @datadog/wasm-js-rewriter | 4.0.1 | 2.85 MB | 3.58 MB | | @opentelemetry/resources | 1.9.1 | 306.54 kB | 1.74 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.206.0 | 201.39 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.1.0-preview.12 | 95.11 kB | 401.68 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.13%. Comparing base (dbefc61) to head (57e3b4a).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6729      +/-   ##
==========================================
- Coverage   84.13%   84.13%   -0.01%     
==========================================
  Files         505      504       -1     
  Lines       21038    21035       -3     
==========================================
- Hits        17701    17698       -3     
  Misses       3337     3337              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@deecewan
Copy link
Copy Markdown

looks like this works great! thanks so much for fixing this.

@juan-fernandez juan-fernandez marked this pull request as ready for review October 24, 2025 09:07
@juan-fernandez juan-fernandez requested a review from a team as a code owner October 24, 2025 09:07
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Oct 24, 2025

Benchmarks

Benchmark execution time: 2025-10-24 09:17:18

Comparing candidate commit 57e3b4a in PR branch juan-fernandez/remove-listener-before-setting-it-again with baseline commit dbefc61 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1610 metrics, 60 unstable metrics.

@datadog-datadog-prod-us1

This comment has been minimized.

@juan-fernandez juan-fernandez changed the title [test optimization] Fix multi worker setup in jest [test optimization] Fix jest.mock for multi worker setups Oct 24, 2025
@juan-fernandez juan-fernandez changed the title [test optimization] Fix jest.mock for multi worker setups [test optimization][STV-59] Fix jest.mock for multi worker setups Oct 24, 2025
@BridgeAR BridgeAR merged commit 43d8bc7 into master Oct 24, 2025
760 checks passed
@BridgeAR BridgeAR deleted the juan-fernandez/remove-listener-before-setting-it-again branch October 24, 2025 09:56
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Oct 25, 2025
dd-octo-sts Bot pushed a commit that referenced this pull request Oct 25, 2025
…6729)

* fix listener

* add integration test

* add stdout check
juan-fernandez added a commit that referenced this pull request Oct 27, 2025
…6729)

* fix listener

* add integration test

* add stdout check
@juan-fernandez
Copy link
Copy Markdown
Collaborator Author

juan-fernandez commented Oct 27, 2025

@deecewan https://github.com/DataDog/dd-trace-js/releases/tag/v5.74.0 should include the fix for your reported issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants