Skip to content

ci: set benchmarking jobs to be interruptible outside master#6940

Merged
igoragoli merged 8 commits intomasterfrom
augusto.deoliveira/apmsp-2369.ensure-correct-interrupt-policy
Nov 21, 2025
Merged

ci: set benchmarking jobs to be interruptible outside master#6940
igoragoli merged 8 commits intomasterfrom
augusto.deoliveira/apmsp-2369.ensure-correct-interrupt-policy

Conversation

@igoragoli
Copy link
Copy Markdown
Contributor

@igoragoli igoragoli commented Nov 18, 2025

What does this PR do?

  • Set interruptible: true on benchmarking jobs outside master as they become redundant on new runs.
    • Do the same for serverless benchmarks, since recent benchmarks still become redundant on new runs inside development branches.
  • Change macrobenchmark runner type to runner:apm-k8s-m7i-metal since they're also run on every branch.

Motivation

#incident-45572 and APMSP-2369.

Why set jobs to interruptible? Because by doing so, we prevent redundant runs from overloading our APM runner capacity.

Why only outside of master? Because benchmarks on master are never redundant: we need every run on master to collect results and maintain a continuous performance history.

Additional Notes

@igoragoli igoragoli requested a review from a team as a code owner November 18, 2025 10:10
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.61%. Comparing base (4955d6d) to head (b399dff).
⚠️ Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6940      +/-   ##
==========================================
+ Coverage   84.37%   84.61%   +0.23%     
==========================================
  Files         503      505       +2     
  Lines       21069    21163      +94     
==========================================
+ Hits        17778    17908     +130     
+ Misses       3291     3255      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@igoragoli igoragoli marked this pull request as draft November 18, 2025 10:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 18, 2025

Overall package size

Self size: 13.23 MB
Deduped: 116.13 MB
No deduping: 131.15 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/native-iast-taint-tracking | 4.0.0 | 11.72 MB | 11.73 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.1 | 90.58 kB | 90.58 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 18, 2025

Benchmarks

Benchmark execution time: 2025-11-19 05:31:05

Comparing candidate commit b399dff in PR branch augusto.deoliveira/apmsp-2369.ensure-correct-interrupt-policy with baseline commit 4955d6d in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 289 metrics, 31 unstable metrics.

@igoragoli igoragoli marked this pull request as ready for review November 18, 2025 10:32
@igoragoli igoragoli requested a review from duncanista November 18, 2025 10:33
@datadog-datadog-prod-us1

This comment has been minimized.

duncanista
duncanista previously approved these changes Nov 18, 2025
Copy link
Copy Markdown
Contributor

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from Serverless!

Comment thread .gitlab/macrobenchmarks.yml Outdated
Comment thread .gitlab/macrobenchmarks.yml Outdated
Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
@igoragoli igoragoli enabled auto-merge (squash) November 20, 2025 16:05
@igoragoli igoragoli dismissed BridgeAR’s stale review November 21, 2025 12:26

Sufficient approvals with write access.

@igoragoli igoragoli merged commit 68516f7 into master Nov 21, 2025
822 of 823 checks passed
@igoragoli igoragoli deleted the augusto.deoliveira/apmsp-2369.ensure-correct-interrupt-policy branch November 21, 2025 12:26
dd-octo-sts Bot pushed a commit that referenced this pull request Nov 22, 2025
* set benchmarking jobs to be interruptible outside main

* set serverless benchmarking jobs to be interruptible outside main

* change macrobenchmark runner type since they're also run on every branch

* test interruptibility

* test interruptibility

* set workflow:auto_cancel:on_new_commit to interruptible

* test interruptibility

* Update .gitlab/macrobenchmarks.yml

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

---------

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Nov 22, 2025
BridgeAR added a commit that referenced this pull request Dec 17, 2025
* set benchmarking jobs to be interruptible outside main

* set serverless benchmarking jobs to be interruptible outside main

* change macrobenchmark runner type since they're also run on every branch

* test interruptibility

* test interruptibility

* set workflow:auto_cancel:on_new_commit to interruptible

* test interruptibility

* Update .gitlab/macrobenchmarks.yml

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>

---------

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants