Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6943 +/- ##
=======================================
Coverage 84.52% 84.52%
=======================================
Files 527 527
Lines 22534 22534
=======================================
Hits 19047 19047
Misses 3487 3487 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Overall package sizeSelf size: 4.37 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 2.0.0 | 68.46 kB | 797.03 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
BridgeAR
left a comment
There was a problem hiding this comment.
The tests are sadly still failing
BenchmarksBenchmark execution time: 2026-01-08 10:42:49 Comparing candidate commit 42c7423 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 288 metrics, 32 unstable metrics. |
BridgeAR
left a comment
There was a problem hiding this comment.
Could you please add a regression test that checks that ctx.batch._spanContexts is not changed anymore?
This comment has been minimized.
This comment has been minimized.
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM, while it would be nice to undo the unrelated changes :)
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM, it would just be nice if the unrelated changes could be undone before landing :)
BridgeAR
left a comment
There was a problem hiding this comment.
LGTM! Thank you for cleaning things up :)
…/core-test/client.spec.js Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
…/core-test/client.spec.js Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
…/core-test/client.spec.js Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
…/batchSpanContextRegressionTest/client.spec.js Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
f7cc36c to
42c7423
Compare
…6943) An incorrect usage of tracePromise on a synchronous function is fixed as well using the proper context for spans. Formerly Azure's EventHubs batch context was used for that.
…6943) An incorrect usage of tracePromise on a synchronous function is fixed as well using the proper context for spans. Formerly Azure's EventHubs batch context was used for that.
What does this PR do?
Motivation
Originally we used Azure's built in spanContext map to store span context for our span links. This could cause conflicts with Azure Application Inights if OTel is enabled, because Azure uses this map to generate their span links.
Plugin Checklist
Additional Notes