chore: type-cast server.address() calls#6965
Merged
Conversation
Contributor
Overall package sizeSelf size: 13.28 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @datadog/native-iast-taint-tracking | 4.1.0 | 9.01 MB | 9.02 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.1 | 90.58 kB | 90.58 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6965 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 505 505
Lines 21171 21171
=======================================
Hits 17913 17913
Misses 3258 3258 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-11-22 10:20:45 Comparing candidate commit 20be721 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 289 metrics, 31 unstable metrics. |
watson
added a commit
that referenced
this pull request
Nov 22, 2025
Address a large majority of the TS type errors in the debugger code. The only actual change to the runtime logic is the following: When adding a new breakpoint to a file that has a source map, we now validate that the generated position can be identified. If not, we abort and don't add the breakpoint (which most likely would have failed anyway). An error will be send to the debugger diagnostics endpoint if that happens. Another minor, but hopefully invisible change, is that all private fields in the `JSONBuffer` class are now properly private instead of just being prefixed with an underscore. The only debugger TS errors not addressed in this commit are the following: - The ones already addressed in #6965 - The ones which will disappear once #6951 lands This commit also adds a `tsconfig.debugger.json` file, which can be used to check the types of the debugger code: ./node_modules/.bin/tsc --noEmit -p tsconfig.debugger.json
watson
added a commit
that referenced
this pull request
Nov 22, 2025
Address a large majority of the TS type errors in the debugger code. The only actual change to the runtime logic is the following: When adding a new breakpoint to a file that has a source map, we now validate that the generated position can be identified. If not, we abort and don't add the breakpoint (which most likely would have failed anyway). An error will be send to the debugger diagnostics endpoint if that happens. Another minor, but hopefully invisible change, is that all private fields in the `JSONBuffer` class are now properly private instead of just being prefixed with an underscore. The only debugger TS errors not addressed in this commit are the following: - The ones already addressed in #6965 - The ones which will disappear once #6951 lands This commit also adds a `tsconfig.debugger.json` file, which can be used to check the types of the debugger code: ./node_modules/.bin/tsc --noEmit -p tsconfig.debugger.json
Avoid TS complaining about `address()` possibly returning `null`.
watson
force-pushed
the
watson/fix-server-address-typings
branch
from
608c54c to
20be721
Compare
|
BridgeAR
approved these changes
Nov 22, 2025
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Nov 23, 2025
Avoid TS complaining about `address()` possibly returning `null`.
Merged
watson
added a commit
that referenced
this pull request
Nov 23, 2025
Address a large majority of the TS type errors in the debugger code. The only actual change to the runtime logic is the following: When adding a new breakpoint to a file that has a source map, we now validate that the generated position can be identified. If not, we abort and don't add the breakpoint (which most likely would have failed anyway). An error will be sent to the debugger diagnostics endpoint if that happens. Another minor, but hopefully invisible change, is that all private fields in the `JSONBuffer` class are now properly private instead of just being prefixed with an underscore. The only debugger TS errors not addressed in this commit are the following: - The ones already addressed in #6965 - The ones which will disappear once #6951 lands This commit also adds a `tsconfig.debugger.json` file, which can be used to check the types of the debugger code: ./node_modules/.bin/tsc --noEmit -p tsconfig.debugger.json
dd-octo-sts Bot
pushed a commit
that referenced
this pull request
Nov 24, 2025
Address a large majority of the TS type errors in the debugger code. The only actual change to the runtime logic is the following: When adding a new breakpoint to a file that has a source map, we now validate that the generated position can be identified. If not, we abort and don't add the breakpoint (which most likely would have failed anyway). An error will be sent to the debugger diagnostics endpoint if that happens. Another minor, but hopefully invisible change, is that all private fields in the `JSONBuffer` class are now properly private instead of just being prefixed with an underscore. The only debugger TS errors not addressed in this commit are the following: - The ones already addressed in #6965 - The ones which will disappear once #6951 lands This commit also adds a `tsconfig.debugger.json` file, which can be used to check the types of the debugger code: ./node_modules/.bin/tsc --noEmit -p tsconfig.debugger.json
BridgeAR
pushed a commit
that referenced
this pull request
Dec 17, 2025
Avoid TS complaining about `address()` possibly returning `null`.
BridgeAR
pushed a commit
that referenced
this pull request
Dec 17, 2025
Address a large majority of the TS type errors in the debugger code. The only actual change to the runtime logic is the following: When adding a new breakpoint to a file that has a source map, we now validate that the generated position can be identified. If not, we abort and don't add the breakpoint (which most likely would have failed anyway). An error will be sent to the debugger diagnostics endpoint if that happens. Another minor, but hopefully invisible change, is that all private fields in the `JSONBuffer` class are now properly private instead of just being prefixed with an underscore. The only debugger TS errors not addressed in this commit are the following: - The ones already addressed in #6965 - The ones which will disappear once #6951 lands This commit also adds a `tsconfig.debugger.json` file, which can be used to check the types of the debugger code: ./node_modules/.bin/tsc --noEmit -p tsconfig.debugger.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Change all
server.address().calls to:serveris being chained, e.g.app.server.Motivation
Avoid TS complaining about
address()possibly returningnull.