Skip to content

chore: fix error in .vscode/settings.json#6977

Merged
watson merged 1 commit intomasterfrom
watson/fix-vscode-settings
Nov 24, 2025
Merged

chore: fix error in .vscode/settings.json#6977
watson merged 1 commit intomasterfrom
watson/fix-vscode-settings

Conversation

@watson
Copy link
Copy Markdown
Collaborator

@watson watson commented Nov 24, 2025

What does this PR do?

This PR removes the overrideConfigFile setting since it wasn't really needed as VSCode would default to look for eslint.config.mjs (amongst other variants) in the root directory eventually (traversing the directory structure up). The important fix in the commit where this config option was added was workingDirectories, which we keep.

Motivation

The overrideConfigFile setting doesn't support template strings, so VSCode was trying to look for a directory litterally named ${workspaceFolder} and failed.

The `overrideConfigFile` setting doesn't support template strings, so
VSCode was trying to look for a directory litterally named
`${workspaceFolder}` and failed.

This commit remos the setting entirely since it wasn't really needed as
VSCode would default to look for `eslint.config.mjs` (amongst other
variants) in the root directory eventually (traversing the directory
structure up). The important fix in the commit where this config option
was added was `workingDirectories`, which we keep.
@watson watson requested a review from a team as a code owner November 24, 2025 13:55
Copy link
Copy Markdown
Collaborator Author

watson commented Nov 24, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@watson watson self-assigned this Nov 24, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Overall package size

Self size: 13.38 MB
Deduped: 113.58 MB
No deduping: 128.59 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @datadog/native-iast-taint-tracking | 4.1.0 | 9.01 MB | 9.02 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.2 | 90.79 kB | 90.79 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 24, 2025

Benchmarks

Benchmark execution time: 2025-11-24 14:10:51

Comparing candidate commit a4a273c in PR branch watson/fix-vscode-settings with baseline commit e137afe in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 287 metrics, 33 unstable metrics.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.81%. Comparing base (e137afe) to head (a4a273c).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6977   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files         513      513           
  Lines       21521    21521           
=======================================
  Hits        18253    18253           
  Misses       3268     3268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@watson watson merged commit 572f6b7 into master Nov 24, 2025
886 of 889 checks passed
@watson watson deleted the watson/fix-vscode-settings branch November 24, 2025 14:54
dd-octo-sts Bot pushed a commit that referenced this pull request Nov 25, 2025
The `overrideConfigFile` setting doesn't support template strings, so
VSCode was trying to look for a directory litterally named
`${workspaceFolder}` and failed.

This commit removes the setting entirely since it wasn't really needed as
VSCode would default to look for `eslint.config.mjs` (amongst other
variants) in the root directory eventually (traversing the directory
structure up). The important fix in the commit where this config option
was added was `workingDirectories`, which we keep.
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Nov 25, 2025
BridgeAR pushed a commit that referenced this pull request Dec 17, 2025
The `overrideConfigFile` setting doesn't support template strings, so
VSCode was trying to look for a directory litterally named
`${workspaceFolder}` and failed.

This commit removes the setting entirely since it wasn't really needed as
VSCode would default to look for `eslint.config.mjs` (amongst other
variants) in the root directory eventually (traversing the directory
structure up). The important fix in the commit where this config option
was added was `workingDirectories`, which we keep.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants