Skip to content

[test optimization] Do not retry if test isolation is not enabled in cypress#6978

Merged
juan-fernandez merged 7 commits intomasterfrom
juan-fernandez/test-isolation-in-cypress
Nov 26, 2025
Merged

[test optimization] Do not retry if test isolation is not enabled in cypress#6978
juan-fernandez merged 7 commits intomasterfrom
juan-fernandez/test-isolation-in-cypress

Conversation

@juan-fernandez
Copy link
Copy Markdown
Collaborator

@juan-fernandez juan-fernandez commented Nov 24, 2025

What does this PR do?

From cypress 12, cypress added a test isolation parameter. Its default is true, but if it's explicitly set to false, it means that your tests have side effect and can't retried safely. Since some of our features do in fact retry tests, we should have a look at this parameter and prevent retries from happening if it's set to false. This is what's done in this PR. Additionally we:

  • Add the retries right after the test that's cloned, rather than at the beginning of the test suite. This increases the likelihood that retries do indeed work, even if they have unintended side effects.
  • Add warnings if we detect that test isolation is false.
  • Add log telling the user that the test is being retried because of datadog.

Motivation

Fixes #6884

Plugin Checklist

  • Integration tests.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 24, 2025

Overall package size

Self size: 13.41 MB
Deduped: 113.61 MB
No deduping: 128.62 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @datadog/native-iast-taint-tracking | 4.1.0 | 9.01 MB | 9.02 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.2 | 90.79 kB | 90.79 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-official

This comment has been minimized.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Nov 24, 2025

Benchmarks

Benchmark execution time: 2025-11-25 15:46:08

Comparing candidate commit 1d582ce in PR branch juan-fernandez/test-isolation-in-cypress with baseline commit e137afe in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 291 metrics, 29 unstable metrics.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.81%. Comparing base (e137afe) to head (1d582ce).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6978   +/-   ##
=======================================
  Coverage   84.81%   84.81%           
=======================================
  Files         513      513           
  Lines       21521    21521           
=======================================
  Hits        18253    18253           
  Misses       3268     3268           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juan-fernandez juan-fernandez marked this pull request as ready for review November 25, 2025 16:10
@juan-fernandez juan-fernandez requested review from a team as code owners November 25, 2025 16:10
@juan-fernandez juan-fernandez merged commit 998a916 into master Nov 26, 2025
816 of 817 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/test-isolation-in-cypress branch November 26, 2025 09:34
dd-octo-sts Bot pushed a commit that referenced this pull request Nov 26, 2025
@dd-octo-sts dd-octo-sts Bot mentioned this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Cypress test observability does not respect "test isolation" in Cypress

2 participants