ci: enable SLO change detection, make benchmark checks interruptible#7005
ci: enable SLO change detection, make benchmark checks interruptible#7005
Conversation
Overall package sizeSelf size: 13.41 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.7.0 | 35.02 MB | 35.02 MB | | @datadog/native-appsec | 10.3.0 | 20.73 MB | 20.74 MB | | @datadog/pprof | 5.12.0 | 11.19 MB | 11.57 MB | | @datadog/native-iast-taint-tracking | 4.1.0 | 9.01 MB | 9.02 MB | | @opentelemetry/resources | 1.30.1 | 557.67 kB | 7.71 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.5.4 | 2.95 MB | 5.83 MB | | @datadog/wasm-js-rewriter | 5.0.1 | 2.82 MB | 3.53 MB | | @datadog/native-metrics | 3.1.1 | 1.02 MB | 1.43 MB | | @opentelemetry/api-logs | 0.208.0 | 199.48 kB | 1.42 MB | | @opentelemetry/api | 1.9.0 | 1.22 MB | 1.22 MB | | jsonpath-plus | 10.3.0 | 617.18 kB | 1.08 MB | | import-in-the-middle | 1.15.0 | 127.66 kB | 856.24 kB | | lru-cache | 10.4.3 | 804.3 kB | 804.3 kB | | @datadog/openfeature-node-server | 0.2.0 | 118.51 kB | 437.19 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | source-map | 0.7.6 | 185.63 kB | 185.63 kB | | pprof-format | 2.2.1 | 163.06 kB | 163.06 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | @isaacs/ttlcache | 2.1.2 | 90.79 kB | 90.79 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 7.0.5 | 63.38 kB | 63.38 kB | | istanbul-lib-coverage | 3.2.2 | 34.37 kB | 34.37 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | dc-polyfill | 0.1.10 | 26.73 kB | 26.73 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | shell-quote | 1.8.3 | 23.74 kB | 23.74 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | mutexify | 1.4.0 | 5.71 kB | 8.74 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | module-details-from-path | 1.0.4 | 3.96 kB | 3.96 kB | | escape-string-regexp | 5.0.0 | 3.66 kB | 3.66 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7005 +/- ##
=======================================
Coverage 84.81% 84.81%
=======================================
Files 513 513
Lines 21521 21521
=======================================
Hits 18253 18253
Misses 3268 3268 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2025-11-27 09:49:18 Comparing candidate commit 240f548 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 283 metrics, 27 unstable metrics. |
|
…7005) * make notify-slo-breaches when: always explicit * add slo change detection * check-big-regression should mimic benchmarks rules * (check|notify)-slo-breaches should mimic macrobenchmarks rules * trigger ci: are micros and macros interrupted? * test SLO change detection * Revert "test SLO change detection" This reverts commit a2bfd86. * fix dd-octo-sts self.gitlab.read trust policy name
…7005) * make notify-slo-breaches when: always explicit * add slo change detection * check-big-regression should mimic benchmarks rules * (check|notify)-slo-breaches should mimic macrobenchmarks rules * trigger ci: are micros and macros interrupted? * test SLO change detection * Revert "test SLO change detection" This reverts commit a2bfd86. * fix dd-octo-sts self.gitlab.read trust policy name

What does this PR do?
- when: on_successrule.- when: on_successprevents subsequent rules from being reached.Motivation
https://datadoghq.atlassian.net/browse/APMSP-2373
Plugin Checklist
Additional Notes
when: on_successwas not included oncheck-big-regressions's rules since it's GitLab's default behavior forwhen: https://docs.gitlab.com/ci/yaml/#when